When comment validation fails you end up on a different page

Drupal 7
i have recreated this error
first i installed standard version
Created a blank page node with comments enabled
Submitted comment with blank comment body
result sent me to "http://localhost:8082/comment/reply/2"
expected results should have been "http://localhost:8082/node/reply/2"

I tried this out locally to confirm the behavior and did some thinking about the issue. It's no longer a concern in 8.x because of a JS check for required fields: one cannot submit the comment form without the required fields filled.

This is bigger than just the comment error, though: the permalinks for individual comments are things like comment/2#comment-2. If changing this path, we would also change any other comment/x path, and to do so at this point in the D7 product cycle would be abnormal. However, we could consider making that change for D8 (though I don't know how tightly-coupled node and comment will be in D8: there's no reason that comments need to be restricted to nodes only and not used on other entity types, I would think).

I think that a better solution might be to do some preprocessing to add a class (or classes) to the comment/reply page for themers who need something to hook onto there, to style it like the node page.

I have created a test which'll check the URL when the comment form is submitted without any body text. The test will fail if you are not redirected back to node/NID. I'm also changing the issue version to 8.x-dev, because I was able to replicate the issue in both 7.x and 8.x.

I am currently working on a patch for this feature. It's 67% done.
I need to mention that since this is a feature request it will not be backported to Drupal 7.

This is as far as I got with the patch for today.
I replaced the menu items for comment/... with node/$nid/comment/....
I tried to cover all comment/... urls and callbacks.

I also need to update the Comments tests, because with the comment urls changing, they will fail.

I did not test this patch in any way, so please consider this.
So, if you have time before I do, please review the patch as it is now.

#8: comments-change.patch queued for re-testing.

if you need to stop redirect to comment/reply/%node
you just need to comment line 1875 file comment.module
from
if (empty($comment->cid) && empty($comment->pid)) {
$form['#action'] = url('comment/reply/' . $comment->nid);
}

to
if (empty($comment->cid) && empty($comment->pid)) {
// $form['#action'] = url('comment/reply/' . $comment->nid);
}

Why not just manually set the form's ['#action'] to an empty string?

I got this working adding this line on a custom comment-wrapper.tpl.php file, placed in my theme directory :
$content['comment_form']['#action'] = ''; print render($content['comment_form']);

I guess it's also achievable with form_alter.

I updated the tests so that they match the new menu changes.
There are still some tests that are failing on my machine, so can someone please help me out with this.

I changed the patch name to match the convention [project_name]-[description]-[issue_number]-[comment_id].patch.

Fixed patch format

My patch replaces all comment/... paths with node/[nid]/comment/....
Do you think this might be a correct solution?

I just took another look at the issue queue, and saw this task: https://drupal.org/node/731724
I think it makes a lot of sense to decouple the Comment entity from the Node, and thus I believe that it makes the current issue irrelevant, and I believe this issue should be closed.

Let's mark this postponed for now then.

Changing the comment reply url to be correct.

Re: #18

This did the trick for me:

mymodule_form_comment_form_alter(&$form, &$form_state) {
    $form['#action'] = "";
}

Re #30
If you use this one, you will need to redirect the page otherwise if you refresh the page you will get same error
i don't know it is the standard method but i use this one.. it works fine for me

function mymodule_form_comment_form_alter(&$form, &$form_state, &$form_id){
  array_unshift($form['#validate'],'custom_validate_comments');	
  unset($form['#action']);
}
function custom_validate_comments(&$form, &$form_state, $form_id) {
  if(empty($form_state['values']['comment_body']['und'][0]['value'])){
     drupal_goto($_GET['q']);
  }
}

Re #31 This works, but I had to change redirection target to make it work with clean URL. Also, filled in field values are deleted...

EDIT: Simply doing

$form['#action'] = '';

was enough to make it work for me.

#731724: Convert comment settings into a field to make them work with CMI and non-node entities is fixed, so no need to postpone this any more from what I can tell.

This bit us when using reCaptcha on comment forms. If the user doesn't validate captcha, they're redirected to the reply form. The reply form hides the comment form from the main page build so it results in a comment form at the bottom of the page, potentially in a different position which is bad UX. I'm interested to see what tests fail without the action being set in CommentForm as removing it does fix the issue however I assume it will affect threaded comments.

Ported the patch to be usable in Drupal 8.8.2 (different line numbers).

Patch for 8.9 Drupal release.