Problem/Motivation

Drupal 8.4.x uses symfony 3 #2712647: Update Symfony components to ~3.2. But webprofiler module was not ported yet.

This is evident with errors like:

Uncaught Error: Call to undefined method Symfony\Component\DependencyInjection\Reference::isStrict()

Proposed resolution

(Probably) Create a new branch of this module.
Follow the https://github.com/symfony/symfony/blob/2.8/UPGRADE-3.0.md guide

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#11 support_for_symfony_3-2879214-11.patch5.92 KBlussoluca
#8 support_for_symfony_3-2879214-8.patch3.8 KBlussoluca
#3 support_for_symfony_3-2879214-3.patch1.11 KBclemens.tolboom
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dagmar created an issue. See original summary.

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
CreditAttribution: clemens.tolboom as a volunteer commented
Priority: Normal » Major

This seems major to me as I cannot install WebProfiler anymore

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
CreditAttribution: clemens.tolboom as a volunteer commented
FileSize
support_for_symfony_3-2879214-3.patch1.11 KB

Making a naive patch does not help much as that result into

drush @drupal.d8 cache-rebuild 8.x-1.x ✱
Recoverable fatal error: Argument 1 passed to Drupal\webprofiler\DataCollector\ServicesDataCollector::__construct() must be an instance of Symfony\Component\DependencyInjection\IntrospectableContainerInterface, instance of Drupal\Core\DependencyInjection\Container given, called in /Users/clemens/Sites/drupal/d8/www/core/lib/Drupal/Component/DependencyInjection/Container.php on line 262 and defined in /Users/clemens/Sites/drupal/d8/www/modules/devel/webprofiler/src/DataCollector/ServicesDataCollector.php on line 29 #0 /Users/clemens/Sites/drupal/d8/www/core/includes/bootstrap.inc(566): _drupal_error_handler_real(4096, 'Argument 1 pass...', '/Users/clemens/...', 29, Array)
#1 /Users/clemens/Sites/drupal/d8/www/modules/devel/webprofiler/src/DataCollector/ServicesDataCollector.php(29): _drupal_error_handler(4096, 'Argument 1 pass...', '/Users/clemens/...', 29, Array)

So IS is probably right for creating a new (feature) branch for fixing this. But IMHO it should result in just a new version of devel like 8.1.1 ... as support for Drupal 8.3.x stops after 8.4.0 is released. We did that for Rest UI too.

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
CreditAttribution: clemens.tolboom as a volunteer commented
Title: Support for symfony 3 in webprofiler » Support for Drupal 8.4.x using Symfony 3 in webprofiler
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Active » Needs review
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Needs work
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Related issues: +#2882954: Error when updating to 8.x-1.1

Am running into this problem with a Metatag test that specifically checks to see if Devel and WebProfiler can be enabled.

lussoluca’s picture

lussoluca
he/him
Primary language Italian
Location Italy
CreditAttribution: lussoluca commented
FileSize
support_for_symfony_3-2879214-8.patch3.8 KB

I did not do extensive tests but with this patch webprofiler installs and runs on d8.4.0-dev

lussoluca’s picture

lussoluca
he/him
Primary language Italian
Location Italy
CreditAttribution: lussoluca commented
Status: Needs work » Needs review
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Reviewed & tested by the community

The tests are green and this fixes the problem for Metatag, so it's RTBC as far as I'm concerned. Great work, lussoluca! :-)

lussoluca’s picture

lussoluca
he/him
Primary language Italian
Location Italy
CreditAttribution: lussoluca at H2H Creative Productions commented
FileSize
support_for_symfony_3-2879214-11.patch5.92 KB

Compatibility with both D8.4.x and D8.3.x

  • lussoluca committed 42c4103 on 8.x-1.x 
    Issue #2879214 by lussoluca, clemens.tolboom: Support for Drupal 8.4.x...
lussoluca’s picture

lussoluca
he/him
Primary language Italian
Location Italy
CreditAttribution: lussoluca at H2H Creative Productions commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x-1.x.
Thanks!

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

Woohoo! Thanks everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.