Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.There are 2 problems:
- It doesn't call node_save() after set the option value to 1/0.
- It calls function node_get_types() which should be node_type_get_types() in D7.
I've attached my patch.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | custom_pub_vbo-1967532-2.patch | 1.61 KB | seanr |
| custom_pub.module.patch | 1.68 KB | zhangx1a0 |
Comments
Comment #1
kevinquillen CreditAttribution: kevinquillen commentedComment #2
seanrAttached patch removes stray dpm from original. Also better patch filename.
Comment #3
seanrTested the patch on a "featured" option. Selected three nodes and attempted to toggle featured to on, edit node afterwards and featured remained unchecked. So this is still needs work.
Note sure this is critical, though, as it doesn't cause a fatal or prevent the rest of the module from working, so downgrading to major. Please don't mark issues critical unless they're really blowing up a site (WSOD, breaking content, etc.).
Comment #4
sokrplare CreditAttribution: sokrplare commentedTested and working well. Did the same thing @seanr said "Selected three nodes and attempted to toggle featured to on, edit node afterwards and featured remained unchecked." except it was checked for me.
Was getting a WSOD prior to this patch so a huge help - thanks, @zhangx1a0!
Comment #5
kevinquillen CreditAttribution: kevinquillen commentedLooks good, tested and working as far as I can see. Thanks all, pushed to dev and will be in upcoming release.