Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Thanks for the work on this module. As I was testing it I found a few nitpicks for the README file.
The README has a node alias and the instructions for configuration could use enhancement.
Patch to follow. Thanks!
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | conditional_message-fixed-readme-2895370-2.patch | 2.45 KB | volkswagenchick |
Comments
Comment #2
volkswagenchickAgain, thanks for this module. I have uploaded a patch that provides some useful configuration and aligns more to drupal.org standards.
https://www.drupal.org/docs/develop/documenting-your-project/module-docu....
Comment #3
volkswagenchickComment #4
genevieveparker CreditAttribution: genevieveparker at Hook 42 commentedlooks good
Comment #5
wranvaud CreditAttribution: wranvaud at Phase2 commentedThank you for the patch! There are changes on README from d7 that still need to be ported to d8 and now also the changes from this patch need to be ported to drupal7 still so I'm leaving this open.
patch commited to 8.x-1.x, will be on next version after 8.x-1.0-alpha1.
Comment #7
volkswagenchickwranvaud
Thankyou for all the work you do!!
And thankyou for your considerations in my helping with this project.
I am encouraging team mates to help out on Drupal.org, could you go back and give genevieveparker a credit for her RTBC?? The box next to her name just gets ticked and she gets a credit! I see it as a way of incentive to help get involved it the community! It takes a village.
Cheers!
AmyJune - volkswagenchick
Comment #8
wranvaud CreditAttribution: wranvaud at Phase2 commentedThank you for your contributions! I'll make sure you all get the proper credit. I think the credit only gets through once the issue is closed. I'm going to close this since you now opened a separate one for the d7 version. Let me know if there are still issues.