system_get_info() doesn't know 'core' type and throws notices when type is not module or theme.

CommentFileSizeAuthor
#2 2975942-2.patch1.3 KBjoelpittet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented
Status: Active » Needs review
FileSize
2975942-2.patch1.3 KB
webflo’s picture

webflo CreditAttribution: webflo at UEBERBIT GmbH commented 
--- a/composer_deploy.module
+++ b/composer_deploy.module

@@ -51,19 +51,22 @@ function composer_deploy_preprocess_update_project_status(&$variables) {
+  if (!in_array($project_type, ['module', 'theme'])) {
+    return;
+  }

Is the early return the best idea? The core release should get the diff diff links as well.

  • webflo committed 2950728 on 8.x-1.x authored by joelpittet 
    Issue #2975942 by joelpittet: system_get_info() doesn't know 'core' type...
webflo’s picture

webflo CreditAttribution: webflo at UEBERBIT GmbH commented
Status: Needs review » Fixed

Nevermind, this is good to go. Adding a diff link for core is not that easy.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.