Hello all, it’s time for the fortnightly coding standards meeting. The meeting will take place in slack in various threads
This meeting:
➤ Is for anyone interested in the Drupal coding standards.
➤ Usually happens fortnightly on Tuesday 2100 UTC. The meeting open for 24 hours to allow for all timezones.
➤ Is done on the #coding standards channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to. See the parent issue for an idea of the typical agenda.
➤A transcript will be made using drupal-meeting-parser and posted to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.
Standing items
- Who is here?
- What should we talk about today? Suggest topics here and I will add threads. I will also check for comments on the issue for today's meeting.
- Action Items
- Approve previous minutes
- Wrap up
0️⃣ Who is here today? Comment in the thread to introduce yourself. We’ll keep the meeting open for 24 hours to allow for all timezones.
| smustgrave | hello. First coding standard one may just be a fly on the wall this round |
| larowlan | hey |
| borisson_ | Hello |
0️⃣.5️⃣ What activity do you do to promote your health?
| quietone | Walking. We live next to a small park and some bush is just a bit further. Thinking of swimming once a week. |
| larowlan | lots of pushups |
1️⃣ Do you have suggested topics you are looking to discuss? Post in this thread and we’ll open threads for them as appropriate.
| smustgrave | Not sure if this counts as coding standard. But when doing schema updates is it standard to need an update hook to update on existing sites. If not right meeting please ignore.But also would like to know for new private paramters should we be adding typehints or does @var count |
2️⃣ Action items
2️⃣.1️⃣ Wins - what wins have you had since the last meeting? Share your successes!
2️⃣.2️⃣ Approve last fortnight's minutes
| quietone | This is at NR, #3320254: Coding Standards Meeting 2022-11-23 2100 UTC |
| quietone | And the transcripts for other meetings have yet to be made. |
| smustgrave | @quietone left a comment for that meeting on 11/23 |
| quietone | Who can help with making the transcripts? |
| smustgrave | If you need me to copy from slack I could probably help. What dates? |
2️⃣.3️⃣ What do you want to discuss? (edited)
3️⃣ Update on target issue
| quietone | Two of the 4 active issues are at RTBC! |
| quietone | Two are at Needs Reviews |
| quietone | This one is ready for review, #3268833: Fix method comments in tests for Drupal.Commenting.DocComment.ShortSingleLine |
| quietone | And I think this one needs a followup, but I want to dig a bit more into it. #3268835: Fix method comments in non tests for Drupal.Commenting.DocComment.ShortSingleLine |
4️⃣ Use PHP 8 constructor property promotion
| quietone | There is a class using property promotion in core. |
| quietone | I learned last night that that class is not displayed on Drupal API. #3278431: Use PHP 8 constructor property promotion for existing code#comment-14897827 |
| quietone | It looks like we will be using #2209735: [policy] Remove DI verbosity by removing unnecessary doc lines as the Coding Standards issue for removing the constructor param phpdoc part. |
| quietone | That issue will need an Issue Summary update. |
| quietone | And, can someone confirm that the class doesn't show up properly on Drupal API? |
| larowlan | which class sorry? |
| quietone | Sorry, I didn't say that it was linked in the comment on the 'Use PHP...' issue. It is CssCollectionOptimizerLazy.php |
| quietone | I went ahead and made an issue, #3338065: Class using property promotion not displayed |
| larowlan | yep looks borked to me too |
5️⃣Meetings time
| quietone | My schedule is about to change. I don't have all the details yet. |
| quietone | But it very likely the time will have to change. |
| quietone | I would also like us to consider alternating between two times to accommodate timezones. |
6️⃣ Accessibility Coding standards #3328548: Add Accessibility Coding Standards
| quietone | There is also #3279894: GAAD Pledge - Publish Accessibility Coding Standards |
| quietone | The actual standards have been discussed and approved by folks in #accessibility. |
| quietone | We need to make sure that the adoption of these standards is following existing policy. |
| quietone | Looking at the process, the issue in the coding standards queue needs 2 active community member to support the addition. I don't think I should be included in that number so can everyone here comment on that issue? |
| quietone | I haven't sorted out making announcements (step 5) so let's skip that for the moment. |
| quietone | After we have support from 2 people in the issue, then it will go to the core queue for approval. |
| quietone | Everyone, comment on the two issues linked in this thread so we can move this along. |
| Mike Gifford (CivicActions) | Thanks @quietone |
7️⃣ Flowchart of coding standards process.
| quietone | I started a flowchart of the process. There are still some gaps to fill. |
| quietone | It can be found in #3322805: Use plain language for the coding standards process |
| larowlan | Made a comment |
| borisson_ | I think all the question marks are "won't fix" |
8️⃣ Wrap Up
| quietone | The meeting is open for 24 hours, Please continue to chat in the threads. A transcript is posted, usually within 1 week. |
Comments
Comment #5
quietone commentedComment #6
rohan-sinha commentednice, innovative definitely join. thanks.
Comment #7
quietone commentedComment #8
smustgrave commentedWent into the #coding-standard channel on 1/31/2023 and all the minutes were captured and those that contributed to the topics have been credited.
Comment #10
quietone commentedThis should be in the Coding Standards project.