Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#20 | 3353004-cleanup_ui_for_1x-19.patch | 490.76 KB | carolpettirossi |
#15 | 3353004-cleanup_ui_for_1x_branch-14.patch | 489.38 KB | andre.bonon |
#13 | 3353004-cleanup_ui_for_1x_branch-13.patch | 489.64 KB | carolpettirossi |
#12 | Screenshot from 2023-07-07 11-19-16.png | 37.91 KB | pfeiffer |
#12 | Screenshot from 2023-07-07 11-18-12.png | 22.83 KB | pfeiffer |
Issue fork bootstrap_styles-3353004
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
AaronChristian CreditAttribution: AaronChristian at ImageX commentedComment #4
chikeThe MR patch wouldn't apply with Composer and the module wouldn't download from the branch using Composer.
Comment #5
AaronChristian CreditAttribution: AaronChristian at ImageX commentedIn Drupal 9/10, our beautiful UI is not so beautiful anymore. 😔
Comment #6
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedTry to do the following
which I learned to make use of that from Gin Layout Builder
doing that in https://git.drupalcode.org/project/varbase_layout_builder/-/blob/10.1.x/...
which works
Comment #7
AaronChristian CreditAttribution: AaronChristian at ImageX commentedComment #8
AaronChristian CreditAttribution: AaronChristian at ImageX commented@chike from what I can see if you're using D10 you will need a few extra patches;
Hope that helps!
If you're using D9, please give some more specifics on your setup and I'll see if I can assist you further. Please ping me in Slack if you would like quicker support!
Comment #9
chike@AaronChristian Thanks I will be checking this out tomorrow.
In D9, I have 'media_library_theme_reset', 'layout_builder_modal' and the regulars. I am using the 'boostrap' Bootstrap 3 theme. The Bootstrap Styles are not looking good at all.
Comment #10
AaronChristian CreditAttribution: AaronChristian at ImageX commentedAh okay thanks @chike, we no longer support bootstrap 3, are you able to upgrade to bootstrap 4 or 5?
Comment #11
chikeThe collection of patches cleaned up the UI nicely.
This patch is not online,
That's for the D10 site. As for the D9 site using 'bootstrap' theme I think I may have to change the theme to one of the Bootstrap 5 themes as I am not sure 'bootstrap' will be adopting newer Bootstrap versions anytime soon.
Comment #12
pfeiffer CreditAttribution: pfeiffer at ImageX commentedAfter applying this patch in a Drupal 9.4 all options of any block or section have a white background color.
Comment #13
carolpettirossi CreditAttribution: carolpettirossi at ImageX commentedAttached the patch from MR to use in composer
Comment #15
andre.bonon CreditAttribution: andre.bonon at ImageX commented@aaron, we have more issues with the z-index and modals when LB is enabled for other entity types such as Blocks.
I updated the ui-dialog's z-index so as to be the same as Claro's (1260) and pushed it to the MR.
Also, I'm attaching the patch from MR to use in composer.
Comment #16
flyke CreditAttribution: flyke commentedCan this be updated or a new issue fork be created that applies to bootstrap_styles 1.1.5 ?
Comment #17
sim_1Marking RTBC. Things are pretty broken without this. I'm sure more improvements are needed, but better to have something than keep living with things being broken.
Comment #18
AaronChristian CreditAttribution: AaronChristian at ImageX commented@flyke this has been updated with the latest tagged release 1.1.5 now.
Comment #19
carolpettirossi CreditAttribution: carolpettirossi at ImageX commentedUploading a patch from MR#57.
I tested it on my projects, and it worked as expected.
Comment #20
carolpettirossi CreditAttribution: carolpettirossi at ImageX commentedForgot to click "Upload". Sorry about that