• Remove deprecated block-admin-display-form.tpl.php
  • Remove deprecated hook_process_block()
  • Clean up block.html.twig
CommentFileSizeAuthor
#3 bootstrao-update-book-themes-processing-2260999-3.patch4.9 KBm1r1k
#3 interdiff.txt481 bytesm1r1k
#1 bootstrap-update-block-processing-2260775-1.patch4.82 KBm1r1k

Comments

m1r1k’s picture

m1r1k commented
Status: Active » Needs review
StatusFileSize
new bootstrap-update-block-processing-2260775-1.patch4.82 KB
markhalliwell’s picture

markhalliwell
Primary language English
commented
Assigned: m1r1k » Unassigned
Status: Needs review » Needs work

Tiny nit pick:

+++ b/theme/block/block.html.twig
@@ -36,17 +40,19 @@
  * @see template_preprocess_block()
+ * @see bootstrap_preprocess_block()

bootstrap_preprocess_block() should be above core's implementation. This is top to bottom inheritance.

m1r1k’s picture

m1r1k commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt481 bytes
new bootstrao-update-book-themes-processing-2260999-3.patch4.9 KB

  • Commit 2219db2 on 8.x-3.x authored by m1r1k, committed by Mark Carver: 
    Issue #2260775 by m1r1k: Update block processing.
markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Needs review » Fixed

Status: Fixed » Needs work

The last submitted patch, 3: bootstrao-update-book-themes-processing-2260999-3.patch, failed testing.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Needs work » Fixed

Sigh...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.