We need to have test coverage for AMP Ads

I will first do a bit of tidying up #3019970: Tidy up tests

CommentFileSizeAuthor
#5 3016667_amp_ads_tests.patch11.13 KBmarcelovani
#3 3016667_amp_ads_tests.patch9.73 KBmarcelovani
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

marcelovani created an issue. See original summary.

marcelovani’s picture

marcelovani
Primary language Portuguese, Brazil
Location London
CreditAttribution: marcelovani at Dennis commented
Issue summary: View changes
marcelovani’s picture

marcelovani
Primary language Portuguese, Brazil
Location London
CreditAttribution: marcelovani at Dennis commented
Status: Active » Needs review
FileSize
3016667_amp_ads_tests.patch9.73 KB

Tests for Adsense and DFP.
I had also done some tidying up and moved some of the Adsense code into its own sub-module.

Status: Needs review » Needs work

The last submitted patch, 3: 3016667_amp_ads_tests.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

marcelovani’s picture

marcelovani
Primary language Portuguese, Brazil
Location London
CreditAttribution: marcelovani at Dennis commented
Status: Needs work » Needs review
FileSize
3016667_amp_ads_tests.patch11.13 KB

I was trying to make the amptheme work but its a bit complicated. Will come back to this later.

theme_enable(array('amptheme', 'ampsubtheme_example'));

  • marcelovani committed a5503e1 on 7.x-1.x 
    Issue #3016667 by marcelovani: Add tests for AMP Ads
marcelovani’s picture

marcelovani
Primary language Portuguese, Brazil
Location London
CreditAttribution: marcelovani at Dennis commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.