Attaching random data on a named object as a public dynamic property is a bad practice.

Split source_string and items properties to variables and pass them as extra arguments wherever needed.

Will also make the patch over #1977266: Fix ContentEntityBase::__get() to not return by reference easier

CommentFileSizeAuthor
#13 drupal-aggregator-2198821-11.patch14.2 KBkaushashah
#11 drupal-aggregator-2198821-11.patch14.41 KBkaushashah
#7 drupal-aggregator-2198821-7.patch13.22 KBrisse
#6 drupal-aggregator-2198821-6.patch12.21 KBrisse
#4 drupal-aggregator-2198821-4.patch13.12 KBParisLiakos
#3 drupal-aggregator-2198821.patch14.16 KBParisLiakos

Comments

ParisLiakos’s picture

ParisLiakos commented
Issue summary: View changes
Issue tags: +API clean-up
ParisLiakos’s picture

ParisLiakos commented
Issue summary: View changes
ParisLiakos’s picture

ParisLiakos commented
Status: Active » Needs review
StatusFileSize
new drupal-aggregator-2198821.patch14.16 KB
ParisLiakos’s picture

ParisLiakos commented
StatusFileSize
new drupal-aggregator-2198821-4.patch13.12 KB

reroll

Jalandhar’s picture

Jalandhar commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

Patch #4, needs to be updated.

risse’s picture

risse commented
Status: Needs work » Needs review
Issue tags: -Needs reroll +Amsterdam2014
StatusFileSize
new drupal-aggregator-2198821-6.patch12.21 KB

Reroll.

risse’s picture

risse commented
StatusFileSize
new drupal-aggregator-2198821-7.patch13.22 KB

Looks like I forgot a couple of lines. Here's a new patch.

The last submitted patch, 6: drupal-aggregator-2198821-6.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

Patch no longer applies.

kaushashah’s picture

kaushashah commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new drupal-aggregator-2198821-11.patch14.41 KB

Patch rerolled.

Patches were not getting applied to some of the files and also resolved conflicts.

Status: Needs review » Needs work

The last submitted patch, 11: drupal-aggregator-2198821-11.patch, failed testing.

kaushashah’s picture

kaushashah commented
Status: Needs work » Needs review
StatusFileSize
new drupal-aggregator-2198821-11.patch14.2 KB

Rectified DefaultFetcher.php file.

Status: Needs review » Needs work

The last submitted patch, 13: drupal-aggregator-2198821-11.patch, failed testing.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev
quietone’s picture

quietone commented
Project: Drupal core » Aggregator
Version: 9.3.x-dev » 1.x-dev
Component: aggregator.module » Code

The aggregator module has been removed from Core in 10.0.x-dev and now lives on as a contrib module. Issues in the Core queue about the aggregator module, like this one, have been moved to the contrib module queue.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Issue tags: +Aggregator 2.x, +PHP 8.2

This will cause a deprecation in 8.2

https://php.watch/versions/8.2/dynamic-properties-deprecated

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs work » Closed (duplicate)
Issue tags: -Aggregator 2.x, -PHP 8.2

Duplicate of #3239690: Add undeclared variables to the Feed entity class