"Move all external scripts to the top of the execution order" breaks bootstrap.js if jquery is not loaded from a CDN but bootstap is loaded from a CDN [#2325743]

Comment	File	Size	Author
#10	advagg-2325743-9-run-advagg-js-css-alters-after-themes.patch	7.72 KB	mikeytown2

#7	advagg-2325743-7-run-advagg-js-css-alters-after-themes.patch	5.84 KB	mikeytown2

#1	advagg-2325743-1-fix-bootstrap-jquery.patch	1.08 KB	mikeytown2

File	Size
advagg-2325743-1-fix-bootstrap-jquery.patch	1.08 KB

Comment #3

4 September 2014 at 23:50

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Log in or register to post comments

Comment #4

pdesai CreditAttribution: pdesai commented 1 December 2014 at 14:35

I am getting Uncaught Error: Bootstrap requires jQuery. I applied the patch from #1 and it is still throwing the same error. Any ideas?

Log in or register to post comments

Comment #5

mikeytown2 CreditAttribution: mikeytown2 commented 1 December 2014 at 21:17

Have you tried this with the latest dev of advagg?

Log in or register to post comments

Comment #6

pdesai CreditAttribution: pdesai commented 1 December 2014 at 22:02

No, I was using the 2.7 release. I have replaced it with the latest dev release and still receiving the same error.

Log in or register to post comments

Comment #7

mikeytown2 CreditAttribution: mikeytown2 commented 2 December 2014 at 01:34

Status:

Closed (fixed)

» Needs review

File	Size
advagg-2325743-7-run-advagg-js-css-alters-after-themes.patch	5.84 KB

You might have a bug with the way you're adding bootstrap.js inside your theme. In any case try this patch.

Log in or register to post comments

Comment #8

pdesai CreditAttribution: pdesai commented 2 December 2014 at 20:18

@mikeytown2: I am using the Bootstrap theme with a simple sub-theme. The rendering of bootstrap.js is done by the base Bootstrap theme. The setting I have in my sub-theme is to use Bootstrap CDN version 3.0.2 as noted for Method 2.

I was not able to apply patch #7 since it doesn't match with dev version?

Log in or register to post comments

Comment #9

2 December 2014 at 23:33

mikeytown2 committed 55434a5 on 7.x-2.x

Issue #2325743 by mikeytown2: Make sure advagg js/css alter hooks run...

Log in or register to post comments

Comment #10

mikeytown2 CreditAttribution: mikeytown2 commented 2 December 2014 at 23:34

Status:

Needs review

» Fixed

File	Size
advagg-2325743-9-run-advagg-js-css-alters-after-themes.patch	7.72 KB

Try the latest dev; it should incorporate this patch. You'll have to clear the drupal caches as this change modifies what hooks get ran with js/css_alter.

FYI: This patch and the last patch are against the latest dev. Not sure why you couldn't apply it. Providing the error message when saying it doesn't apply is usually helpful :)

Log in or register to post comments

Comment #11

pdesai CreditAttribution: pdesai commented 3 December 2014 at 13:35

I have installed the latest dev form yesterday. I do flush all caches from the admin menu after any changes related to advagg. With the latest dev, I can confirm it is working 100% with Bootstrap being loaded from CDN!

Thanks!

PS: Appreciate the quick responses!

Log in or register to post comments

Comment #12

17 December 2014 at 13:44

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Log in or register to post comments

Comment #13

phponwebsites CreditAttribution: phponwebsites commented 6 February 2015 at 08:42

when I tried to apply all above 3 patchs 10,7,1, i'm getting error
Fatal error: Cannot redeclare advagg_get_css() (previously declared in all/modules/contrib/advagg/advagg.module:1266) in all/modules/contrib/advagg/advagg.module on line 1409