In addition to the retargeting work aimed at webform in #2883476: Target 8.x Webform Instead Since Project Merge, any D7 migration updates added through #2877026: Webform-D7 support and renamed YAMLForm/Webform module will also need the same adjustments.

CommentFileSizeAuthor
#4 interdiff-n2883532-2-4.txt1.62 KBmichael_wojcik
#4 yamlform_migrate-n2883532-4.patch12.24 KBmichael_wojcik
#3 interdiff-n2883532-2-3.txt658 bytesmichael_wojcik
#3 yamlform_migrate-n2883532-3.patch11.55 KBmichael_wojcik
#2 yamlform_migrate-n2883532-2.patch11.2 KBslucero
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

slucero created an issue. See original summary.

slucero’s picture

slucero
he/him
Primary language English
CreditAttribution: slucero at Mediacurrent commented
FileSize
yamlform_migrate-n2883532-2.patch11.2 KB

Attached is a patch to apply the same modifications retargeting modifications from #2883476-2: Target 8.x Webform Instead Since Project Merge to the D7 support added in #2877026-6: Webform-D7 support and renamed YAMLForm/Webform module.

To properly apply full D7 support targeting Webform, apply the following patches in the order described below:

  1. #2877026-6: Webform-D7 support and renamed YAMLForm/Webform module
  2. #2883476-2: Target 8.x Webform Instead Since Project Merge
  3. #2883532-2: D7 Support: Target 8.x Webform (This patch)
michael_wojcik’s picture

michael_wojcik CreditAttribution: michael_wojcik as a volunteer and at Mediacurrent commented
FileSize
yamlform_migrate-n2883532-3.patch11.55 KB
interdiff-n2883532-2-3.txt658 bytes

Minor update to previous patch to correct for the import of a webform entity's status into the corresponding webform node.

To properly apply full D7 support targeting Webform, the order of patches described above in https://www.drupal.org/node/2883532#comment-12115788 is still valid, except that the third patch applied should now be from https://www.drupal.org/node/2883532#comment-12145692 (This comment/patch) instead of https://www.drupal.org/node/2883532#comment-12115788.

michael_wojcik’s picture

michael_wojcik CreditAttribution: michael_wojcik as a volunteer and at Mediacurrent commented
FileSize
yamlform_migrate-n2883532-4.patch12.24 KB
interdiff-n2883532-2-4.txt1.62 KB

Re-roll of patch from #3: https://www.drupal.org/node/2883532#comment-12145692. Previous patch did not properly set webform field settings on the webform node. Interdiff shows change from #2 to #4.

To properly apply full D7 support targeting Webform, the order of patches described above in https://www.drupal.org/node/2883532#comment-12115788 is still valid, except that the third patch applied should now be from https://www.drupal.org/node/2883532#comment-12146004 (This comment/patch) instead of https://www.drupal.org/node/2883532#comment-12115788.

  1. #2877026-6: Webform-D7 support
  2. #2883476-2: Target 8.x Webform Instead Since Project Merge
  3. #2883532-2: D7 Support: Target 8.x Webform (This patch)
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

Marking this as a duplicate of #2877026: Webform-D7 support and renamed YAMLForm/Webform module.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Active » Closed (duplicate)