Please state the version you are installing

I am not sure where installed version should be displayed, but right before installation task list seemed a good initial place. It looks like this:

Patch no longer applies, needs rerolling.

Rerolled the patch.

I like this idea, but it needs some formatting help.

Added version when installing Drupal and theming.

Patch from #7 did not apply to CSS (wrong selector)
Here's modified patch

My bad, outdated HEAD here.
Patch from #7 is just fine (including visual part)

Does this not cause problems for distributions?

#11: Since distributions can use their own themes during install, I don't see a problem

Right, but can't we do this right from the start and instead of hardcoding Drupal, we get the install profile name and its version instead, if that's different from either standard or minimal. We shouldn't force distributions to ship with a custom theme because something as simple as this if we can help it.

Yeah, we do not want to actually put the string "Drupal" anywhere, especially un-translated.

Let's see what this does. Does this need to be translated?

Re-testing, because it works fine through Simplytest. Maybe it's a testbot hiccup.

I cannot reproduce the failures locally when running tests through run-tests.sh.

Replaced 'Drupal' with drupal_install_profile_distribution_name(). With the last patch, installation looks as following:

@webchick, task list is preceded by (untranslated) 'Installation tasks', so I left 'Installing ' untranslated

This doesn't work with install profiles either, because it uses the Drupal version and not that of the install profile.

#23: Agree. Here's a version that displays profile's versions, falls back to Drupal::VERSION

Also, I've changed display to reduce occupied screen space:

On small screens version is not displayed.

I am not sure what would be better: add another function drupal_install_profile_distribution_version() as in attached patch, (and this function is almost identical to drupal_install_profile_distribution_name()), or add function that will return all profile info, falling back to some reasonable defaults.

#25 should be ignored, 'cause the last patch is #24, not #21

reroll.
css got messed up, so i deleted that part.

The CSS was important though. @valthebald's had the priority right I think. This just doesn't look right:

Added back CSS (for the sake of responsiveness version string is hidden for the screens narrower than 48em)

+ * Loads the installation profile, extracting its defined version.
+ * @return string The distribution version defined in the profile's .info.yml file. Defaults to
+ * The distribution version defined in the profile's .info.yml file. Defaults to
+ * \Drupal::VERSION if none is explicitly provided by the installation profile.
+ * @see install_profile_info()
+ */

This needs at least a newline before and after the @return

1. Added new lines before and after @return block
2. Shortened @return docblock to fit 80 chars line
3. Removed duplicate 'defaults to...' part

This looks better for sure.

I tried it in a mobile and noticed that the version wasn't included there. Just wanted to confirm that this was intentional.

With clarification on that we should be good to go I think.

I think this all looks good.

Here is the new reviewed patch (there was error related to checkPlain function in core/includes/theme.inc ) please review if this looks fine.

Screenshot attached how it looks like after applying patch #33.

@sushantpaste: can you also add an interdiff from the previous patch?

@mgifford: hiding the version on narrow screen is intentional (not enough space)

@valthebald Here is the updated patch.

--- a/core/includes/install.inc
+++ b/core/includes/install.inc
+ * @return string  Distribution version defined in the profile's .info.yml file.
+ * Defaults to  \Drupal::VERSION if no version is explicitly provided

unnecessary extra spaces on lines 118 and 119

+++ b/core/includes/theme.inc
@@ -1436,7 +1436,9 @@ function template_preprocess_install_page(&$variables) {
+  $distribution_version = SafeMarkup::checkPlain(drupal_install_profile_distribution_version());
   $variables['site_name'] = $distribution_name;
+  $variables['site_version'] = $distribution_version;
 }

use of SafeMarkup:checkPlain() is deprecated (in favor of twig autoescape)

@valthebald : Thanks I think now its all good to go, changing status to RTBC

Do we really want to put the semver version in front of everyones faces? I can see how it is useful to say "Drupal 8" and maybe even "Drupal 8.3"... calling in a product manager for review.

@alexpott: I think the whole idea was to display exact version that is being installed. Install screens between last 3 major versions (6-7-8.0) can be visually distinguished without adding version number at all.

I would agree. I think the primary reason for this is to get support, etc. so the more detailed the answer to "what version are you using?" is, the better.

I'm not sure about the design though, so assigning to Lewis, as the Seven maintainer.

Thanks. I tweaked the design by increasing the font size to Seven's minimum (13px), and changed the color to be a little more subtle, so the heirachy of the title is stronger.

I also removed the display: none for mobile devices because there is no supporting evidence for the assumption that mobile users do not need this information. There were also some syntax errors in the CSS. Can we make sure issues that include CSS are tagged so they can be reviewed? Thanks!

One more question, do we also want to include this value on the update.php page?

Patch at #43 couldn't be applied (it's too big, some files included by mistake maybe?), I applied changes from interdiff to patch #38

Looks good. I think if we want this on the Update page we should create a new issue and deal with it there.

I'm glad that the version is now being displayed if installed from a mobile device. Thanks for catching that @LewisNyman.

Fell due to today's problems with the testbot, retesting

I dare put it back to RTBC, because the issue changed its status only due to testbot failure

Lookin' good!

Committed and pushed to 8.0.x. Thanks!