Closed (fixed)
Project:
Link checker
Version:
2.0.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
8 Mar 2024 at 13:12 UTC
Updated:
21 May 2025 at 23:41 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
gugalamaciek commentedProposed patch adds feature described in point 1. and implements performance improvements described in 2. - 4.
Comment #3
gugalamaciek commentedComment #4
gugalamaciek commentedComment #5
joseph.olstadpatch 27 didn't work out, working on a new one.
Comment #6
joseph.olstadSorry wrong issue
Comment #7
joseph.olstadHi Gugalamaciek, I'm submitting a patch to re-use our setting that we had for another patch , but using your logic as ours was not working correctly but the setting I don't want to lose it and have to do more work with configs that are already ignored.
Comment #8
joseph.olstadnot sure if patch #7 is good, if you're testing, try patch 2 instead. I'm testing #7
Comment #9
joseph.olstadPatch 7 works well, basically the same as patch 2 except I renamed the config setting key to work with our settings (yes selfish me).
Comment #10
gugalamaciek commented@Joseph Fine for me :) That's why it's on review ;) I checked briefly, and I think you should change
linkchecker.schema.ymlas well.As I see you've changed setting:
check.skip_unpublishedto:
search_published_contents_onlyBut when I check
linkchecker.schema.yml, I have a feeling, that this property should be undercheck. So it should be rathercheck.search_published_contents_only. Also, if you want this change, I suggest to rename everywhere (e.g. form property as well). It will be less confusion for developers reading this code ;)Comment #11
joseph.olstadnew patch
Comment #13
joseph.olstadThanks again gugalamaciek, we really appreciate your great work on this solution! It has been deployed into our production environment.
Comment #14
gugalamaciek commentedjoseph.olstad I'm glad I could help :)
FYI #11 looks good, I've added it to our site :)
Comment #15
gugalamaciek commentedComment #16
mahesh bandhiya commented#11 tested and works fine, thanks joseph.olstad and gugalamaciek
Comment #17
mahesh bandhiya commentedRefined patch #11
Changes :
changed
search_published_contents_onlytosearch_published_content_onlychanged
Search published contents onlytoSearch published content onlyComment #18
joelpittetIt would be nice to have these 2 features separate but the second part is exactly what I need as the unpublished nodes are outdated content in a lot of cases.
Anyways RTBC #17 with the text changes.
Comment #19
joseph.olstad***EDIT***
Double checking
***END EDIT***
Comment #20
rp7 commentedAs I already mentioned by others, perhaps we should idd look into separating the 2 features.
Skipping unpublished content could use/benefit from the solution being worked on in #3454641: Allow entities to be skipped programmatically.
Comment #23
vladimirausThank you! Committed! 🍨
Comment #25
joseph.olstadLooking to improve this:
#3525930: Improve performance of LinkExtractorBatch & allow to skip unpublished moderated content