Problem/Motivation

Spun from #3426637: Improve performance of LinkExtractorBatch & allow to skip unpublished content

Steps to reproduce

Use content moderation

Proposed resolution

See merge request/patch

Remaining tasks

User interface changes

TBD

API changes

TBD

Data model changes

TBD

CommentFileSizeAuthor
#4 3525930-01.patch3.59 KBjoseph.olstad

Issue fork linkchecker-3525930

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joseph.olstad created an issue. See original summary.

joseph.olstad opened merge request !115

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Parent issue: » #3426637: Improve performance of LinkExtractorBatch & allow to skip unpublished content
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
StatusFileSize
new 3525930-01.patch3.59 KB
joseph.olstad’s picture

joseph.olstad
Primary language French
commented

still reviewing this, it might not actually be working at all and possibly introduces a regression.

jmester13’s picture

jmester13 commented

This patch seems to help this issue, https://www.drupal.org/project/linkchecker/issues/3465761 I am no longer seeing unpublished content in the results.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Thanks for the review, I had forgotten about this patch. Probably still need it.

jmester13’s picture

jmester13 commented

Happy to help. I will also note that the module was still picking up 404's in "Orphaned Text" I found this to be in the paragraph revisions which I was able to clear out with drush:errp. It is recommend to take a database backup before doing this.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

@jmester13 , interesting that you mention this. For others reading this: drush errp is provided by the paragraphs module . Just to avoid confusion for others, it's not a linkchecker issue.

saidatom’s picture

saidatom
Location Lisbon
commented
Status: Active » Reviewed & tested by the community

Looks good move to RTBC.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Assigned: joseph.olstad » Unassigned