Plan for which issues need to be committed for full/stable 6.2.0 release.
| Comment | File | Size | Author |
|---|---|---|---|
| #52 | signature-element-1.png | 75.03 KB | sundaravigneshP |
| #25 | Screenshot 2023-09-29 at 5.47.39 PM.png | 33.99 KB | chris matthews |
Plan for which issues need to be committed for full/stable 6.2.0 release.
| Comment | File | Size | Author |
|---|---|---|---|
| #52 | signature-element-1.png | 75.03 KB | sundaravigneshP |
| #25 | Screenshot 2023-09-29 at 5.47.39 PM.png | 33.99 KB | chris matthews |
Comments
Comment #2
damienmckennaBumping the priority as the module currently doesn't have a stable release compatible with D10.
Comment #3
redseujacAgreed. Isn't it time to have a new stable release for D10?
D10 is out since quite some time and so is 6.2.0-beta5 (released 12 jan 2023).
So, please...
Comment #4
damienmckenna@redseujac: Please help test out the child issues, let's see if we can get them to RTBC in the next few days!
Comment #5
liam morland6.2.x-dev tests are failing on PHP 8.0. Is 6.2.x intended to be compatible only with PHP 8.1 and greater? If we define it that way, it will match Drupal 10 and is a solid foundation for the future. 6.1.x-dev tests pass on PHP 8.1, so people can upgrade to PHP 8.1 while on 6.1.x then move to 6.2.x.
Comment #6
damienmckennaBootstrap was updated to require PHP 8.1 when they added D10 support; should we ask them to remove this requirement until they drop D9 support?
Comment #7
damienmckennaI opened an issue for Bootstrap asking them to remove or change the PHP requirement: https://www.drupal.org/project/bootstrap/issues/3362715
Comment #8
liam morlandThat would be good even if only for 6.1.x. We could still decide that 6.2.x should require PHP 8.1.
Comment #9
jrockowitz commentedI think for 6.2.x we should require PHP 8.1+.
Comment #10
redseujacjrockowitz commented in #9:
So do I.
Comment #11
liam morlandWe should also consider when support will end for Webform 6.0.x. A sizeable majority of people have moved to 6.1.x, so I think it would be reasonable to do this.
Comment #12
jrockowitz commentedI am hoping that Webform 6.0.x support can end when 6.2.x is released. It is reasonable only to support the two latest major releases.
Comment #13
redseujacThat makes sense.
I am using Drupal 10.0.9, PHP 8.2.6, Webform 6.2.x-dev (most recent build).
Comment #14
liam morlandI agree.
I have updated the project page.
Another suggestion: For 6.2.x, make the minimum Drupal version be 9.5. People can stay on 6.1.x until they are on Drupal 9.5. Update: When I wrote that, it was because I read on the project page that the minimum was Drupal 9.2. It is actually 9.4 and I have fixed the project page.
Comment #15
jan.mashat commentedHi, may I ask when are you planning to release 6.2.0?
Is there anything that can be done to help with the effort?
Do these 3 major bug fixes need to get merged first?
Comment #16
jrockowitz commentedI appreciate any help and understand the need for a stable release of the Webform. At the same time, the beta version is very stable. The Webform module has a good track record between beta-to-beta releases.
I have less time and interest in maintaining and improving the Webform module. It does what it does, and it does it fairly well.
This does not mean I'm leaving the Drupal community or not maintaining this module. It does mean I want the 6.2.x release to be as stable as possible. For example, fixing #3358973: Plan for Webform 6.2.0 Release will require some work over the summer.
I'd like to address most open issues before the first RC release. I need help reviewing any 'Needs Review' ticket, especially if I've posted the patch. Comments and thoughts are always appreciated.
I am open to #3201435: Co-maintenance plan for the Webform project, but it requires someone who either knows the Webform module inside-n-out or is willing to improve and write tests for every patch.
BTW, there should be enough funds to get us a stable release in the Webform module's Open Collective. I do use these funds to support my ongoing work on the module. It does help when an organization or individual sponsors the Webform module's Open Collective.
Comment #17
jan.mashat commentedBeta versions unfortunately don't receive coverage from the security team, so a stable release would help there.
Is it safe to assume that Webform will not have a stable D10 release by the time D9 reaches EOL (in 3 months)?
Comment #18
drupgirl commented+1 on jrockowitz commented in #9:
I think for 6.2.x we should require PHP 8.1+.
Comment #19
chris matthews commented@jrockowitz, would it be possible to tag 6.2.0 for security coverage and then continue with 6.2.1 for the remaining issues that need to be fixed?
Comment #20
redseujac+1 for Chris Matthews as commented in #19
Comment #21
Sana.Neyazi commentedHi @jrockowitz
Could we know by when we can expect Drupal 10 stable release of webform?
Comment #22
kaustavbagchi commentedHi, When are we expecting a stable release compatible to Drupal 10? Any major road blockers or issues which needs to be fixed? Thanks
Comment #23
damienmckenna@kaustavbagchi: Please see the list of child issues in the right sidebar - some need review, some need work, any help would be appreciated.
Comment #24
l.b. commentedWill we have a stable release for this by Drupal 9 EOL?
Comment #25
chris matthews commentedVia Slack ...
Comment #26
liam morlandFor those unable to read the image, it says:
Comment #27
liam morlandGiven the tight timelines and lack of extra time, I suggest the following:
Comment #28
chris matthews commentedAll great proposals IMO. I also think discussion is needed re: the long-term maintenance of Webform. Maybe the module's maintenance status should be changed to Seeking co-maintainer(s) (Maintainers are looking for help reviewing issues.) @jrockowitz, along with many others, have done an absolutely incredible job over the years building and maintaining webform, but maybe it needs some additional backing from leading Drupal shops who could provide maintenance support (reviewing patches, committing, etc.)
Comment #29
jrockowitz commentedHere is the reality when it comes to co-maintainers: before anyone can become a co-maintainer, they need to review patches and contribute code with test coverage demonstrating the ability and commitment to co-maintaining the Webform module.
Some agencies would say they want to be co-maintainers when only seeking commit credits and would immediately tag a broken stable release of 6.2.x.
I apologize if my above statements are too direct and maybe bitter.
I do agree with everything noted in #27
Comment #30
cilefen commentedI agree with @jrockowitz. Merely triaging some issues (as I do) or rolling releases (as I am capable of doing) isn’t enough. A co-maintainer of this module at this point in time must also have a good handle on the internals.
Comment #31
cilefen commentedAnd the truth is there is no such a person right now and I say that as someone who follows every issue closely.
Comment #32
chris matthews commentedShould the module's maintenance status be changed to Seeking co-maintainer(s)? Or, is that not very helpful given the comments above?
Comment #33
liam morlandI have updated the project page based on #27 and approval by @jrockowitz in #29.
Comment #34
chris matthews commentedComment #35
liam morlandAlso for branch management, the 6.x branch should be left pointing at 6.1.x and not moved to 6.2.x.
Comment #36
liam morland@jrockowitz and I have been working towards a full release of Webform 6.2.0. A new beta has been released. Most child tickets of this issue are closed.
Please test the new beta and let us know if you are aware of anything that needs to be fixed before a full release, in particular, any functionality that would be lost by moving from the latest 6.1 to 6.2.x.
Comment #37
damienmckennaThank you both!
Comment #38
liam morlandWebform 6.2.0-rc1 has been released. The focus is on fixing any release-blocker bugs that emerge.
Comment #39
chris matthews commentedIs there an existing issue re: removing all of the deprecated webform submodules?
Comment #40
liam morlandNot that I am aware of. It feels very late in the release process to be removing sub-modules.
Comment #41
cilefen commentedI don't think we could remove them except in a major release. Any deprecated things should be removed in version 7.
Comment #42
jrockowitz commentedI agree with #41.
Comment #43
mxr576Just opened #3393638: Config schemas should not be removed in non-major versions
Comment #45
liam morlandI have released Webform 6.2.0-rc2.
Comment #46
liam morlandI have released Webform 6.2.0-rc3. Unless there are problems, I would like to tag this as full release on October 30, one week from today.
Comment #47
jrockowitz commentedI am okay with tagging the stable release on October 30th.
@Liam Morland Thank you for helping move this forward
Comment #48
kmontyI won't go as far as modifying the child issues, but calling out we found a breaking regression that was implemented in beta7. #3396868: Regression > Patch for "webform entity reference formatters not supporting translations" in 6.2.0-beta7 breaks Webform embeds within untranslated entities
Comment #49
liam morland@kmonty We'll probably need to rollback that patch as you suggest so that the upgrade does not cause a regression.
Comment #50
liam morlandI have reverted #3204176: webform entity reference formatters do not support translations and released Webform 6.2.0-rc4 with that change.
Comment #51
drupals.user commentedWill you please provide an update if there are any issues with 6.2.0-rc4 and a stable branch being released?
We have been holding off on upgrading our productions sites to Drupal 10 until this module releases a stable branch, and tomorrow is the last day prior to end-of-life for Drupal 9 on November 1, 2023.
Comment #52
sundaravigneshP commentedI have working in my local drupal setup its working fine,after adding a signature element to a form, and testing,the signature image is displayed in Results & also to update the signature element.
Other info(My local setup version details):
Comment #53
liam morlandWebform 6.2.0 has been released! Thank you, all.
Comment #54
damienmckennasundaravigneshP: Please open a new issue if you need help with something.
Huge thanks to jrockowitz for the leadership and Liam Morland for pushing the release past the finish line!
Comment #55
nicrodgersWoohooo - thank you so much!
Comment #56
drupals.user commentedCongratulations on getting this over the finish line!!!! Very much appreciated!!!!
Comment #58
ilfelice commentedHowdy,
Just wanted to let you all know that I upgraded 3 sites from Drupal 9.5 to 10, and Webform 6.2 is working like a charm in all of them.
Great work! Many thanks!