PHP 8.2 deprecation issue with AutosaveFormBuilder [#3355495]

Problem/Motivation

Deprecated function: Creation of dynamic property Drupal\autosave_form\Form\AutosaveFormBuilder::$_serviceId is deprecated in Drupal\Component\DependencyInjection\Container->createService() (line 285 of core/lib/Drupal/Component/DependencyInjection/Container.php).

Drupal\Component\DependencyInjection\Container->createService(Array, 'form_builder') (Line: 177)
Drupal\Component\DependencyInjection\Container->get('form_builder') (Line: 640)

Steps to reproduce

Install it and view a page with the autosave form on PHP 8.2

Proposed resolution

Add

  /**
   * The service ID
   * 
   * @var string
   */
  public $_serviceId = 'autosave_form.form_builder';

to AutosaveFormBuilder.php

Remaining tasks

User interface changes

API changes

Data model changes

Comment	File	Size	Author
#19	fix-php82-deprecation-3355495-19.patch	1.95 KB	finn lewis
	autosave_form-dynamic-property-deprecation.patch	452 bytes	stevenlafl

Issue fork autosave_form-3355495

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3355495-remove-serviceId-workaround changes, plain diff MR !12
Check out this branch for the first time

Check out existing branch, if you already have it locally

1 hidden branch

3355495-php-8.2-deprecation

changes, plain diff MR !9

Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

20 April 2023 at 21:21

stevenlafl created an issue. See original summary.

Comment #2

keshavv commented 21 April 2023 at 05:26

Status:

Needs review

» Reviewed & tested by the community

Reviewed the patch and tested it. Its working prefect. moving to RTCB.

Comment #3

12 May 2023 at 07:18

vipin.mittal18 made their first commit to this issue’s fork.

Comment #4

12 May 2023 at 07:21

vipin.mittal18 opened merge request !9

Comment #5

vipin.mittal18

He/Him

English

Greater Noida, India

commented 12 May 2023 at 08:03

Status:

Reviewed & tested by the community

» Needs work

As PHP 8.2 test cases failed, the status was changed to the correct one.

Comment #6

mlncn commented 30 July 2023 at 22:40

Version:	8.x-1.4	» 8.x-1.x-dev
Status:	Needs work	» Reviewed & tested by the community

The test failures are not the result of this patch. Tests are failing on the unpatched dev branch already (and the released version of the module too).

The failures are different on the merge request because vipin.mittal18 added an absolutely necessary fix for the tests to run at all— changing the theme to Stark, rather than Classy which is not enabled. But that, and the general test failures, should probably be dealt with in a separate issue / patch.

The patch in stevenlafl's initial issue creation is correct and is ready to be committed as per keshav.k's review.

Comment #7

heddn

English

Illinois

commented 22 August 2023 at 19:55

+1 on RTBC.

Comment #8

hchonov

Bulgarian

Burgas

commented 23 August 2023 at 08:24

But this issue shouldn't be occurring after https://www.drupal.org/node/3292540 or am I missing something here?

Comment #9

heddn

English

Illinois

commented 23 August 2023 at 13:44

You would think, yes. Perhaps there is something else going on that still injects that? I didn't dig into why or what is setting that property, but in 10.1 and PHP 8.2, that property is still getting set on a regular basis, or basically every page. The warnings are quite noisy.

Comment #10

arunkumark

Coimbatore

commented 10 October 2023 at 05:11

+1 RTBC. I have tested the patch with Drupal 10.0.5 it was working fine.

commented 20 February 2024 at 12:12

Any chance of a release to include this?

Comment #15

mglaman

English

WI, USA

commented 2 April 2024 at 20:53

Status:

Reviewed & tested by the community

» Needs work

The issue is due to the decorated service.

  form_builder.autosave_form:
    public: false
    class: \Drupal\autosave_form\Form\AutosaveFormBuilder
    decorates: form_builder
    # The decorated autosave form builder should be the first applied as it
    # will not call further decorators, but directly override the core form
    # builder by extending from it and just calling the parent methods.
    decoration_priority: 10000
    arguments: ['@form_builder.autosave_form.inner', '@form_validator', '@form_submitter', '@form_cache', '@module_handler', '@event_dispatcher', '@request_stack', '@class_resolver', '@element_info', '@theme.manager', '@?csrf_token', '@autosave_form.entity_form_storage']
    # Workaround for serializing decorated services. Remove when either
    # https://www.drupal.org/project/drupal/issues/2896993 or
    # https://www.drupal.org/project/drupal/issues/2531564 are fixed.
    properties: { _serviceId: form_builder }

#2896993: Decorated services crash on serialization. was fixed in 9.4.x, and #2531564: Fix leaky and brittle container serialization solution in 9.5. We can remove the workaround and change core_version_requirement to core_version_requirement: ^9.5 || ^10