Problem/Motivation

This will serve as the meta issue for adding Project Browser to Drupal Core. At some point this issue will be moved to the Drupal Core queue, but it can stay here for now.

Search (all MVP)

🌠 Starshot Blockers (search)

🅰 Alpha Blockers (search)

🅱 Beta Blockers (search)

General

Currently none.

🎨 Related to Finalizing the UI

Many of the issues blocking beta really belong to the concept of finalizing the UI. These are UI-related issues which may simply need a decision on, or need some work.

💹 Stable Blockers (search)

🚯 NON-BLOCKING, to be considered after MVP (search)

Done

Starshot blockers:

  • #3415099: [meta] Make it possible for Project Browser to apply recipes which are already in the local code base
  • #3371084: Promote drupal endpoint to full / default source plugin
  • #3459288: Unable to add and install a module via the drupal.org (json:api) source type
  • Alpha Blockers:

  • #3371084: Promote drupal endpoint to full / default source plugin
  • #3459288: Unable to add and install a module via the drupal.org (json:api) source type
  • Beta Blockers:

  • #3306736: Sanitize project page description HTML (esp. links/images URLs)
  • #3348960: @todo Add return type when php 7.4 support ends.
  • #3354461: Do not display Standard profile
  • #3376202: Error messages should utilize Drupal's messages
  • #3446322: Do not minify Svelte bundles
  • #3309273: Remove unused properties from the Project class
  • #3472334: Project browser filters are conflicting after switching between different tabs
  • #3475056: Make relevance the default sort
  • #3310908: Make the 'detail page' a modal window instead of a separate "page" in app
  • Beta Blockers, UI:

  • #3394904: Move styles out of svelte bundle to traditional Drupal library and its children
  • #3376201: Remove top pager
  • #3348761: Clearing keyword search with X does not update search results
  • #3365103: Outline on categories not appearing for check boxes - 508/Accessibility issue
  • #3376203: Filter's checkbox labels look broken at smaller viewports
  • #3315860: Change the position of the Browse tab in the local task order
  • #3315854: Improve the readability of module cards in grid view
  • #3444658: Remove the clear button from the tab order
  • #3444662: Make PB menu items behave similar to their siblings
  • #3293977: Adjust the chip design to the Drupal Design system
  • #3318726: Reposition the card centric spinner for the Svelte UI for install controllers
  • #3419177: Do not allow cards to grow more than 4-per-row
  • #3300093: Improve the readability on individual module pages by limiting the line length
  • #3293899: Adjust the radio button design to the Drupal Design system
  • #3446416: Module categories on Browse tab aren't clickable, don't perform a search
  • #3318817: Improve the categories filter type in context to the rest of the filter component ui
  • #3315864: Add a filter type for the release status
  • #3267678: Use icon to assist with understanding of maintenance status
  • Stable blockers:

  • #3310884: Ability to clear keyword/search filter with one click
  • #3365435: Update markup classnames
  • #3376206: Project list <ul> tag has multiple accessibility issues
  • #3446109: Test that we cannot tab to the clear search button
  • #3445811: Current page not selected in pagination widget
  • #3312056: Remove Content security policy icon
  • #3316155: [meta] Improve Project Browser's test coverage
  • #3354450: Improve help text (hook_help)
  • #3293909: Security and maintained icons need to communicate correct information
  • #3458908: Remove Modals after They're Closed
  • Non-blocking:

  • #3268636: Convert to GitLab CI
  • #3376208: Project list should be using CSS grid and use gaps instead of margins
  • #3365335: Display non compatible modules with current Drupal version
  • #3365392: Relocate Filters Button to the Left of Its Container
  • #3330887: GUI install multiple modules at once.
  • #3365180: Handle Package Manager errors and warnings more elegantly
  • #3348954: @todo Add "defer" property to generated <script> tag.
  • Comments

    tim.plunkett created an issue. See original summary.

    tim.plunkett’s picture

    Issue summary: View changes
    bnjmnm’s picture

    Issue summary: View changes
    tim.plunkett’s picture

    Issue summary: View changes
    bnjmnm’s picture

    Issue summary: View changes
    effulgentsia’s picture

    From the Priority TBD section in the issue summary:

    Make the Svelte app customizable by other themes OR get agreement on a policy on why this isn't necessary (this being a portal to a collection on an external site seems like a way to sell that)

    In my opinion, this is a must-have for core inclusion for two reasons:

    • Once Project Browser is in core, then it's part of core's admin UI, and admin themes like Gin would quite reasonably expect to be able to theme it to look like it fits with the rest of Gin's design.
    • This would be our first Svelte app being committed to core, which also means adding Svelte itself into core's toolchain. The hypothesis we had in deciding on Svelte was that we could implement themability for it in a reasonable way. In my opinion, we need to validate that hypothesis before committing Svelte into core's toolchain. Showing how that would work for Project Browser is a great way to validate that hypothesis.

    Meanwhile, tagging this issue for review from all the core committer roles to make sure we're all aligned on the roadmap to core inclusion, starting with giving feedback on the other 3 bullet points in the Priority TBD section.

    bnjmnm’s picture

    Issue summary: View changes
    wim leers’s picture

    #6: this is not in the Drupal core issue queue, so do those tags have any effect?

    Also, this roadmap seems incomplete/outdated?

    wim leers’s picture

    Also, do you intend to reuse the decade-old #1841788: Add project browser or do you intend to open a new core issue?

    chrisfromredfin’s picture

    Having a look at that one, I *think* it makes sense to open a new, clean one, so we're not muddied by the previous attempt. And yes, I think still incomplete.

    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    I just took a look through this, and most of the stuff I'm concerned about is in the Usability meta already. I'm not sure if that meta contains everything that is strictly _necessary_ for MVP or not.

    I did add one consideration which is the Project "Detail" page (vs. just reverting back to "link to drupal.org page") - though the Site Builder Subcommittee has been working hard on that piece of the puzzle to try and identify the most important aspects of those pages, so I think we could do it considering most of the plumbing is in place.

    Lastly, I only have a question as I'm unfamiliar with the process. Is there any non-code documentation required before it could go into core? Would it need a handbook page or something of that nature? If so, an issue should be created for that.

    wim leers’s picture

    In my experience, we consider a roadmap not actually a roadmap until there's zero meta issues left, because otherwise it's impossible to get a sense of the remaining size of work. (Because it's possible to add/remove issues to the meta issues, and that won't result in updates of this roadmap issue.)

    Right now this lists 5 issues, which seems a tiny amount of work, but probably each meta issue has a number of issues associated with it? And are each of those 5 metas fully scoped out?

    Yes, each module providing any API must have a *.api.php file, any module regardless of API or not must have a handbook page, and each module must also have a hook_help() implementation.

    quietone’s picture

    I came upon #3219457: Project Browser MVP Document which has had not activity, catch suggested to close this as a duplicate. This issue seemed the best fit so I have closed it as a duplicate of this issue.

    chrisfromredfin’s picture

    RE #14 @quietone - yes, 100% the right thing to do. Thanks!

    chrisfromredfin’s picture

    Issue summary: View changes
    Issue tags: +core-mvp
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Just a note that I have made marked updates to this and to the entire queue. This is following several triaging meetings with this team + Lauri. So, this is updated now and will be our path forward. Exciting!

    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    hestenet’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    xjm’s picture

    Per discussion with @chrisfromredfin, @Gábor Hojtsy, @leslieg, and @thejimbirch, Recipes support is a Starshot blocker. However, as Gábor pointed out, it requires extensive API changes in PB, which means that we'll have the best success if we also treat it as a beta blocker for core. I didn't update the IS because I'm hoping someone from the initiative can confirm. Thanks!

    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    quietone’s picture

    The issue summary states that many of the UI decisions need a decision. So, getting a usability review would help smooth the path to beta.

    chrisfromredfin’s picture

    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes
    chrisfromredfin’s picture

    Issue summary: View changes

    saving to get re-draw ¯\_(ツ)_/¯

    catch’s picture

    I think the current status in regards to package manager, is that if only project browser is installed, it uses core's package_manager, but if automatic_updates is installed, it uses the package_manager shipped with automatic_updates.

    For general stability and wider testing, it would be great if automatic_updates stopped shipping a copy of package_manager, but this really needs a beta package_manager in core, which has a couple of remaining blocking issues per #3319030: Drupal Core Roadmap for Package Manager and Update Manager.

    xjm’s picture

    Crediting discussion participants from #53... Or was about to, but this ain't my queue. 😅 Pasting this in the "Credit others" field will do the trick quickly and easily.

    xjm, chrisfromredfin, Gábor Hojtsy, leslieg, thejimbirch
    

    chrisfromredfin’s picture

    chrisfromredfin’s picture

    Status: Active » Postponed

    I am officially postponing this. I am unsure the path into core for Project Browser, if it's even necessary. So I can re-open and re-triage issues for core inclusion if that's something that presents itself as an actual need for more successful adoption of PB, or of Drupal itself.