Project Browser Site Builder Subcommittee Meeting for May 24, 2022 [#3307197]

1️⃣ Say hi when you join the meeting. Please add your drupal.org user name to your intro to make it easier for us to give credit. If you are new to this meeting, let us know what your interest is and we will make sure to help you learn how you might want to become involved

timplunkett (he/him)	hi! (tim.plunkett)
bnjmnm	:wave: (bnjmnm)
run fast think slow	Tim Run fast think slowLets hurry up and get this done -oh yea lets do it right! :slightly_smiling_face:
saschaeggi	:wave:
chrisfromredfin	hi all
bsnodgrass (he/him)	Hoping on a bit late from St Charles IL, western burb of Chicago
run fast think slow	Suggest to start a new thread for categories?? @leslieg
fjgarlin	Hi there (fjgarlin) (edited)
thejimbirch	Hi! thejimbirch
jjcs227	Hello Everyone!, jjcs227
leslieg	@jjcs227 Interested in seeing where you and the other Discover Drupal folks want to hop in. Are you having a call this week with @AmyJune (volkswagenchick)
pearcraft	Howdy! :face_with_cowboy_hat: (pearcraft)
Libbna	Hey everyone!! Libbna
chrisfromredfin	Welcome @Libbna!
Libbna	Hey @chrisfromredfin :wave:
AmyJune (volkswagenchick)	AmyJune (volkswagenchick) - Lurking again to stay up to date

2️⃣ So much progress has been made recently - thanks to all the contributors. From Figma: (edited)

run fast think slow	Honest question - So this just goes to a figma that has just Drupal project browser. Is this a button ? Where is this supposed to be or function etc
bnjmnm	There's a "pages" menu on the right that takes you to the various comps
run fast think slow	ohhh this goes to the same file! duh I haven't worked with figma before- just figured it out.For the others that had the same issue - there is a tiny ding bat in the top left corner. This takes you to different versions within the same file. That blue page / button is just the first page. It's called cover.
bnjmnm	There's something about that first page just being a logo that makes it seem like there aren't other options - totally understand
run fast think slow	I zoomed out to 2 percent and couldn't find anything. But if you switch pages by clicking on that ding bat wowla.

3️⃣ Is anyone else having issues getting DrupalPod to work this afternoon? The website is not getting launched for me. This is what I get when clicking on the Gitpod link in the Project Browser page

timplunkett (he/him)	Trying it myself
shaal	Testing it myself as well
timplunkett (he/him)	works fine for me
timplunkett (he/him)	not clear from the screenshot what happened, but if you mean those composer warnings, they're not stopping it from working
shaal	Works for me. I'm always available to help with any drupalpod issue
leslieg	I’m never getting the website launched. Trying in a new browser instance
shaal	If you are waiting for the preview, you need to click with your mouse in the terminal
shaal	But otherwise, you can always open the ports panel, and open the website from there (as preview or as external tab)
chrisfromredfin	:100:yes I find I have to click once in the terminal to get it to pop up
leslieg	Worked this time. I didn’t do anything different. Must have been an issue on my local machine. Thanks for checking things out for me
shaal	Also, if something is "stuck", a refresh of that tab can solve it many times

5️⃣ Feedback from review of current implementation (done yesterday on Gitpod). Could use help figuring out which issues already exist

leslieg

What’s best way to collaborate on these. Maybe I should have made separate threads for each?

Move category column up to left of other filters. Don’t need search box being full width. (DONE)Change googlee advanced filter icon to a buttonChanged “covered” to ?? what happened to other default filtersmust have a release compatible with this version of drupalmust have security coveragemust have a supported and recommended release (that is compatible)maintenance status: actively or minimally maintained, or seeking co-maintainersdevelopment status: actively developed or maintenance fixes onlyno way to get default filters back once you change themChange sort filter - button changes to that label - lose sort contextshould asc or desc change based on filter selected. Desc for usage, asc for title for examplechange wrench iconDisplay wonky when only two results in a row

fjgarlin	Some of these options are meant to be dynamic, and they are maintained by d.o and they will be retrieved dynamically via a plugin and api call. There is a related issue for some of these things: #3281218: Restrict the plugin's ability to control which filters are available (edited)
fjgarlin	Also some issues already in progress for some of the points. I’m on mobile right note but will try to link them tomorrow if nobody has done it by then
chrisfromredfin	The Material Design "filters" button is not intuitive, I agree, at least for newcomers and non-techies. Doesn't have an issue now, so one should be filed. I'm trying to think of where I've seen this pattern in Drupal, but I feel like a link that's "Advanced Search" that appears underneath might make more sense than the icon?
chrisfromredfin	what happened to other default filtersmust have a release compatible with this version of drupal - this is always true and automatically will be built in - you will NOT be able to search for non-compatible projects through project browser; you should go to d.o for thatmust have security coverage - it's covered by security or it's not. if it is, then "must have a supported and recommended release" is implied within security coveragemust have a supported and recommended release (that is compatible) - see abovemaintenance status: actively or minimally maintained, or seeking co-maintainers - these are currently filterable, but the defaults are not set correctly; again, I propose we lump these three into a radio that we call "maintained" vs "not maintained" or somethingdevelopment status: actively developed or maintenance fixes only - I propose we lump these in also, so "actively developed" or not
chrisfromredfin	no way to get default filters back once you change them - for this I propose a "reset to default" next to "clear filters" which operates similarly but sets us back to "Recommended" (which used to be a tab but is no longer)
chrisfromredfin	really I guess all this should be filed as issues... but it's a big list. :slightly_smiling_face:
leslieg	agree on filing issues for each if one doesn’t exist. Will try to get to that later today
fjgarlin	Grouping into radio buttons goes against the api design and dynamic nature of the data as you need to fully know the data before render, then group it and then decode it when making the call to the api. Again, feedback on this issue is crucial I think: #3281218: Restrict the plugin's ability to control which filters are available (edited)
fjgarlin	We will be reading values and rendering them from an api endpoint so it's important to agree on the process on that issue as there is an external dependency (the do api endpoint)#3240319: Prepare to switch to using (the future) Drupal 9 JSON:API endpoint - implement tests, etc.

Gray Installed button brings user to Extend page in a new tabCategory filter not working with advancedTwo filters have maintenance in them - one is development status, one is maintenance status

chrisfromredfin	Gray installed button needs an issue, I don't see one for that.For category filter; what's not working? If you know you may need to file the issue @lesliegThe confusion word of "Maintenance" - @drumm brought up needing to be able to change the wording somewhat at will. That's being discussed in this issue. I might propose "meta categories" for each of security, maintenance, development... -> would welcome thoughts here: #3281218: Restrict the plugin's ability to control which filters are available
timplunkett (he/him)	#3281620: Module category filters not shown in active filters, "Clear filters" doesn't remove them is the category filter
chrisfromredfin	ooh, even an open and mergeable MR with passing tests :wink: !

Need tooltip on icon

run fast think slow	Sooo I am on the fence about this. Maybe past the point of discussion.
leslieg	just tooltips on the security and maintenance icons - do you not think those would be helpful for those not as familiar with Drupal @run fast think slow
chrisfromredfin	like when you hover the icon it gives you a little yellow "actively maintained by the community" or something
chrisfromredfin	just so someone knows what the icon means
bnjmnm	Tooltips are difficult to make accessible as they typically require hovering, something that isn't available to users not using pointer devices (which means it extends to touchscreens as well). The implementation would need to have a way of making that info available to non-pointer users. There are usually ways to do this, but it's much easier if it's part of the initial design
bnjmnm	Vs getting scolded by an accessibility maintainer when we propose to make this part of core :slightly_smiling_face:
chrisfromredfin	so maybe a legend is a better option?
bnjmnm	I think so
chrisfromredfin	wonder where that could fit...
bnjmnm	I bet there's an option C we haven't thought of
run fast think slow	Tool tips drive me nuts if they are not helpful to me. (If I am already fimilar with the site case) They are forced upon me sortof. They show up and you cannot see whats underneath often times.Now on the other side they are very helpful, show stopper to helping me understand the site sometimes as in this case possibly, from a first time visitor.I don't have a good suggestion to this though. I don't want to take more space to explain what the tooltip is explaining but don't want to 'hide' what is underneath . So am on the fence sigh.
leslieg	Legend or another implementation is fine. Idea is to just let folks know what the icons stand for
bnjmnm	If there isn't already an issue for this, perhaps it'll work best to create one where the stated goal is to clarify what the icons mean, then summarize the pros/cons of tooltips we discussed here
bnjmnm	Maybe it's a little bit of help text above the grid.
chrisfromredfin	This is the closest thing that exists, which is actually just to change the wrench icon to something else (Jillian put forth some ideas somewhere that were improvements) #3267678: Use icon to assist with understanding of maintenance status
leslieg	agree on the need for an issue @bnjmnm with that text. Will create one if it doesn’t exist
chrisfromredfin	I will make an issue for legend/tooltips/iconography
chrisfromredfin	added: #3282163: Improve iconography usability by adding a legend
run fast think slow	I think words are best in this case probably, but if there was a 'standard' icon I would be open / love that better. Icons can communicate across languages - anyhow just thoughts

6️⃣ I have been working on the “Top 100 modules” spreadsheet to link to the meta issue for each module and to indicate which issues have proposed solutions. Note - I have a lot of work to do there. Reach out if you have availability to help update the spreadsheet, to create issues or to work on the issues. Each meta issue has 3 child issues - one for logo, one for short description and one for suggested top 3 categories. Folks can choose which child issue to work on

thejimbirch	If you can assign me some tasks, I could start on Friday for an hour or two.
thejimbirch	I am good at making issues :wink:
pearcraft	I’m also available on Friday morning.
Webbeh	Happy to help generate those meta issues. That's quite a list, but should be helpful in getting those accomplished.

7️⃣ Would anyone be interested in having a contribution event on Friday to work on this (the Top 100) together? Thinking is that work may slow down a bit before the long weekend (edited)

run fast think slow	I would make some time for this.
chrisfromredfin	I would jump in if I'm able. I should be. :slightly_smiling_face:
bnjmnm	I'll be working on PB all day anyway (EST) so I'll be around.
bsnodgrass (he/him)	I could spend ~ an hour on this Friday, full day but flexible, so I could do anytime (edited)
leslieg	Thanks all.
run fast think slow	Welcome. Lets do this!
chrisfromredfin	@leslieg we should invite other folks at redfin; even if they can do 1-2 hours only it's a good intro for Jessica and/or Jay etc - IF we can spare them :wink:
leslieg	And I plan on letting all the folks that helped at DrupalCon know.
leslieg	I think I’ll say all day and folks can hop in when they can. Does that sound ok to folks?
chrisfromredfin	That's a good plan. So just be an in-channel sprint?
pearcraft	I’m in! :laughing:

9️⃣ Updating the available categories. This is a huge undertaking and not sure if there’s time for it for MVP. Not doing it opens the project browser up for folks saying there are way too many categories. One good thing that has happened is that @mandclu and other folks have come up with definitions for each category. How do we add those to the website @fjgarlin or @saschaeggi or anyone else? (edited)

chrisfromredfin	@drumm or @hestenet (he/him) - do you know - are we using the taxonomy description fields right now at all, and if not, could we use them and build a view of taxonomy terms in the categories and their descriptions, as a way to provide a glossary/help for knowing when to check which box?
run fast think slow	So a side topic - I was looking at some of the suggestions on the tabs - A couple of suggestions were to delete a Category. Which I actually agree with BTW, but what about those modules that will have no category assigned to them if we take those suggestions?Looking at Months old data with certain filters in place there are 324 modules without a category assigned to it. This would be increasing that number. In the new model it will be important to have the module have a category to be found likely.Or how much do we want to encourage all modules to have a category in the new system?
run fast think slow	Take the category 'Other' for example. Not a question if we should delete this, that is agreed, but what do we do about those left with no assignment? There are 126 modules that have other assigned to them. There are 33 modules that only have other category assigned to it.
chrisfromredfin	we approach the top 100 with suggestions of what they should be tagged with
chrisfromredfin	eventually, we move on from top 100 and/or send messaging out to maintainers to update according to the definitions we have
run fast think slow	ok
run fast think slow	EU Cookie Compliance (GDPR Compliance) https://www.drupal.org/project/eu_cookie_compliance Is top of that list
hestenet (he/him)	do you know - are we using the taxonomy description fields right now at all, and if not, could we use them and build a view of taxonomy terms in the categories and their descriptions, as a way to provide a glossary/help for knowing when to check which box?I am not 100% sure, but I think we would be safe to use descriptions in this way. Even if we are using those somewhere else(and I don't think we are), it seems like whatever new descriptions would be created would likely be better wherever they are used.
chrisfromredfin	I tend to agree :slightly_smiling_face:
chrisfromredfin	@mandclu is that list in an issue right now, or a spreadhseet or what?
run fast think slow	@chrisfromredfin Are you looking for this spreadsheet?https://docs.google.com/spreadsheets/d/1igNmyQLybkRhK8x40Gjo1lK8DRaDoGcg...…]e=gmail&ust=1633193250802000&usg=AOvVaw31msHgQDL5cbhupvyzCChP
leslieg	It’s column E in the categories google doc @chrisfromredfin (edited)
chrisfromredfin	Thanks!
drumm	Yes, using the term descriptions on Drupal.org would be good.

1️⃣0️⃣ What’s the length of the short description for the cards? Looks like it’s 200. The Summary field on drupal.org project pages looks to allow more characters than that. Should we limit short description to 200 or ? (edited)

chrisfromredfin	Someone needs to investigate this in the code. It might be being set (1) in the Svelte frontend, (2) by API calls or API responders, (3) being fakes in the fixture generation and only being truncated there (4) none of these... my guess is it's actually only (3).
fjgarlin	This will eventually come from an api call so I think the truncating should probably happen in the front end to make the cards look right
leslieg	It would be helpful to make that decision as soon as possible so folks proposing short descriptions will only have to do it once @chrisfromredfin
leslieg	@Jillian Chueka did you have a length in mind?
chrisfromredfin	I was wondering that same thing! :slightly_smiling_face: The mockup has them around 124 characters. I think we could go to 140 to 170 which is about three lines of tecxt. Mockup shows two?
chrisfromredfin	if the summary allows only 140 then I think that's perfect.
leslieg	The summary allows way more than 140. I found some at 288 - project browser for example (edited)
chrisfromredfin	180 is kinda the absolute max for three lines (assuming fixed width font, which it's not).
leslieg	I found some in the figma mockup that are 194 and 195 characters
chrisfromredfin	oh in figma you mean. Are they on three lines?
chrisfromredfin	You can go to 380 I've seen in the list view.
chrisfromredfin	I say we just take the summary, and cut it where we cut it.
leslieg	5 lines on card view in the figma, 4 in the implementation (edited)
chrisfromredfin	each line is about 60 characters in the figma. so I think we could cut off around 240 then, if four lines fits...
leslieg	I’d rather have a decent 200 character description than just cut it at 200 (or 240 or whatever that number is) (edited)
chrisfromredfin	Right but they're (crurently) different in list vs. grid. We could just do like a 200-char "fixed" limit and just show the known good description on both.
chrisfromredfin	That is, with regard to top 100, we can target 200 char (or less) full-sentence descriptions.
Jillian Chueka	I think asking @timplunkett (he/him) if there are any technical limitations. I agree under 200 is good. If the user wants to know more, they can open the card to that module's information page. The short descriptions are meant to be high level what the module is and does.

1️⃣1️⃣What are we using for the default logo? Looked like a puzzle piece on the figma. There’s a different default image on the current DrupalPod (edited)

chrisfromredfin	we should switch it to puzzle piece; that needs an issue
leslieg	Will create that

1️⃣2️⃣ - could someone take a look at this ? #3269587: Missing contributor.md file - someone with some contriub experience like maybe @thejimbirch ?

run fast think slow	I would like to see images added in key places. Maybe I could help with that. Maybe - not sure of commitment yet just interests.
bsnodgrass (he/him)	@chrisfromredfin added "Would like to get the google doc converted to a .md and get it shipped; will help as we bring some new folks on board, maybe"I plan on participating on Friday, if it's not taken I will pick it up at that point. (I have something else related I am working on already)
chrisfromredfin	groovy!
thejimbirch	Let me know if you need any help Bob.
bsnodgrass (he/him)	I saw a number of comments on the contributor.md file this week... haven't yet reviewed them, so I'm not sure if this needs more work at this point. Do you know offhand @chrisfromredfin?
chrisfromredfin	It’s pretty close but it definitely could use another look. Also I think we are wanting to maybe add a section about a git pre-push hook
bsnodgrass (he/him)	ok I will take a look, someone else should pickup on the git pre-push section hook... Not sure I can add much to that part
thejimbirch	I added the bullet points from the README contributing section. @chrisfromredfin Where in the codebase is the git pre-hook? I can look at that
chrisfromredfin	#3282338: Use git hooks to prevent push if yarn build was not run
chrisfromredfin	So the outstanding question is (1) Can hooks be committed to the repo and shared around? If so, great - let's add to repo. If they cannot and they are always checkout-specific, then we should add instructions for adding the hook in the Contributor.md - as a "nice thing to do" - @bnjmnm may be able to shed some insight. I thought we could send hooks via repo.
bnjmnm	Due to my job largely working on Drupal core I'm a bit conditioned to thinking NO change is allowed. It may actually be possible and I'm just cautious by habit
chrisfromredfin	Then let's do it since we're in contrib ;)
chrisfromredfin	It will accelerate development and if they don't want it later we'll rip it out?
thejimbirch	So, since it doesn't exist yet, could we add it to the contributing doc after it is in (or as a part of adding it)?
chrisfromredfin	Yepper

1️⃣3️⃣ For the logos that already exist there are comments in the Top 100 Modules google doc that refer to licenses of the logos used. - See column D (Font Awesome, Slick, Search API Solr, VIews Bootstrap, …) Guessing they are ok since they are used on drupal.org currently. Is this something we need to look into @hestenet (he/him) or anyone with knowledge in that area?

hestenet (he/him)	I think we can rely on the fact that the maintainers need should already be ensuring they have usable rights for the project pages, yeah. (And static assets like images are a different kind of licensing than gpl and code)
leslieg	Great, thanks @hestenet (he/him)

Participants:

run fast think slow, bnjmnm, timplunkett (he/him), shaal, leslieg, chrisfromredfin, fjgarlin, thejimbirch, pearcraft, Webbeh, bsnodgrass (he/him), hestenet, drumm, Jillian Chueka