Automated Drupal 10 compatibility fixes

Patched #5 applied successfully, and all issues were fixed.

Verified patch #8 on Drupal 10.0.x and 10.1.x. Patch applied successfully and looks good to me.
Module can be installed after applying the patch.
Screenshots are attached for reference:
Can be move to RTBC
RTBC+1

Updated the PR and removed all the not needed changes per @mglaman suggestions, all the phpcs/phpstan issues should be handled separately in a new issue or even in multiple ones, so its easier to track changes.

Thanks @nkoporec. Looks good. Moving to RTBC to prevent Update Bot from sending in new patches until this gets merged or asked for more changes.

Removing the ProjectUpdateBotD10 is the best way to prevent the update bot.

Ready to commit? Would be great to have a D10 compatible tagged release.

+1, D10 compatibility needed for automated testing in https://www.drupal.org/project/cookies! Would really appreciate this release! :)

I contacted the maintainer directly, let's wait for an answer!

@solotandem any updates?

@solotandem: Would you be able to release a version that is compatible with D10?

It would be ideal if google_tag had a co-maintainer, but unfortunately the offer was not accepted. #3317621: Offering to co-maintain Google Tag Manager

The patch looks pretty straightforward, what is the status on this?

@solotandem This is awaiting your action.

In order to update project(s) to Drupal 10 in lieu of a new release here, I had to do the following:

Add this as the first entry under 'repositories' in composer.json:

"repositories": [
        {
            "type": "package",
            "package": {
                "name": "drupal/google_tag",
                "type": "drupal-module",
                "version": "1.5",
                "dist": {
                    "url": "https://ftp.drupal.org/files/projects/google_tag-8.x-1.5.zip",
                    "type": "zip"
                },
                "require": {
                    "drupal/core": "^8.8 || ^9 || ^10"
                }
            }
        },

and still keep the patch:

            "drupal/google_tag": {
                "Drupal 10 compatibility": "https://www.drupal.org/files/issues/2022-07-23/google_tag.1.x-dev.rector.patch"
            },

Otherwise, Composer will refuse to download Drupal 10.

Relevant changes included in commit in #25. Reopen and restore tag. Thanks to all.

Thanks @solotandem!

Is this fixed then? The bot won't provide further patches for D10, so we could close this.

Changing status as suggested in #27.

What about problems like
Call to deprecated function file_create_url(). Deprecated in drupal:9.3.0 and is removed from drupal:10.0.0. Use the appropriate method on \Drupal\Core\File\FileUrlGeneratorInterface instead.

What code (core, this module) are you running that generated this 'problem'? The code in 8.x-1.6 release of this module checks for the 'file_url_generator' service available in drupal 10. if present it uses that, otherwise it calls file_create_url() which exists prior to 10. How can the 'problem' you mention exist if you are using compatible code?

Yep, I didn't check the code, I just saw the problem reported by upgrade_status, sorry. This makes it harder to see which projects are actually ready for D10 because I need to manually go through each problem reported by upgrade_status and see if they are false negatives or real problems.