Closed (fixed)
Project:
Project Browser
Version:
1.0.x-dev
Component:
Contrib changes
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
27 Apr 2022 at 20:18 UTC
Updated:
16 Dec 2023 at 16:14 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #2
leslieg commentedComment #3
chrisfromredfinComment #4
leslieg commentedComment #5
bsnodgrass commentedassigning to myself
Comment #6
leslieg commentedLooks like this still needs work
Comment #7
damienmckennaComment #8
bsnodgrass commentedWe discussed this Damien, he would like it if someone could create a logo for the metatag module.
I am not the right person for this, so unassigning myself.
Comment #9
alyssapanetta commentedComment #10
alyssapanetta commentedWorking on this with Design4Drupal
Comment #11
lostcarpark commentedHere is my first thought on a logo for the Metatag module...

Comment #12
damienmckennaThat's really neat! How about changing it to Druplicon instead of the more generic logo?
Comment #13
lostcarpark commentedHi Damien,
Sorry I get confused between the Drupal logo variants. Which one are you thinking of?
Comment #14
damienmckennaThis one: https://www.drupal.org/about/media-kit/logos

Comment #15
lostcarpark commentedHere are a couple of possible versions to consider...
I still prefer the one from my original post, but are there trademark issues with using that logo?
Comment #16
damienmckennaThe Druplicon logo is licensed under the GPLv2 license, so this usage is allowed.
Comment #17
lostcarpark commentedI see that. But the generic logo in my first post is trademarked, so might be more problematic?
Comment #18
damienmckennaYes.
I like the general shape of the Druplicon one (not the two-color one).
What was your rationale for using the color green? How would the image work if it was blue?
Comment #19
lostcarpark commentedNo particular reason for choosing green, except for variety.
I'd be happy to do a blue version.
Comment #20
lostcarpark commentedHow about this?
Comment #21
lostcarpark commentedComment #22
lostcarpark commentedComment #23
lostcarpark commentedComment #24
chrisfromredfin+1 on #20 - love it!
Comment #25
damienmckennaThat does look better than the green version.
How would it look with the full druplicon instead of just the outline?
Comment #26
lostcarpark commentedI have tried a version with the Drupalicon, but it's challenging to get enough contrast between the background and the foreground:
As an alternative, I've tried adding the face to the white version. I think I like this one best:
Comment #27
lostcarpark commentedComment #28
lostcarpark commentedComment #29
amourow#20 Looks better to me.
https://www.drupal.org/project/project_browser/issues/3277521#comment-14...
Project browser already has a border radius in the list, the corner radius may cause conflict to it. How about remove the corner and leave it to the CSS.
Comment #30
lostcarpark commentedOh, I hadn't realised. I can redo with square corners.
Comment #31
lostcarpark commentedHere is the version with a face with square borderEdit: removed because I uploaded the non-minified version.
Comment #32
lostcarpark commentedHere is the version with a face with square border:
Comment #33
lostcarpark commentedI'm also uploading the faceless version. Putting in a separate comment to make it easier for people to express a preference:
Comment #34
lucasscLogo #32 looks great to me! +1 for this
Comment #35
lucasscScreenshot of how this looks like on the card
Comment #36
lucasschow logo #33 looks like on the card
Comment #37
damienmckennaI think #35 looks really good!
Comment #38
damienmckennaI'd like to add the image to the module as an example for the test coverage. Might you be able to upload an SVG of the image too? Thank you.
Comment #39
lostcarpark commentedUnfortunately the issue queue doesn't accept a SVG file. Will get to you another way.
Comment #40
lostcarpark commentedComment #41
damienmckennaYou could zip/gz it?
Comment #42
sophiavs commentedFor me the #32 is really awesome, since there was some people who agreed i'll pass to RTBC.
Comment #43
ressaYou can rename it like this: filename.svg_.txt
Comment #44
lostcarpark commentedUploaded SVG with .txt label as suggested.
Comment #45
damienmckennaI created two separate issues for adding the new logos to the codebase and update the tests to use them: #3311542 and #3311543
The next thing to do is to update the project settings to use the logo.
Comment #46
ressaAdding related issues.
Comment #47
damienmckennaDone! https://www.drupal.org/project/metatag
Great work everyone!
I'll leave this RTBC for the Project Browser maintainers to close and give the appropriate attribution.
Comment #48
lostcarpark commentedThis logo has been adopted by the module. Can this issue be closed?
Comment #49
leslieg commentedHi Damien. Could you please take this one last step - we initially were going to use the first image as the Project Browser logo, we are now using the logo.png file in the codebase. Thanks
MAINTAINERS: The logo should be added to the root folder of the repo, and be named logo.png. This must be present on your project’s default branch. If you have a logo as the first image in the Images field on your project page, please remove it. The logo will be displayed on the cards in the Project Browser grid and list views.
Comment #50
damienmckennaI'll rename the file (#3359952: Rename logo file to just "logo.png").
Comment #51
damienmckennaDone.
Comment #52
leslieg commentedThanks Damien. You can remove the logo from the images. We are pulling the logo from logo.pong now, so no need to also have it as the first image.
Comment #53
damienmckennaDone.
Comment #54
damienmckennaComment #55
bramdriesenThis can be set to fixed as the logo has been committed, not doing this myself so a maintainer here can check credits.
https://git.drupalcode.org/project/metatag/-/blob/8.x-1.x/logo.png?ref_t...
Comment #56
leslieg commentedComment #57
leslieg commented