When entries in the list of changes contain \V, this sequence is replaced by <br>.

Example, as returned by https://www.drupal.org/api-d7/node/3249219.json:

<li><a href="https://git.drupalcode.org/project/drupal/commit/16d107539f5023a14473488f9cbe4fbe266ffed7" rel="nofollow">Issue #2569381 by alx_benjamin, init90, vasi, deepakaryan1988, Munavijayalakshmi, Lendude, DuaelFr, alexpott, dawehner: Drupal<br />
iews\Plugin<br />
iewsrea\Result does an unnecessary XSS::adminFilter()</a></li>

Some of the affected pages are:

Comments

ciss created an issue. See original summary.

ciss’s picture

ciss commented
Issue summary: View changes
ciss’s picture

ciss commented
Issue summary: View changes
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Project: Drupal.org content » Drupal.org infrastructure

https://www.drupal.org/api-d7/node/3249219.json is the output of the REST API used on drupal.org.
REST and other APIs says that support and API changes support and requests should be posted on the Infrastructure issue queue. I am not sure if a bug reports is considered an API change. I apologize if I am moving this bug report in the wrong queue.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

It's not clear to me what the bug report is describing. https://www.drupal.org/api-d7/node/3249219.json returns JSON data, while the part after Example, as returned by https://www.drupal.org/api-d7/node/3249219.json shows HTML markup. If I search for deepakaryan1988, Munavijayalakshmi, Lendude, DuaelFr, alexpott, dawehner in https://www.drupal.org/api-d7/node/3249219.json, I find the following text.

Issue #2569381 by alx_benjamin, init90, vasi, deepakaryan1988, Munavijayalakshmi, Lendude, DuaelFr, alexpott, dawehner: Drupal\u003Cbr \/\u003E\niews\\Plugin\u003Cbr \/\u003E\niewsrea\\Result does an unnecessary XSS::adminFilter()\u003C\/a\u003E\u003C\/li\u003E\n\u003Cli\u003E\u003Ca href=\u0022https:\/\/git.drupalcode.org\/project\/drupal\/commit\/a0f291955f75d6340b9e5aefa0a55e96538829fd\u0022 rel=\u0022nofollow\u0022\u003E

Effectively, \V is replaced by \u003Cbr \/\u003E\n (which seems escaped text for <br />\n).

In a JSON string, \V is the escaped character for the vertical tab.

drumm’s picture

drumm
he/him
Location NY, US
commented
Project: Drupal.org infrastructure » Drupal core
Version: » 9.4.x-dev
Component: Other » ajax system

Drupal core releases and their notes are written by the core release managers.

cilefen’s picture

cilefen commented

Agreed. That's not an output filter. The actual stored text has a linebreak. This issue may actually belong to https://www.drupal.org/project/grn.

cilefen’s picture

cilefen commented
Component: ajax system » documentation

I'm just setting a component so as not to confuse everyone with the default component when switching projects.

cilefen’s picture

cilefen commented
Title: Drupal core releases: "\V" in list of changes replaced by line break » Drupal core release notes have a line break everywhere there is a "\V"
xjm’s picture

xjm
she/her
Primary language English
commented

So there are two possibilities:

  1. This could be a bug in grn, which would mean moving the issue to their queue after we manually fix affected core release nodes.
  2. This could be a bug in the scripts that we use to tag core releases independently of grn.

Which it is depends on whether or not this bug affects the most recent core releases (or any core releases tagged by me specifically in the past year). We recently updated the release-creation script to not use grn. (Previously it would use grn if installed, or default to git and bash formatting if grn were not installed. This meant that I personally stopped using it when I stopped installing drush over a year ago, but other release managers continued to use it until we agreed to remove the grn dependency entirely within the past month or two.)

If it turns out the bug does not only affect grn but also other releases that did not use grn, a bug report can be filed against https://github.com/xjm/drupal_core_release.

Thanks everyone for reporting this and clarifying the source of the issue!

xjm’s picture

xjm
she/her
Primary language English
commented

https://www.drupal.org/project/drupal/releases/9.3.0-beta2 was given as one of the examples and I tagged that just last month, so this might be an issue with our bash scripts to be filed in the above queue off d.o.

quietone’s picture

quietone commented

I've fixed the first 3 release notes list in the in IS. For the fourth, I didn't spot the problem. I also scanned the release notes going back to 9.2.6 and didn't find any other occurrence of this \v problem.

ciss’s picture

ciss commented
Issue summary: View changes

In a JSON string, \V is the escaped character for the vertical tab.

@apaderno That's \v, not \V (still, TIL!) :)

For the fourth, I didn't spot the problem.

@quietone Apologies, the last one seems to have made it in by accident. However, I found one more occurence here: https://www.drupal.org/node/3157835

I've put together a small helper to search release notes, which can be found here: https://observablehq.com/@mootari/drupal-search-releases

All Core release notes seem to be clear now, at least for the /[^Vv]iews/ case.

As an aside, the link parsing in issue descriptions seems to be iffy. https://www.drupal.org/api-d7/node/3249219.json: includes the second : in the link.

quietone’s picture

quietone commented

@ciss,no worries.

I have updated the one found in #13, https://www.drupal.org/node/3157835.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Category: Bug report » Task
Status: Active » Fixed

This is cause by a bug in the script that creates the changelog. There is a pull request for fixing it. In the meantime, we just need to keep an eye on it.

Since the existing release notes that had the problem are fixed, I am closing this as fixed.

xjm’s picture

xjm
she/her
Primary language English
commented

Adding credits for folks who helped research this, since it at least gave us a direction on how to fix the custom scripts. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.