1️⃣ Add and activate Automated Testing for the Project Browser module issue Rajab added this issue. His work needs review and he needs help writing automated tests. Can anyone take these tasks on? (edited) 

Rajab Natshah The only needed action on this is to "Activate Automated testing" from the project settings.Project owners and maintainers can activate thatSo that that we can build more automated testing and be able to run them with DrupalCI.
Rajab Natshah More MR/PR will follow in-development branches
Rajab Natshah I remember @chrisfromredfin said that we need to list all the testing scenarios.
chrisfromredfin I'm setting this up here - does anyone know what I should choose for "Schedule" - I'm thinking "on commit and for issues" ?
chrisfromredfin image.png
chrisfromredfin FWIW that's what I chose and I think I've done this successfully; build / tests fail tho
Rajab Natshah Run on commit and for issues
Rajab Natshah For sure we can manage to have a green build for a patch or MR/PR
Rajab Natshah The patch in the issue should pass green
Rajab Natshah I will run a retest for the patch
Rajab Natshah 1.0.x: PHP 7.4 & MySQL 8, D9.3 Queueing
Rajab Natshah You can see a video for how the test worked in my local ( attached in the issue too )
Rajab Natshah In the last 2 weeks, I managed to learn more about the drupalci.ymlWe could do anything like what you can see in this drupalci.yml file
Rajab Natshah Thank you @chrisfromredfin for activating the automated testing :pray:
chrisfromredfin :thumbsup:

2️⃣ Rajab also fixed an Array to String Conversion issue that needs review. Can someone take this on? (edited) 

Rajab Natshah Fixing this will ease the work of local development and robots like DrupalCI...Not needed on changing the function under PHP7.4
gaurav.kapoor The issue was slightly difficult for me to reproduce in local, will give it another try, test the patch and provide my findings on the issue.
Ron Northcutt I took a look, and the code looks good. If @gaurav.kapoor can test it, then we should be RTBC

3️⃣ Decide on language for “Recommended” modules issue. The Sitebuilder subcommittee discussed (see thread above), but did not come to a consensus for replacing the term “Recommended” in the mvp version of Project Browser with something that does not have a connotation that the modules listed are truly recommended over others. Thoughts from this group?

bsnodgrass (he/him) I like "Highlighted" but can we add other qualifiers to that such as "Stable, active, supported, ??"I'm concerned just a single title for this thing seems like it would not translate well for many people.
thejimbirch I added as options:HighlightedFeaturedWordPress has the following:
mandclu Has there been a decision on what criteria will be used to determine the list?
mandclu If they're really the most popular (based on usage) the tab could be called "Popular"
bsnodgrass (he/him) there is this @mandclu #3240314: Decide on algorithm for "recommended" modules
mandclu OK so it still sounds as though the default sort will be based on the number of installs. I like "Popular", though it doesn't necessarily convey that the list is also pre-filtered, potentially based on things like stability, being maintained, etc
Rajab Natshah Maybe Relevant tooIt feels like each tab is a selection for an algorithm ( Main Filtering option )
Rajab Natshah Relevant: Relevant to this site
Ron Northcutt Reposted from SB comment above:FWIW - I think that “recommended” and “highlighted” both convey a sense that they are promoted in some way. On the other hand, “suggested” seems a bit less promotional.Then the question is “why are these suggested?“, and the answer (which could be in a tooltip or description) is that these suggestions are based on the current site and the configured filter options. Then we can have a link to change the suggestion settings
bsnodgrass (he/him) I really like the Why are these suggested tooltip idea! that would give people a much better understanding
Ron Northcutt and possibly a link to modify the settings :smile:

4️⃣ The site builder subcommittee also discussed the issue regarding Finalizing the fields on the Card view of Project Browser results (see thread 1 from SBSC meeting above). There were 6 proposed fields. Any additional thoughts there? The six fields were  image(logo), title (linked to d.o page in new window), short description, security status, category,download/install icon/button (edited) 

Ron Northcutt Sounds good to me. Three suggestions:security status should just show a badge for those covered, and not show one otherwise (to keep confusion low)^^ implies that we can filter by securitywe should use the first image if any exist, and a drupal icon as a fallback. Then we can educate project owners to order their images properly to put the best image or logo first
tim To easy the transition from the old way to this new way - what about including some fields like last updated and number of downloads.  But I am not hard set on that, just an idea.Some people are going look for that info to help them decide .... 'Thats what they have always done in the past' ....

5️⃣ an item that has come up a few times around whether or not to include “Core” modules in the results.  See thread 5 from yesterdays site builder meeting and this issue. Additional thoughts on this?

leslieg @Ron Northcutt do you have any thoughts here. @chrisfromredfin added thoughts to the issue, but would like to know what you and others think as well
Ron Northcutt I added a comment to the issue. TLDR: I think its a very good idea and worth being in the backlog, but it creates new problems for us to solve.Unless D.O wants to add core modules to the API feed, then we should shelve this feature for a future look once we have something stable.
tim @Ron Northcutt I agree.  If core modules needs to be in list we can do it in phase 2 etc.
chrisfromredfin :thumbsup:

6️⃣ I haven’t been following this initiative closely but I am working on Automatic Updates for core. We are at the point where we can update core via Composer.  We also have sub module package_manager that handles the composer parts. When/if this Project Browser is at the point where you are wanting work on the code to actually install the module via Composer using our package_manager module will be able to do this for you(or we can adapt it to make it work.)I think the long term plan for core is pacakager_manager would be it’s own separate module that both project_browser and automatic_updates would depend on

tedbow whenever someone wants to start working on this ping me and I can help. No rush, I just don’t know the stage y’all are at and don’t want to duplicate efforts on this part
leslieg Thanks @tedbow @chrisfromredfin isn’t here yet but I’m sure he’s get in touch with you to discuss. Does anyone else here want to be involved in that conversation?
bsnodgrass (he/him) Great... for those in the know on the technical details, have we solved the filtering issue for project dependencies for the site project browser is installed on? I seem to remember the data didn't get there by itself... or am I mistaken?
tedbow for “project dependencies” do mean the dependencies of the modules the browser will install? package_manager will install all dependencies if that helps
mandclu I'd be happy to help with this
tedbow @mandclu great! let me look at module again and see if we should move stuff into the package_manager sub-module. you could use it as is but you would probably end up duplicating a lot of our  code (edited)
gaurav.kapoor I'd be happy to help as well. Will explore the API/Service provided by Package Manager module and figure out how we can integrate with Project Browser. Not sure about how much time I'll be able to give here, if not with actual implementation, I can help with reviewing and testing.
Rajab Natshah Package Manager @tedbowIt feels like a lex and parser case. With a small script format to work withrequireremoveIt could work on bulk or single requestthe Project Browser .. could work as the UIand the Package Manager .. could work as the executor processer. (edited)
Rajab Natshah They may use the standard automatic_updates script
Rajab Natshah Worked on a custom Automatic Updater on a format like update-config.json
tedbow right now our package_manager module is thin wrapper around https://github.com/php-tuf/composer-stagerbecause our various reasons the updates need to staged first and then copied over in quick operations so the composer command is never directly run on the site. I think project_browser will need this functionality too.i think there will other similarities too but our module is not engineered to for that right now. I am making an issue for this
tedbow I am not sure about remove . will project browser also handle removing modules from the codebase? i.e. composer remove ? (edited)
Rajab Natshah I got the point now .. They should work to gather and speak the same API languageproject_browser ( The UI )automatic_updates ( Automatic  executor)package_manager ( Manual executor )
Rajab Natshah Same as you. Not very sure about composer remove . let us leave that for nowOk thencomposer requirecomposer update  or composer smart-update
tedbow more likeproject_browser (install UI)automatic_updates (update UI - MVP only for core )pacakge_manager ( performs actually composer commands)so automatic_updates may be badly name because it will provide updates via cron and form to manually perform the updates
Rajab Natshah Thank you @tedbow. for clearing .. In the past years, we had to manage that using custom logic.Now seems that we have to switch  and join the new standard Drupal Core of doing thisI like all from php-tufDrupal 10+ will be better managed on that.
chrisfromredfin FWIW I definitely think this is the right architecture, both modules depend on package_manager  as @tedbow deescribes. Maybe someday we'll worry about composer remove  but I think that's definitely a phase II thing (since we could just uninstall the module from UI for a near-comparable experience).
chrisfromredfin Filed issue for this here: #3245770: Create a service to composer install via package_manager from Automatic Updates -- cc @mandclu

Participants:

Rajab Natshah, chrisfromredfin, gaurav.kapoor, Ron Northcutt, bsnodgrass (he/him), thejimbirch, mandclu, tim, leslieg, tedbow

Comments

chrisfromredfin created an issue. See original summary.

chrisfromredfin credited RajabNatshah.

chrisfromredfin credited bsnodgrass.

chrisfromredfin credited gaurav.kapoor.

chrisfromredfin credited leslieg.

chrisfromredfin credited lets4.

chrisfromredfin credited mandclu.

chrisfromredfin credited rlnorthcutt.

chrisfromredfin credited tedbow.

chrisfromredfin credited thejimbirch.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.