Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
I was testing out the module and I noticed that the BrowserController file can be slightly improved by removing usages of services directly. I am still new to this initiative and not sure why it has been implemented like that in the first place. Adding a patch to resolve this simple issue.
Steps to reproduce
Proposed resolution
Remaining tasks
- ✅ File an issue about this project
- ✅ Addition/Change/Update/Fix to this project
- ☐ Testing to ensure no regression
- ☐ Automated unit/functional testing coverage
- ☐ Developer Documentation support on feature change/addition
- ☐ User Guide Documentation support on feature change/addition
- ☐ Code review from 1 Drupal core team member
- ☐ Full testing and approval
- ☐ Credit contributors
- ☐ Review with the product owner
- ☐ Release
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#2 | 3243019-2.patch | 3.1 KB | gaurav.kapoor |
Issue fork project_browser-3243019
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
gaurav.kapoor CreditAttribution: gaurav.kapoor at Axelerant for Drupal India Association commentedComment #3
gaurav.kapoor CreditAttribution: gaurav.kapoor at Axelerant for Drupal India Association commentedComment #4
chrisfromredfinI totally agree that we should be using Dependency Injection instead of reliance on Global Services. I'm not comfortable RTBC'ing this myself, though. Would look to @grasmash or @rlnorthcutt for a review.
Comment #5
gaurav.kapoor CreditAttribution: gaurav.kapoor at Axelerant for Drupal India Association commentedComment #6
chrisfromredfinI'm curious if this still applies given the pretty massive rewrite we've gone through.
Comment #7
tim.plunkettNeeds a reroll (may be worth just redoing), but still needs doing
Comment #10
tim.plunkettFollowing up on the part about
$request
, before the last commit it would try to request/admin/modules/[object%20Object]/drupal-org-proxy/project
instead ofhttp://d8/drupal-org-proxy/project
(lol, yes, my d10 site is still called `d8`)I thought we'd need a whole new test for this, but it actually is a straightforward addition to ProjectBrowserUiTest, effectively undoing/re-fixing #3250003: Unbreak test failures
Comment #11
narendraRMarking as RTBC.
Comment #13
tim.plunkettThanks! Merged