Array to string conversion notice when embedding a Media file [#3106808]

There is an error when embedding a Media file into a text area:
Notice: Array to string conversion in Drupal\Core\Template\AttributeArray->__toString() (line 73 of core/lib/Drupal/Core/Template/AttributeArray.php).
I have debugged the $variables['attributes'] in template_preprocess_entity_embed_container() and there seems to be an array for data-entity-embed-display-settings item:

array
(
    [data-embed-button] => file_media_browser
    [data-entity-embed-display] => entity_reference:entity_reference_file_media_decs
    [data-entity-embed-display-settings] => array
    (
        [entity] => 
        [attributes] => array
            (
                [data-entity-type] => media
                [data-entity-uuid] => 61c33e8a-c950-44f0-aee3-3f1415cf51d5
                [data-langcode] => en
                [data-entity-embed-display] => entity_reference:entity_reference_file_media_decs
                [data-embed-button] => file_media_browser
            )

        [use_description_as_link_text] => 1
        [description] => 
    )

    [data-entity-type] => media
    [data-entity-uuid] => 61c33e8a-c950-44f0-aee3-3f1415cf51d5
    [data-langcode] => en
    [class] => array
    (
        [0] => embedded-entity
    )
)

The same values seem to be in the root level of the array already, so it seems they are not needed at all. In HTML the attribute is rendered as data-entity-embed-display-settings="Array 1".

This doesn't seem to happen for example for Media image, where the element is an empty array which also suggests that they are not needed:

array
(
    [data-align] => left
    [data-embed-button] => image_media_browser
    [data-entity-embed-display] => view_mode:media.embedded_media
    [data-entity-embed-display-settings] => array
        (
        )

    [data-entity-type] => media
    [data-entity-uuid] => 94627856-7a20-4f01-b4f7-bb7d2885b6e3
    [data-langcode] => en
    [class] => array
        (
            [0] => embedded-entity
        )
)

Comment	File	Size	Author
#23	array-to-string-3106808-23.patch	988 bytes	arthur.baghdasar
#22	array-to-string-3106808-20.patch	1.07 KB	arthur.baghdasar
#18	array-to-string-3106808-18.patch	1.26 KB	dzinkevich
#7	array-to-string-3106808-7.patch	1.06 KB	dalinian
#4	array-to-string-3106808-4.patch	1.05 KB	drewble

Issue fork entity_embed-3106808

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3106808-array-to-string changes, plain diff MR !11
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

16 January 2020 at 11:03

mErilainen created an issue. See original summary.

Comment #2

merilainen commented 16 January 2020 at 11:04

Issue summary:

View changes

Comment #3

merilainen commented 16 January 2020 at 13:02

There is a patch at https://www.drupal.org/project/entity_embed/issues/3069448#comment-13234764 which uses json_encode for the display settings array which fixes the error, but I don't think it's the right approach. Also breaks tests.

Comment #4

drewble commented 13 May 2020 at 05:38

Status	File	Size
new	array-to-string-3106808-4.patch	1.05 KB

I was having the same issue. Determined that it was related to any values in the $variables['attributes'] array that was a non-JSON-encoded array. This patch ensures that all array children of $variables['attributes'] are JSON encoded.

Comment #5

stewest

Wellington

commented 22 May 2020 at 08:53

I testes Patch 4 https://www.drupal.org/project/entity_embed/issues/3106808#comment-13611520 and it works.

Comment #6

dalinian commented 26 May 2020 at 13:40

Patch #4 causes embedded image styling to fail. It produces:

<div class='["align-right","embedded-entity"]

instead of

<div class="align-right embedded-entity"

Comment #7

dalinian commented 26 May 2020 at 14:32

Status	File	Size
new	array-to-string-3106808-7.patch	1.06 KB

Here's a work around for the problem of the class attribute conversion failing on embedded images. In this case, I'm just not applying json_encoding to any attribute key named 'class'. This works for the specific case of the class attribute. However, I suspect there are other attributes that get formatted incorrectly due to json encoding.

Comment #8

wjackson commented 25 August 2020 at 17:08

Status:

Active

» Reviewed & tested by the community

Patch #7 resolve the issue on our end. Thank you!

Comment #9

25 August 2020 at 17:22

Status:

Reviewed & tested by the community

» Needs work

The last submitted patch, 7: array-to-string-3106808-7.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Comment #10

jaydee1818 commented 16 December 2020 at 07:28

Patch #7 also squashed the notification for me.

Comment #11

bramdriesen

he/him

Dutch

Belgium 🇧🇪🇪🇺

commented 2 February 2022 at 12:40

Is this still relevant?

Comment #12

agiraud commented 29 March 2022 at 15:44

I still have the PHP notice with the current module version. The patch in #7 fixed it.

Comment #13

et.cetera commented 10 June 2022 at 16:38

I have this notice because the svg_image module adds width and height as array in formatter settings

https://git.drupalcode.org/project/svg_image/-/blob/8.x-1.x/src/Plugin/F...

when using embed. This is also described here:

https://www.drupal.org/project/svg_image/issues/3116124

Patch #7 fixes the notice.

Comment #14

jmcintyre commented 18 August 2022 at 20:01

I'm seeing this issue upon updating a site from Drupal 9.3.19 to 9.4.5. The patch in #7 resolved it in my local environment but I haven't deployed it upstream yet—is there a reason other than coding standards this hasn't been rolled into a release?

Comment #15

bramdriesen

he/him

Dutch

Belgium 🇧🇪🇪🇺

commented 19 August 2022 at 07:00

The fact 4 tests are failing?

Comment #16

jmcintyre commented 19 August 2022 at 13:11

Uh, sorry @BramDriesen... I obviously didn't read the actual test result.

Comment #17

bramdriesen

he/him

Dutch

Belgium 🇧🇪🇪🇺

commented 19 August 2022 at 17:42

No problem :-) ~~happy to merge this once the tests are passing again.~~ (no idea why I said that, guess I mixed up issue queues 😅 I'm not even a maintainer of the entity_embed module)

Comment #18

dzinkevich commented 26 August 2022 at 09:53

Status	File	Size
new	array-to-string-3106808-18.patch	1.26 KB

Re-roll of #7 to work with entity_embed v 8.1.2

Comment #19

nelo_drup commented 28 August 2022 at 23:09

When using the patch everything works fine but the images uploaded previously are damaged but only when viewing them with the module
https://www.drupal.org/project/image_browser
and here you can see how the thumbnails are damaged
View error

Comment #20

31 August 2022 at 06:39

arthur.baghdasar made their first commit to this issue’s fork.

Comment #21

31 August 2022 at 06:42

arthur.baghdasar opened merge request !11

Comment #22

arthur.baghdasar commented 31 August 2022 at 06:44

Status	File	Size
new	array-to-string-3106808-20.patch	1.07 KB

Comment #23

arthur.baghdasar commented 31 August 2022 at 07:44

Status	File	Size
new	array-to-string-3106808-23.patch	988 bytes

1 file was hidden/shown/deleted

Status	File	Size
hidden	array-to-string-3106808-20.patch	1.07 KB

Comment #24

arthur.baghdasar commented 31 August 2022 at 08:01

This is still failing some tests. Though the patch fixes the issue on our end.

Comment #25

nelo_drup commented 1 September 2022 at 00:40

#23 The patch array-to-string-3106808-23.patch works fine you don't see that error anymore, from the comment #19

Comment #26

6 October 2022 at 12:39

ctlopez made their first commit to this issue’s fork.

Comment #27

ctlopez commented 6 October 2022 at 19:07

Status:

Needs work

» Needs review

I am marking this ready for review as the patch provided works and applies cleanly, and the tests now pass.

Comment #28

pflora commented 7 October 2022 at 01:23

Status:

Needs review

» Reviewed & tested by the community

I was able to replicate the error posted in the IS, and after applying the changes made by the MR no errors were shown after embedding a Media file. I've also ran the tests and nothing seems to be broken. No new CS errors were added with the changes, so i think this is good to be moved to RTBC.

Comment #29

bramdriesen

he/him

Dutch

Belgium 🇧🇪🇪🇺

commented 7 October 2022 at 06:57

Had a look through the code changes, looks good. RTBC +1

Comment #30

14 October 2022 at 15:40

Dave Reid made their first commit to this issue’s fork.

Comment #31

dave reid

he/him

English

Nebraska USA

commented 14 October 2022 at 15:57

Comment #32

14 October 2022 at 15:58

Dave Reid committed 4517a73 on 8.x-1.x authored by arthur.baghdasar

Issue #3106808 by arthur.baghdasar, ctlopez, dalinian, Dave Reid,...

Comment #33

dave reid

he/him

English

Nebraska USA

commented 14 October 2022 at 15:58

Status:

Reviewed & tested by the community

» Fixed

Merged to 8.x-1.x and will release today. Thank you everyone!

Comment #34

28 October 2022 at 15:59

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Array to string conversion notice when embedding a Media file

Issue fork entity_embed-3106808

Comments

Related issues