Closed (fixed)
Project:
Address
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
25 Oct 2019 at 15:29 UTC
Updated:
29 Nov 2019 at 04:26 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
czigor commentedComment #3
bojanz commentedThis is what we need to fix:
Comment #4
czigor commentedToken dev should fix the deprecation notice.
Comment #5
bojanz commentedCountryNameTokenTest needs the fix from https://www.drupal.org/node/3041703
That will resolve:
Comment #6
dwwWheee! Glad I documented a solution to that which works for 8.7.x, too. ;)
Comment #7
dwwComment #8
dwwComment #9
dwwArgh, once again, the thing we need to use isn't even available in 8.7.x. :( Ugh.
Screw this. We can be Ready For D9(tm) when 8.7.x is EOL. Until then, I have better things to do with my time than fight these uphill and frustrating battles.
Comment #10
dww(whoops, I missed text areas in #8 since the summary was empty. Stub for later
Comment #11
dwwGuess I'm a glutton for punishment and I can't stop myself. ;)
Comment #12
dwwRe-queued #11 on 8.8.x and 8.9.x now that #3089688-11: Make the build pass on Drupal 8.8 is fixed again.
Comment #13
dwwAlas,
function_exists()doesn't do exactly what I thought.is_callable()seems to work locally for what I'm trying to do here.Comment #14
dww8.6.x had what looks like a random fail:
Re-queued that.
Assuming it passes, I'd like to revert the change to composer.json here that's requiring core
^8.7. No need to force that until 8.6.x is actually EOL. Or really, until we start doing things that don't exist in 8.6.x. So far, it doesn't seem like that's necessary, so let's not put folks stuck on 8.6.x for other reasons out of luck.Comment #15
dwwIndeed, we're still good with 8.6.x, so I reverted that part of the composer.json change.
I also opened #3093193: Require Drupal 8.8 as a target for @see @todo comments to clean this stuff up. ;)
Pretty sure this is RTBC, but I'll queue it for a final round of testing on All The Branches(tm).
Comment #17
dwwCommitted #15 and pushed to 8.x-1.x.
Comment #18
bojanz commentedThanks, dww!
Comment #20
kristen polPer a Slack discussion with Gábor Hojtsy regarding usage of D9 tags (Drupal 9, Drupal 9 compatibility, Drupal 9 readiness, etc.), "Drupal 9 compatibility" should be used for contributed projects that need updating and "Drupal 9" was the old tag for D8 issues before the D9 branch was ready. Doing tag cleanup here based on that discussion.
Comment #21
chris matthews commented