We just need the path_alias fix in Kernel tests:

   protected function setUp() {
     parent::setUp();
+
+    if (\Drupal::entityTypeManager()->hasDefinition('path_alias')) {
+      $this->installEntitySchema('path_alias');
+    }

Comments

bojanz created an issue. See original summary.

bojanz’s picture

Status: Active » Needs review
StatusFileSize
new1.2 KB

Let's try this.

bojanz’s picture

Status: Needs review » Fixed

We're green!

  • bojanz committed b33dc1f on 8.x-1.x
    Issue #3089688 by bojanz: Make the build pass on Drupal 8.8
    
dww’s picture

Yay, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

dww’s picture

Status: Closed (fixed) » Needs work

Actually, it seems tests now fail on 8.8.x because of this. :/

@see https://www.drupal.org/pift-ci-job/1465611

I don't fully understand why we're doing this here, but it seems to break things. I suspect because of #3084983: Move all the code related to path aliases to a new (required) "path_alias" module

But hrmph, reverting this commit locally doesn't get tests to pass on 8.8.x. No time to dig deeper right now, but re-opening cuz our tests are failing on 8.8.x.

dww’s picture

Status: Needs work » Needs review
StatusFileSize
new778 bytes

This seems to work locally on both 8.7.x and 8.8.x. Yay for adding more technical debt to contrib so core can remove its own! 🤦‍♂️

dww’s picture

Related issues: +#3093130: Between alpha1 and X.Y.0 official \Drupal::VERSION should not be "8.8.0-dev" since it doesn't work for Semver::satisfies()
StatusFileSize
new893 bytes
new1022 bytes

This is a safer way to handle version_compare() for the current state of things. :/

@see #3093130: Between alpha1 and X.Y.0 official \Drupal::VERSION should not be "8.8.0-dev" since it doesn't work for Semver::satisfies() for more.

  • dww committed 1530373 on 8.x-1.x
    Issue #3089688 by dww: Make the build pass on Drupal 8.8 after 3084983.
    
dww’s picture

Status: Needs review » Fixed

Since that's green on all branches, I committed #9 and pushed to 8.x-1.x.

Back to fixed.

Phew,
-Derek

dww’s picture

Status: Fixed » Needs review
StatusFileSize
new1.05 KB

Well, yay! In response to my evil, ugly-workaround, we already fixed 8.8.x about this. ;)

#3093257: Install path_alias by default in kernel tests to minimize the impact on contrib tests supporting 8.7.x

So maybe we can rip this back out, after all. However, there was talk of adding a deprecation warning about it. :( I'm trying to keep that from happening in 8.8.x, and only in 8.9.x.

Meanwhile, let's confirm the bot is happy now without #9.

dww’s picture

Status: Needs review » Postponed
dww’s picture

Status: Postponed » Needs review

#3093294: Specify the $defaultTheme property in all functional tests is now in 8.x-1.x, so 8.8.x tests should pass again. Let's see.

  • dww committed 1fd5c42 on 8.x-1.x
    Issue #3089688 by dww: Simplify passing builds on Drupal 8.8 after [...
dww’s picture

Status: Needs review » Fixed

Based on Slack feedback from catch and alexpott, we all agree that #3093333: Consider a deprecation notice if path_alias is needed for tests but not installed explicitly is only going to happen in 8.9.x (if at all). So we should be safe to remove the cruft here. Phew!

Committed and pushed to 8.x-1.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

chris matthews’s picture