Drupal 9 Deprecated Code Report

Thanks for putting this together!

Let's leave it it postponed for now, we'll come back to it later.

Here are 44 fixes for the tests. Thanks!

I am not sure what happened to that patch.

Patch at #4 brings it down to 25 errors.

 ------ ------------------------------------------------------------------------------------------------ 
  Line   metatag_facebook/src/Plugin/metatag/Group/Facebook.php                                          
 ------ ------------------------------------------------------------------------------------------------ 
         Class Drupal\facebook\Plugin\metatag\Group\Facebook was not found while trying to analyse it -  
         autoloading is probably not configured properly.                                                
 ------ ------------------------------------------------------------------------------------------------ 

 ------ --------------------------------------------------------------------------------------------------- 
  Line   metatag_mobile/src/Plugin/metatag/Group/AndroidMobile.php                                          
 ------ --------------------------------------------------------------------------------------------------- 
         Class Drupal\metatag_mobile\Plugin\metatag\Group\GroupBase not found and could not be autoloaded.  
 ------ --------------------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------------------------------- 
  Line   metatag_mobile/src/Plugin/metatag/Group/AppleMobile.php                                            
 ------ --------------------------------------------------------------------------------------------------- 
         Class Drupal\metatag_mobile\Plugin\metatag\Group\GroupBase not found and could not be autoloaded.  
 ------ --------------------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------------------------------- 
  Line   metatag_mobile/src/Plugin/metatag/Group/Mobile.php                                                 
 ------ --------------------------------------------------------------------------------------------------- 
         Class Drupal\metatag_mobile\Plugin\metatag\Group\GroupBase not found and could not be autoloaded.  
 ------ --------------------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------------------------------- 
  Line   metatag_mobile/src/Plugin/metatag/Group/WindowsMobile.php                                          
 ------ --------------------------------------------------------------------------------------------------- 
         Class Drupal\metatag_mobile\Plugin\metatag\Group\GroupBase not found and could not be autoloaded.  
 ------ --------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------- 
  Line   src/Command/GenerateGroupCommand.php                                                                 
 ------ ----------------------------------------------------------------------------------------------------- 
  106    Call to deprecated method confirmGeneration() of class Drupal\metatag\Command\GenerateGroupCommand.  
 ------ ----------------------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------------------------------- 
  Line   src/Command/GenerateTagCommand.php                                                                 
 ------ --------------------------------------------------------------------------------------------------- 
  140    Call to deprecated method confirmGeneration() of class Drupal\metatag\Command\GenerateTagCommand.  
 ------ --------------------------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------------------- 
  Line   src/Plugin/GraphQL/Scalars/MetatagScalar.php                                                  
 ------ ---------------------------------------------------------------------------------------------- 
         Class Drupal\graphql\Plugin\GraphQL\Scalars\Internal\StringScalar not found and could not be  
         autoloaded.                                                                                   
 ------ ---------------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Functional/MetatagHelperTrait.php (in context of class Drupal\Tests\metatag\Functional\DefaultTags)  
 ------ --------------------------------------------------------------------------------------------------------------- 
  118    Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase.                                 
  151    Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase.                                 
 ------ --------------------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Functional/MetatagHelperTrait.php (in context of class Drupal\Tests\metatag\Functional\DisabledDefaultTags)  
 ------ ----------------------------------------------------------------------------------------------------------------------- 
  118    Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase.                                         
  151    Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase.                                         
 ------ ----------------------------------------------------------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Functional/MetatagHelperTrait.php (in context of class Drupal\Tests\metatag\Functional\EnsureDevelWorks)  
 ------ -------------------------------------------------------------------------------------------------------------------- 
  118    Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase.                                      
  151    Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase.                                      
 ------ -------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------ 
  Line   tests/src/Functional/MetatagHelperTrait.php (in context of class Drupal\Tests\metatag\Functional\NodeJsonOutput)  
 ------ ------------------------------------------------------------------------------------------------------------------ 
  118    Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase.                                    
  151    Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase.                                    
 ------ ------------------------------------------------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Functional/MetatagHelperTrait.php (in context of class Drupal\Tests\metatag\Functional\NodeTranslation)  
 ------ ------------------------------------------------------------------------------------------------------------------- 
  118    Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase.                                     
  151    Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase.                                     
 ------ ------------------------------------------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Functional/MetatagHelperTrait.php (in context of class Drupal\Tests\metatag\Functional\RemoveCoreMetaTags)  
 ------ ---------------------------------------------------------------------------------------------------------------------- 
  118    Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase.                                        
  151    Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase.                                        
 ------ ---------------------------------------------------------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Functional/MetatagHelperTrait.php (in context of class Drupal\Tests\metatag_views\Functional\MetatagViewsBasicsTest)  
 ------ -------------------------------------------------------------------------------------------------------------------------------- 
  118    Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase.                                                  
  151    Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase.                                                  
 ------ -------------------------------------------------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Functional/MetatagHelperTrait.php (in context of class Drupal\metatag_page_manager\Tests\Functional\MetatagPageManagerTest)  
 ------ --------------------------------------------------------------------------------------------------------------------------------------- 
  118    Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase.                                                         
  151    Call to deprecated method assertEqual() of class Drupal\Tests\BrowserTestBase.                                                         
 ------ --------------------------------------------------------------------------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Functional/SchemaMetatagTest.php                                                              
 ------ -------------------------------------------------------------------------------------------------------- 
         Class Drupal\Tests\schema_web_page\Functional\SchemaWebPageTest not found and could not be autoloaded.  
 ------ -------------------------------------------------------------------------------------------------------- 

                                                                                                                
 [ERROR] Found 25 errors                                                                                        
                                                                                                                

I updated a few ones, passing from 39 errors to 34...

drupal-check modules/contrib/metatag
400/400 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

[ERROR] Found 34 errors

drupal-check modules/contrib/metatag
400/400 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

[OK] No errors

I started with the patch in #12 and fixed the remaining items from the deprecation check I could find. Locally, the only errors I see now from drupal-check are classes which it is unable to autoload. Tests are passing locally.

After applying patch #13

drupal-check modules/contrib/metatag
400/400 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ --------------------------------------------
Line metatag_app_links/src/Tests/MetatagAppLinksTagsTest.php
------ --------------------------------------------
Class Drupal\Tests\metatag_app_links\Functional\MetatagAppLinksTagsTest was not found while trying to analyse it - autoloading is probably not configured properly.
------ --------------------------------------------

------ --------------------------------------------
Line metatag_dc/src/Tests/MetatagDublinCoreTagsTest.php
------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------
Class Drupal\Tests\metatag_dc\Functional\MetatagDublinCoreTagsTest was not found while trying to analyse it - autoloading is probably not configured properly.
------ --------------------------------------------

------ --------------------------------------------
Line metatag_dc_advanced/src/Tests/MetatagDublinCoreAdvancedTagsTest.php
------ --------------------------------------------
Class Drupal\Tests\metatag_dc_advanced\Functional\MetatagDublinCoreAdvancedTagsTest was not found while trying to analyse it - autoloading is probably not configured properly.
------ -------------------------------------------

------ -------------------------------------------
Line metatag_facebook/src/Tests/MetatagFacebookTagsTest.php
------ --------------------------------------------------------------------------------------------------------------------------------------------------------------------
Class Drupal\Tests\metatag_facebook\Functional\MetatagFacebookTagsTest was not found while trying to analyse it - autoloading is probably not configured properly.
------ -------------------------------------------

------ -------------------------------------------
Line metatag_favicons/src/Tests/MetatagFaviconsTagsTest.php
------ -------------------------------------------
Class Drupal\Tests\metatag_favicons\Functional\MetatagFaviconsTagsTest was not found while trying to analyse it - autoloading is probably not configured properly.
------ -------------------------------------------

------ -------------------------------------------
Line metatag_google_cse/src/Tests/MetatagGoogleCSETagsTest.php
------ -------------------------------------------
Class Drupal\Tests\metatag_google_cse\Functional\MetatagGoogleCSETagsTest was not found while trying to analyse it - autoloading is probably not configured properly.
------ -------------------------------------------

------ -------------------------------------------
Line metatag_google_plus/src/Tests/MetatagGooglePlusTagsTest.php
------ -------------------------------------------
Class Drupal\Tests\metatag_google_plus\Functional\MetatagGooglePlusTagsTest was not found while trying to analyse it - autoloading is probably not configured properly.
------ -------------------------------------------

------ -------------------------------------------
Line metatag_hreflang/src/Tests/MetatagHreflangTagsTest.php
------ -------------------------------------------
Class Drupal\Tests\metatag_hreflang\Functional\MetatagHreflangTagsTest was not found while trying to analyse it - autoloading is probably not configured properly.
------ -------------------------------------------

------ -------------------------------------------
Line metatag_mobile/src/Tests/MetatagMobileTagsTest.php
------ -------------------------------------------
Class Drupal\Tests\metatag_mobile\Functional\MetatagMobileTagsTest was not found while trying to analyse it - autoloading is probably not configured properly.
------ -------------------------------------------

------ -------------------------------------------
Line metatag_open_graph/src/Tests/MetatagOpenGraphTagsTest.php
------ -------------------------------------------
Class Drupal\Tests\metatag_open_graph\Functional\MetatagOpenGraphTagsTest was not found while trying to analyse it - autoloading is probably not configured properly.
------ -------------------------------------------

------ -------------------------------------------
Line metatag_open_graph_products/src/Tests/MetatagOpenGraphProductsTagsTest.php
------ -------------------------------------------
Class Drupal\Tests\metatag_open_graph_products\Functional\MetatagOpenGraphProductsTagsTest was not found while trying to analyse it - autoloading is probably not configured properly.
------ -------------------------------------------

------ -------------------------------------------
Line metatag_pinterest/src/Tests/MetatagPinterestTagsTest.php
------ -------------------------------------------
Class Drupal\Tests\metatag_pinterest\Functional\MetatagPinterestTagsTest was not found while trying to analyse it - autoloading is probably not configured properly.
------ -------------------------------------------

------ -------------------------------------------
Line metatag_twitter_cards/src/Tests/MetatagTwitterCardsTagsTest.php
------ -------------------------------------------
Class Drupal\Tests\metatag_twitter_cards\Functional\MetatagTwitterCardsTagsTest was not found while trying to analyse it - autoloading is probably not configured properly.
------ -------------------------------------------

------ -------------------------------------------
Line metatag_verification/src/Tests/MetatagVerificationTagsTest.php
------ -------------------------------------------
Class Drupal\Tests\metatag_verification\Functional\MetatagVerificationTagsTest was not found while trying to analyse it - autoloading is probably not configured properly.
------ -------------------------------------------

------ -------------------------------------------
Line src/MetatagServiceProvider.php
------ -------------------------------------------
Class Drupal\metatag\MetatagServiceProvider was not found while trying to analyse it - autoloading is probably not configured properly.
------ -------------------------------------------

------ -------------------------------------------
Line tests/src/Kernel/MetatagSerializationTest.php
------ -------------------------------------------
60 Call to deprecated method setExpectedException() of class Drupal\KernelTests\KernelTestBase:
in drupal:8.8.0 and is removed from drupal:9.0.0.
Backward compatibility for PHPUnit 4 will no longer be supported.
------ -------------------------------------------

[ERROR] Found 16 errors

Interesting. I did not get that result from drupal-check locally. The deprecated method that shows up in your output is the thing that is causing tests to fail. I am using phpunit 6.5.14 locally and saw the same failure in tests that the bot shows for the patch in #12. I don't really understand why it appears as the method expects a string as the parameter. --

There was 1 error:

1) Drupal\Tests\metatag\Kernel\MetatagSerializationTest::testMetatagDeserialization
ReflectionException: Class The generic FieldItemNormalizer cannot denormalize string values for "value" properties of the "field_test" field (field item class: Drupal\metatag\Plugin\Field\FieldType\MetatagFieldItem). does not exist

ERRORS!
Tests: 96, Assertions: 1939, Errors: 1, Skipped: 2.

I have replaced the PHPUnit 4 compatibility code with what appears to be the appropriate method calls. expectException is expecting a *class* not the message itself.

It seems that all the autoloading issues are because of the incorrect namespace.

For example -

------ --------------------------------------------
Line metatag_app_links/src/Tests/MetatagAppLinksTagsTest.php
------ --------------------------------------------
Class Drupal\Tests\metatag_app_links\Functional\MetatagAppLinksTagsTest was not found while trying to analyze it - autoloading is probably not configured properly.
------ --------------------------------------------

The namespace in "MetatagAppLinksTagsTest" class is "namespace Drupal\metatag_app_links\Tests" which looks not correct.

Just not sure if that's in scope of this issue or deserve a new issue.

For all errors, we need to add the folder with name Functional (https://prnt.sc/pbp91n) or update namespace but I don't see the new folder in diff or patch. How we can add this folder?

Some of the tests were updated in #2820214 and #3073826, but it seems we missed the tests in submodules. Would you mind moving the test changes into a new issue and we can commit it separately? Thank you!

@DamienMcKenna, I've created #3084547: Move submodule tests in /tests/Functional folder for that. #19 will need a re-roll afterwards.

After issue #3084547 we can use this patch

Thanks everyone. I'm planning on working on this next week.

One question I have is: what would these changes make in terms of core requirements - would it still work with 8.5 or 8.6?

@DamienMcKenna we need to push #3084547 first and then retest my last patch and then we will know how many problems we have

I'm going to check this at DrupalCon Amsterdam 2019.

The patch #22 doesn't apply against latest 1.x-dev so I'm going to try re-rolling #19.

Here's a re-roll of #19 against latest 8.x-1.x since #22 won't apply.

I'm getting 15 errors with the latest patch applied again 8.x-1.x but they are all related to autoloader.

~/.config/composer/vendor/bin/drupal-check -d -- .
 411/411 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ------------------------------------------------------------------------------------------------------------------------------------ 
  Line   metatag_dc_advanced/tests/src/Functional/MetatagDublinCoreAdvancedTagsTest.php                                                      
 ------ ------------------------------------------------------------------------------------------------------------------------------------ 
         Class Drupal\metatag_dc_advanced\Tests\MetatagDublinCoreAdvancedTagsTest was not found while trying to analyse it - autoloading is  
         probably not configured properly.                                                                                                   
 ------ ------------------------------------------------------------------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------------------------------------------------------------------ 
  Line   metatag_facebook/tests/src/Functional/MetatagFacebookTagsTest.php                                                                   
 ------ ------------------------------------------------------------------------------------------------------------------------------------ 
         Class Drupal\metatag_facebook\Tests\MetatagFacebookTagsTest was not found while trying to analyse it - autoloading is probably not  
         configured properly.                                                                                                                
 ------ ------------------------------------------------------------------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------------------------------------------------------------------ 
  Line   metatag_favicons/tests/src/Functional/MetatagFaviconsTagsTest.php                                                                   
 ------ ------------------------------------------------------------------------------------------------------------------------------------ 
         Class Drupal\metatag_favicons\Tests\MetatagFaviconsTagsTest was not found while trying to analyse it - autoloading is probably not  
         configured properly.                                                                                                                
 ------ ------------------------------------------------------------------------------------------------------------------------------------ 

 ------ ----------------------------------------------------------------------------------------------------------------------------------- 
  Line   metatag_google_cse/tests/src/Functional/MetatagGoogleCSETagsTest.php                                                               
 ------ ----------------------------------------------------------------------------------------------------------------------------------- 
         Class Drupal\metatag_google_cse\Tests\MetatagGoogleCSETagsTest was not found while trying to analyse it - autoloading is probably  
         not configured properly.                                                                                                           
 ------ ----------------------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------------------- 
  Line   metatag_google_plus/tests/src/Functional/MetatagGooglePlusTagsTest.php                                                               
 ------ ------------------------------------------------------------------------------------------------------------------------------------- 
         Class Drupal\metatag_google_plus\Tests\MetatagGooglePlusTagsTest was not found while trying to analyse it - autoloading is probably  
         not configured properly.                                                                                                             
 ------ ------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------------------ 
  Line   metatag_hreflang/tests/src/Functional/MetatagHreflangTagsTest.php                                                                   
 ------ ------------------------------------------------------------------------------------------------------------------------------------ 
         Class Drupal\metatag_hreflang\Tests\MetatagHreflangTagsTest was not found while trying to analyse it - autoloading is probably not  
         configured properly.                                                                                                                
 ------ ------------------------------------------------------------------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------------------------------------------------------------------- 
  Line   metatag_mobile/src/Plugin/metatag/Tag/AlternateHandheld.php                                                                          
 ------ ------------------------------------------------------------------------------------------------------------------------------------- 
         Class Drupal\metatag_mobile\Plugin\metatag\Tag\alternateHandheld was not found while trying to analyse it - autoloading is probably  
         not configured properly.                                                                                                             
 ------ ------------------------------------------------------------------------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------------------------------------------------------------- 
  Line   metatag_mobile/tests/src/Functional/MetatagMobileTagsTest.php                                                                   
 ------ -------------------------------------------------------------------------------------------------------------------------------- 
         Class Drupal\metatag_mobile\Tests\MetatagMobileTagsTest was not found while trying to analyse it - autoloading is probably not  
         configured properly.                                                                                                            
 ------ -------------------------------------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------------------------------- 
  Line   metatag_open_graph/tests/src/Functional/MetatagOpenGraphTagsTest.php                                                               
 ------ ----------------------------------------------------------------------------------------------------------------------------------- 
         Class Drupal\metatag_open_graph\Tests\MetatagOpenGraphTagsTest was not found while trying to analyse it - autoloading is probably  
         not configured properly.                                                                                                           
 ------ ----------------------------------------------------------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------------------------------------------------- 
  Line   metatag_open_graph_products/tests/src/Functional/MetatagOpenGraphProductsTagsTest.php                                       
 ------ ---------------------------------------------------------------------------------------------------------------------------- 
         Class Drupal\metatag_open_graph_products\Tests\MetatagOpenGraphProductsTagsTest was not found while trying to analyse it -  
         autoloading is probably not configured properly.                                                                            
 ------ ---------------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------------------- 
  Line   metatag_page_manager/tests/src/Functional/MetatagPageManagerTest.php                                                                 
 ------ ------------------------------------------------------------------------------------------------------------------------------------- 
         Class Drupal\metatag_page_manager\Tests\Functional\MetatagPageManagerTest was not found while trying to analyse it - autoloading is  
         probably not configured properly.                                                                                                    
 ------ ------------------------------------------------------------------------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------------------------------------------------------------- 
  Line   metatag_twitter_cards/tests/src/Functional/MetatagTwitterCardsTagsTest.php                                                      
 ------ -------------------------------------------------------------------------------------------------------------------------------- 
         Class Drupal\metatag_twitter_cards\Tests\MetatagTwitterCardsTagsTest was not found while trying to analyse it - autoloading is  
         probably not configured properly.                                                                                               
 ------ -------------------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------------- 
  Line   metatag_verification/tests/src/Functional/MetatagVerificationTagsTest.php                                                      
 ------ ------------------------------------------------------------------------------------------------------------------------------- 
         Class Drupal\metatag_verification\Tests\MetatagVerificationTagsTest was not found while trying to analyse it - autoloading is  
         probably not configured properly.                                                                                              
 ------ ------------------------------------------------------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------------------------------------- 
  Line   src/Plugin/GraphQL/Scalars/MetatagScalar.php                                                                    
 ------ ---------------------------------------------------------------------------------------------------------------- 
         Class Drupal\graphql\Plugin\GraphQL\DataProducer\DataProducerPluginBase not found and could not be autoloaded.  
 ------ ---------------------------------------------------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Functional/SchemaMetatagTest.php                                                              
 ------ -------------------------------------------------------------------------------------------------------- 
         Class Drupal\Tests\schema_web_page\Functional\SchemaWebPageTest not found and could not be autoloaded.  
 ------ -------------------------------------------------------------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 15 errors                                                                                                
                                                                                                                        

I've managed to fix 14 of 15 issues from the above. The last one I believe is a soft module dependency so could be safely skipped.
I'm not entirely sure but it's possible that some unit tests weren't ran at all due to incorrect namespaces; at least one of them were referencing a private method of the parent class so obviously it should have been failing.

~/.config/composer/vendor/bin/drupal-check -d -- .
 411/411 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ---------------------------------------------------------------------------------------------------------------- 
  Line   src/Plugin/GraphQL/Scalars/MetatagScalar.php                                                                    
 ------ ---------------------------------------------------------------------------------------------------------------- 
         Class Drupal\graphql\Plugin\GraphQL\DataProducer\DataProducerPluginBase not found and could not be autoloaded.  
 ------ ---------------------------------------------------------------------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 1 error                                                                                                  
                                                                                                                        

Attaching the patch and interdiff.

Needs Review.

2 maintainers: please credit @valthebald for his assistance at the code sprint.

Thanks for working on this.

This error is weird:

Class Drupal\metatag_verification\Tests\MetatagVerificationTagsTest was not found while trying to analyse it - autoloading is probably not configured properly.

MetatagVerificationTagsTest.php is in the correct directory, it extends Drupal\Tests\metatag\Functional/MetatagTagsTestBase which extends Drupal\Tests\BrowserTestBase, so it should work?

These two suggest the dependent modules weren't downloaded locally:

• Class Drupal\graphql\Plugin\GraphQL\DataProducer\DataProducerPluginBase not found and could not be autoloaded.
• Class Drupal\Tests\schema_web_page\Functional\SchemaWebPageTest not found and could not be autoloaded.

Hi @DamienMcKenna,
The namespace should have been Drupal\Tests\metatag_verification\Functional and not Drupal\metatag_verification\Tests. Note the 'Functional' is missing and 'Tests' not in correct place.

This is already fixed in #30, please see the interdiff and the latest drupal-check report.

I was writing that while you were working on the improvements; thanks for all of your work on this!

Some of the changes in #30 are just fixes that haven't shown up yet, e.g namespace changes and typos, could those please be split off into their own issue so this one is just focused on the upgrade? Thanks.

1. +++ b/metatag.install
   @@ -274,7 +274,7 @@ function metatag_update_8103() {
    
      // Apply all entity definition changes.
   -  \Drupal::entityDefinitionUpdateManager()->applyUpdates();
   +  \Drupal::entityDefinitionUpdateManager()->getChangeList();
    
      // 2. Extract Metatag field defaults.
      $entity_info = $entity_manager->getDefinitions();
   @@ -364,7 +364,7 @@ function metatag_update_8105() {
   
   @@ -364,7 +364,7 @@ function metatag_update_8105() {
     * Add the metatag_defaults config entity to the site.
     */
    function metatag_update_8106() {
   -  \Drupal::entityDefinitionUpdateManager()->applyUpdates();
   +  \Drupal::entityDefinitionUpdateManager()->getChangeList();
    }
    
    /**
   

   This change is not correct, getChangeList() only returns changes, it doesn't *do* anything. applyUpdates() has been removed without replacement because for the most part, it was misused, here too.

   This should never have been done like this as you have no control over what changes are applied. This could mess things up badly as it would have tried to apply changes that it wouldn't have been able to.

   Not sure about the first, but 8106() should have been something like rest_update_8201() and explicitly install that entity type (FWIW, I don't understand why we even track config entity types there, that makes no sense at all).

   One option would be to just cut off update functions up to and including 8106 and add a hook_update_last_removed(). It's technically already too late for that, because it would fail for someone trying to update from an older version to the latest on Drupal 8.7+, but this update was added 3 years ago, so hopefully nobody has a version that outdated anymore or they'll likely have much worse issues than this ;)

2. +++ b/metatag_facebook/src/Plugin/metatag/Group/Facebook.php
   @@ -1,6 +1,6 @@
    
   -namespace Drupal\facebook\Plugin\metatag\Group;
   +namespace Drupal\metatag_facebook\Plugin\metatag\Group;
    
   

   Agreed that the namespace and use fixes on actual classes like these would make sense as a separate issue, a but surprised that this isn't caught by tests.. I assume these kind of group plugins are never actually instantiated, and the discovery still works as it doesn't include the files.

#30 shows that this does indeed fail on 8.6, so no matter when exactly this will be committed, I would recommend to add a core dependency to metatag.info.yml, users might still try to apply this update which would break their site pretty hard. Since the module already depends on drupal:field, you could just change that to drupal:field (>=8.7) (it doesn't matter which core module you put the dependency on).

Alternatively, you could replace core: 8.x with core_version_requirement: ^8.7.7 || ^9. Although there might still be some 8.8 deprecations to take care off. running drupal-check on 8.8 complains about drupal_installation_attempted() and also old web tests (these can already be converted now but I'd recommend a separate issue). Again up to the maintainer whether you'd already want to add || ^9, I sometimes do it anyway as it's a bit of a hen/egg problem otherwise, you actually test against 9.0 without that.

Hi, After apply the patch about comment #30 and drupal-check, changed the deprecate function drupal_installation_attempted().
But, need work about what is suggested in the comment comment #37.
Thanks

Here is a separate issue to fix the broken namespace and imports.

#3101288: Fix namespace and imports

Looking into this.

Ok, this was more work than expected, as a lot of the deprecations were dynamic and not found by drupal-check. Also the existing patch cheated a bit for example with the migrate unit tests, those were simply skipped due to the empty data source provider, plus they were in the wrong folder.

Knowing @DamienMcKenna, he might want to split this up a bit, lets see ;)

Notes:

* As mentioned, the MigrateSqlSourceTestBase changes are tricky and require complete rewrites of these tests as they are now kernel test, with quite a lot of magic (it knows what to test due to the @covers definition.
* Quite a few entity manager related left-overs that drupal-check didn't see as it used the container, old variable names. Also used the new DI pattern for \Drupal\metatag\Plugin\migrate\source\d7\MetatagFieldInstance which should allow it to work on 8.7 and 8.8 and is less dependant on future changes.
* Added $defaultTheme to a lot of tests, with a @todo in one to remove a chunk of code once this requires at least 8.8 but it will not fail on D9. Also, feels like the tests could be deduplicated quite a bit by extending most of them from a common base class.
* removed the change in metatag_install() as it requires 8.8 and created #3105837: Remove metatag_install().
* As suggested, removed the (very) old update functions and add a last removed hook instead. Several of these would not work anymore in 8.7+, and this seems like the better solution.
* There are also a bunch of overlaps with existing (RTBC) issues, like the new drupal_set_message() calls, class name fix. Should be an easy rebase, but it was helpful to include here to make remaining deprecations easier to see.

Remaining deprecation messages:

  88x: drupal_installation_attempted() is deprecated in drupal:8.8.0 and is removed from drupal:9.0.0. Use \Drupal\Core\Installer\InstallerKernel::installationAttempted() instead. See https://www.drupal.org/node/3035275
    1x in MetatagFieldTestTest::testGlobalDefaultsInheritance from Drupal\Tests\metatag\Functional
    1x in MetatagFieldUserTest::testFieldsOnUserEditForm from Drupal\Tests\metatag\Functional
    1x in MetatagFieldUserTest::testFieldsOnUserRegistrationForm from Drupal\Tests\metatag\Functional
    1x in MetatagFieldTestTest::testEntityFieldValuesNewEntity from Drupal\Tests\metatag\Functional
    1x in MetatagFieldTestTest::testEntityFieldValuesOldEntity from Drupal\Tests\metatag\Functional
    1x in MetatagFieldTestTest::testEntityFieldsAvailable from Drupal\Tests\metatag\Functional
    1x in MetatagFieldTestTest::testFieldCanBeAdded from Drupal\Tests\metatag\Functional
    1x in MetatagFieldTestTest::testBundleDefaultsInheritance from Drupal\Tests\metatag\Functional
    1x in MetatagFieldTestTest::testEntityDefaultsInheritance from Drupal\Tests\metatag\Functional
    1x in MetatagFieldTermTest::testEntityFieldValuesNewEntity from Drupal\Tests\metatag\Functional
    1x in MetatagFieldUserTest::testEntityDefaultsInheritance from Drupal\Tests\metatag\Functional
    1x in MetatagFieldTermTest::testEntityFieldValuesOldEntity from Drupal\Tests\metatag\Functional
    1x in MetatagFieldTermTest::testEntityFieldsAvailable from Drupal\Tests\metatag\Functional
    1x in MetatagFieldTermTest::testFieldCanBeAdded from Drupal\Tests\metatag\Functional
    1x in MetatagFieldTermTest::testBundleDefaultsInheritance from Drupal\Tests\metatag\Functional
    1x in MetatagFieldTermTest::testEntityDefaultsInheritance from Drupal\Tests\metatag\Functional
    1x in MetatagFieldTermTest::testGlobalDefaultsInheritance from Drupal\Tests\metatag\Functional
    1x in MetatagFieldNodeTest::testEntityFieldValuesNewEntity from Drupal\Tests\metatag\Functional
    1x in MetatagFieldNodeTest::testEntityFieldValuesOldEntity from Drupal\Tests\metatag\Functional
    1x in MetatagFieldUserTest::testGlobalDefaultsInheritance from Drupal\Tests\metatag\Functional
    1x in MetatagFieldUserTest::testBundleDefaultsInheritance from Drupal\Tests\metatag\Functional
    1x in MetatagFieldNodeTest::testFieldCanBeAdded from Drupal\Tests\metatag\Functional
    1x in MetatagTagTypesTest::testHtmlIsRemoved from Drupal\Tests\metatag\Functional
    1x in MetatagXssTest::testXssEntityBody from Drupal\Tests\metatag\Functional
    1x in MetatagXssTest::testXssEntityTitle from Drupal\Tests\metatag\Functional
    1x in MetatagXssTest::testXssEntityOverride from Drupal\Tests\metatag\Functional
    1x in MetatagXssTest::testXssMetatagConfig from Drupal\Tests\metatag\Functional
    1x in MetatagTagsTest::testTagsInputOutput from Drupal\Tests\metatag\Functional
    1x in MetatagTagsTest::testTagsArePresent from Drupal\Tests\metatag\Functional
    1x in MetatagTagTypesTest::testContactForm from Drupal\Tests\metatag\Functional
    1x in MetatagTagTypesTest::testSecureTagOption from Drupal\Tests\metatag\Functional
    1x in MetatagStringTest::testAmpersand from Drupal\Tests\metatag\Functional
    1x in MetatagFieldUserTest::testFieldCanBeAdded from Drupal\Tests\metatag\Functional
    1x in MetatagStringTest::testDoubleQuote from Drupal\Tests\metatag\Functional
    1x in MetatagStringTest::testSingleQuote from Drupal\Tests\metatag\Functional
    1x in MetatagNodeTranslationTest::testMetatagValueTranslation from Drupal\Tests\metatag\Functional
    1x in MetatagFrontpageTest::testFrontPageMetatagDisabledConfig from Drupal\Tests\metatag\Functional
    1x in MetatagFrontpageTest::testFrontPageMetatagsEnabledConfig from Drupal\Tests\metatag\Functional
    1x in MetatagForumTest::testForumPost from Drupal\Tests\metatag\Functional
    1x in MetatagFieldUserTest::testEntityFieldValuesNewEntity from Drupal\Tests\metatag\Functional
    1x in MetatagFieldUserTest::testEntityFieldValuesOldEntity from Drupal\Tests\metatag\Functional
    1x in MetatagFieldUserTest::testEntityFieldsAvailable from Drupal\Tests\metatag\Functional
    1x in MetatagFieldNodeTest::testEntityFieldsAvailable from Drupal\Tests\metatag\Functional
    1x in MetatagFieldNodeTest::testBundleDefaultsInheritance from Drupal\Tests\metatag\Functional
    1x in MetatagAppLinksTagsTest::testTagsArePresent from Drupal\Tests\metatag_app_links\Functional
    1x in MetatagGoogleCSETagsTest::testTagsArePresent from Drupal\Tests\metatag_google_cse\Functional
    1x in MetatagOpenGraphTagsTest::testTagsArePresent from Drupal\Tests\metatag_open_graph\Functional
    1x in MetatagMobileTagsTest::testTagsInputOutput from Drupal\Tests\metatag_mobile\Functional
    1x in MetatagMobileTagsTest::testTagsArePresent from Drupal\Tests\metatag_mobile\Functional
    1x in MetatagHreflangTagsTest::testTagsInputOutput from Drupal\Tests\metatag_hreflang\Functional
    1x in MetatagHreflangTagsTest::testTagsArePresent from Drupal\Tests\metatag_hreflang\Functional
    1x in MetatagGooglePlusTagsTest::testTagsInputOutput from Drupal\Tests\metatag_google_plus\Functional
    1x in MetatagGooglePlusTagsTest::testTagsArePresent from Drupal\Tests\metatag_google_plus\Functional
    1x in MetatagGoogleCSETagsTest::testTagsInputOutput from Drupal\Tests\metatag_google_cse\Functional
    1x in MetatagFaviconsTagsTest::testTagsInputOutput from Drupal\Tests\metatag_favicons\Functional
    1x in MetatagOpenGraphProductsTagsTest::testTagsArePresent from Drupal\Tests\metatag_open_graph_products\Functional
    1x in MetatagFaviconsTagsTest::testTagsArePresent from Drupal\Tests\metatag_favicons\Functional
    1x in MetatagFacebookTagsTest::testTagsInputOutput from Drupal\Tests\metatag_facebook\Functional
    1x in MetatagFacebookTagsTest::testTagsArePresent from Drupal\Tests\metatag_facebook\Functional
    1x in MetatagDublinCoreAdvancedTagsTest::testTagsInputOutput from Drupal\Tests\metatag_dc_advanced\Functional
    1x in MetatagDublinCoreAdvancedTagsTest::testTagsArePresent from Drupal\Tests\metatag_dc_advanced\Functional
    1x in MetatagDublinCoreTagsTest::testTagsInputOutput from Drupal\Tests\metatag_dc\Functional
    1x in MetatagDublinCoreTagsTest::testTagsArePresent from Drupal\Tests\metatag_dc\Functional
    1x in MetatagAppLinksTagsTest::testTagsInputOutput from Drupal\Tests\metatag_app_links\Functional
    1x in MetatagOpenGraphTagsTest::testTagsInputOutput from Drupal\Tests\metatag_open_graph\Functional
    1x in MetatagOpenGraphProductsTagsTest::testTagsInputOutput from Drupal\Tests\metatag_open_graph_products\Functional
    1x in MetatagFieldNodeTest::testEntityDefaultsInheritance from Drupal\Tests\metatag\Functional
    1x in MetatagAdminTest::testSpecialPages from Drupal\Tests\metatag\Functional
    1x in MetatagFieldNodeTest::testGlobalDefaultsInheritance from Drupal\Tests\metatag\Functional
    1x in MetatagCustomRouteTest::testCustomRoute from Drupal\Tests\metatag\Functional
    1x in MetatagConfigTranslationTest::testConfigTranslations from Drupal\Tests\metatag\Functional
    1x in MetatagConfigTranslationTest::testConfigTranslationsExist from Drupal\Tests\metatag\Functional
    1x in MetatagAdminTest::testListPager from Drupal\Tests\metatag\Functional
    1x in MetatagAdminTest::testDefaultProtected from Drupal\Tests\metatag\Functional
    1x in MetatagAdminTest::testEntityDefaultInheritence from Drupal\Tests\metatag\Functional
    1x in MetatagAdminTest::testOverrides from Drupal\Tests\metatag\Functional
    1x in MetatagAdminTest::testAvailableConfigEntities from Drupal\Tests\metatag\Functional
    1x in MetatagPageManagerTest::testSingleVariantPage from Drupal\Tests\metatag_page_manager\Functional
    1x in MetatagAdminTest::testDefaults from Drupal\Tests\metatag\Functional
    1x in MetatagViewsBasicsTest::testSiteStillWorks from Drupal\Tests\metatag_views\Functional
    1x in MetatagVerificationTagsTest::testTagsInputOutput from Drupal\Tests\metatag_verification\Functional
    1x in MetatagVerificationTagsTest::testTagsArePresent from Drupal\Tests\metatag_verification\Functional
    1x in MetatagTwitterCardsTagsTest::testTagsInputOutput from Drupal\Tests\metatag_twitter_cards\Functional
    1x in MetatagTwitterCardsTagsTest::testTagsArePresent from Drupal\Tests\metatag_twitter_cards\Functional
    1x in MetatagPinterestTagsTest::testTagsInputOutput from Drupal\Tests\metatag_pinterest\Functional
    1x in MetatagPinterestTagsTest::testTagsArePresent from Drupal\Tests\metatag_pinterest\Functional
    1x in MetatagPageManagerTest::testMultipleVariantPage from Drupal\Tests\metatag_page_manager\Functional
    1x in SchemaMetatagTest::testTagsInputOutput from Drupal\Tests\metatag\Functional

  12x: Automatically creating the first item for computed fields is deprecated in Drupal 8.5.x and will be removed before Drupal 9.0.0. Use \Drupal\Core\TypedData\ComputedItemListTrait instead.
    6x in MetatagAdminTest::testOverrides from Drupal\Tests\metatag\Functional
    6x in MetatagAdminTest::testEntityDefaultInheritence from Drupal\Tests\metatag\Functional

  7x: Constructing a ContextDefinition object for an entity type is deprecated in Drupal 8.6.0. Use Drupal\Core\Plugin\Context\EntityContextDefinition instead. See https://www.drupal.org/node/2976400 for more information.
    5x in MetatagPageManagerTest::testMultipleVariantPage from Drupal\Tests\metatag_page_manager\Functional
    2x in MetatagPageManagerTest::testSingleVariantPage from Drupal\Tests\metatag_page_manager\Functional

  7x: Render #pre_render callbacks must be methods of a class that implements \Drupal\Core\Security\TrustedCallbackInterface or be an anonymous function. The callback was Drupal\page_manager\Plugin\DisplayVariant\PageBlockDisplayVariant::buildRegions. Support for this callback implementation is deprecated in 8.8.0 and will be removed in Drupal 9.0.0. See https://www.drupal.org/node/2966725
    5x in MetatagPageManagerTest::testMultipleVariantPage from Drupal\Tests\metatag_page_manager\Functional
    2x in MetatagPageManagerTest::testSingleVariantPage from Drupal\Tests\metatag_page_manager\Functional

  1x: Drupal\Tests\BrowserTestBase::$defaultTheme is required in drupal:9.0.0 when using an install profile that does not set a default theme. See https://www.drupal.org/node/3083055, which includes recommendations on which theme to use.
    1x in SchemaMetatagTest::testTagsInputOutput from Drupal\Tests\metatag\Functional

  1x: Duplicate key "metatag.metatag_tag.schema_web_page_speakable" detected whilst parsing YAML. Silent handling of duplicate mapping keys in YAML is deprecated since Symfony 3.2 and will throw \Symfony\Component\Yaml\Exception\ParseException in 4.0 on line 33.
    1x in SchemaMetatagTest::testTagsInputOutput from Drupal\Tests\metatag\Functional

  1x: Duplicate key "metatag.metatag_tag.schema_web_page_speakable" detected whilst parsing YAML. Silent handling of duplicate mapping keys in YAML is deprecated since Symfony 3.2 and will throw \Symfony\Component\Yaml\Exception\ParseException in 4.0 on line 36.
    1x in SchemaMetatagTest::testTagsInputOutput from Drupal\Tests\metatag\Functional

AFAICS, except drupal_installation_attempted(), these are all coming from other modules.

Just a reroll

Rerolling again

Another reroll

Rerolled on top of #3109835: Declare compatibility with Drupal 9. Until today, I didn't even know this issue existed. But if I had, I would have pushed for this to get in, rather than the other one. Please accept my apology.

Yet another reroll.

Rerolling again!

Scheduling this for the next release.

Considering how many reroll this needs, it really would be nice to get this in sooner rather than later :)

Fixed the kernel tests, they need the token module enabled now.

Another freakin' reroll.

+++ b/tests/src/Kernel/Migrate/d7/MetatagFieldInstanceTest.php
@@ -0,0 +1,79 @@
+/**
+ * Tests Metatag-D7 field instance source plugin.
+ *
+ * @group metatag
+ * @covers Drupal\metatag\Plugin\migrate\source\d7\MetatagFieldInstance
+ */
+class MetatagFieldInstanceTest extends MigrateSqlSourceTestBase {
+

this test is now being added and none is removed.

That's because the same work was done in #3120947: Expand FieldInstanceTest classes to handle multiple bundles per entity type (:() but that added the new class in a different namespace. We need to remove this one and probably also move the other test that still does need to be converted to the same location.

Round and round we go.

I discarded the MetatagFieldInstanceTest added by this patch, in favor of the one added in #3120947: Expand FieldInstanceTest classes to handle multiple bundles per entity type. Having looked both of them over, I think they're basically identical in coverage, except that the one added last night is more "realistic" because it doesn't do as much service mocking. So, let's just stick with that.

I'm working on removing the dependencies that don't have D9-compatible releases, so that composer can run without throwing errors.

I've removed Devel, RestUI and Schema.org Metatag as dependencies, let's see if that's enough for this to get past Composer.

Requested a test run with PHP 7.3 instead, D9 needs that.

That said, I wouldn't really recommend to remove those dependencies/tests, because you also lose the test coverage on 8.x for those integrations then. Lets just try to push them all along together, devel apparently did a quite a bit of preparation already, just not that part yet, seems to have active maintainers and the other two afaik have patches that we just need to get committed.

But that's up to you :)

Looks like the patch no longer applies as you removed those tests :)

Also, for restui, do you really need the UI for a test? Aren't you just trying to test an actual REST service/normalization, then you could set that up through the API and skip the module?

The tests that were removed will be added back again once those modules are D9 compatible, see #3123578: Add NodeJsonOutput test back again, #3123583: Add Devel dependency, tests back again and #3123521: Add Schema.org Metatag dependency, tests back again.

Another reroll in light of recent commits.

Converted NodewordsFieldTest to a kernel test.

This should fix MetatagAppLinksTest. Worked locally for me, anyway...

This should reduce the failures. After this, I suspect the remaining ones are originating in other modules...

Let's see if using the HEADs of Page Manager and Redirect produce a positive effect.

Everything except the page manager test passes now and I verified locally that it passes when combined with #3109618: Fix tests on Drupal 9 and drop support for 8.7 and earlier.

So I think this is as ready as it can be!

#3109618: Fix tests on Drupal 9 and drop support for 8.7 and earlier is in!

+++ b/composer.json
@@ -26,7 +26,7 @@
-    "drupal/redirect": "^1.0",
-    "drupal/page_manager": "^4.0"
+    "drupal/redirect": "1.x-dev",
+    "drupal/page_manager": "4.x-dev"

page_manager is already released. I think it's better to use ^4.0-beta5 instead of requiring the dev.

Committed! Thank you so much, everyone! This is fantastic!

BTW I'm completely ok relying on dev releases of modules that are only used as test dependencies, if we want to tighten that up later we can do that but for now it's fine.

One quick follow-up: this breaks compatibility with Drupal 8.7, would adding the core: 8.x line back into the info.yml files break compatibility with D9? Putting it another way: is it possible to make it compatible with 8.7, 8.8 and 9.0?

You can't mix ^8.7.7 and core: 8.x, and that's not actually the problem.

One problem is that the constructor of NodewordsFieldInstance was adjusted to use EntityTypeManager, instead, the approach I took in the other migrate class should be used here as well, with assigning things in create(), then we don't have to require 8.8.

The other fails are I think only caused by having page_manager in the test environment, both core and core_version_requirement were removed there in test modules, which is only supported since 8.8.2 or so. page_manager requires 8.8 now, so it doesn't care, but it also affects metatag now. Best we could do is add them back in -dev there to explicitly require 8.8 instead of relying on the new magic. At least the page manager test is still going to fail on 8.7 though.

Ok, thank you for taking the time to look into all of the errors. I'll run the main tests locally against 8.7 before the next release, just to be sure.

Copied over the DI approach from MetatagFieldInstance, page_manager has been updated, so this should now pass on 8.8, 9.0 and mostly on 8.7 too. I think I commented earlier that you already before had some failing tests on 8.7 due to label changes in core, lets see.

Committed. Thanks again.

I was looking at the usage of core_version_requirement for various projects and see that the committed code used quotes around the versions whereas all the other projects I've reviewed so far (about 50) do not use quotes and the change record doesn't use quotes.

https://git.drupalcode.org/project/metatag/blob/ec6ee0e96b959d4eff276101...

core_version_requirement: '^8.7.7 || ^9'

Change record: https://www.drupal.org/node/3070687

Although this technically works, I would suggest updating it at some point to not include the quotes for consistency with other projects.