The D9 release plan for Metatag is:

  • Wait until core 8.8.0 is released.
  • Start fixing 9.x compatibility bugs in sub-issues, not in this one.
  • Aim to have a release of Metatag that is fully compatible with 8.x and 9.x the day that 9.0 is released.

This seems generic because the upgrade from D8 to D9 will be pretty generic for the vast majority of modules.

CommentFileSizeAuthor
#5 drupal-9-release-plan-for-Metatag-3088848-5.patch5.3 KB-enzo-

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue summary: View changes
abramm’s picture

abramm
Primary language Ukrainian
Location Lutsk
commented

Ignore this comment, was posted to a wrong issue.

abramm’s picture

abramm
Primary language Ukrainian
Location Lutsk
commented

Ignore this comment, was posted to a wrong issue.

-enzo-’s picture

-enzo- commented
StatusFileSize
new drupal-9-release-plan-for-Metatag-3088848-5.patch5.3 KB

Hi @DamienMcKenna

I did my first approach to prepare Metatag for Drupal 8.8+, after applying this patch we still have 10 issues to solve

drupal-check metatag
 411/411 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ -------------------------------------------------------------------------------------------------------------------------------------------------
  Line   metatag_facebook/src/Plugin/metatag/Group/Facebook.php
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------
         Class Drupal\facebook\Plugin\metatag\Group\Facebook was not found while trying to analyse it - autoloading is probably not configured properly.
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------------------------
  Line   metatag_mobile/src/Plugin/metatag/Group/AndroidMobile.php
 ------ ---------------------------------------------------------------------------------------------------
         Class Drupal\metatag_mobile\Plugin\metatag\Group\GroupBase not found and could not be autoloaded.
 ------ ---------------------------------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------------------------
  Line   metatag_mobile/src/Plugin/metatag/Group/AppleMobile.php
 ------ ---------------------------------------------------------------------------------------------------
         Class Drupal\metatag_mobile\Plugin\metatag\Group\GroupBase not found and could not be autoloaded.
 ------ ---------------------------------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------------------------
  Line   metatag_mobile/src/Plugin/metatag/Group/Mobile.php
 ------ ---------------------------------------------------------------------------------------------------
         Class Drupal\metatag_mobile\Plugin\metatag\Group\GroupBase not found and could not be autoloaded.
 ------ ---------------------------------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------------------------
  Line   metatag_mobile/src/Plugin/metatag/Group/WindowsMobile.php
 ------ ---------------------------------------------------------------------------------------------------
         Class Drupal\metatag_mobile\Plugin\metatag\Group\GroupBase not found and could not be autoloaded.
 ------ ---------------------------------------------------------------------------------------------------

 ------ -----------------------------------------------------------------------------------------------------
  Line   src/Command/GenerateGroupCommand.php
 ------ -----------------------------------------------------------------------------------------------------
  106    Call to deprecated method confirmGeneration() of class Drupal\metatag\Command\GenerateGroupCommand.
 ------ -----------------------------------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------------------------
  Line   src/Command/GenerateTagCommand.php
 ------ ---------------------------------------------------------------------------------------------------
  140    Call to deprecated method confirmGeneration() of class Drupal\metatag\Command\GenerateTagCommand.
 ------ ---------------------------------------------------------------------------------------------------

 ------ ----------------------------------------------------------------------------------------------------------
  Line   src/Plugin/GraphQL/Scalars/MetatagScalar.php
 ------ ----------------------------------------------------------------------------------------------------------
         Class Drupal\graphql\Plugin\GraphQL\Scalars\Internal\StringScalar not found and could not be autoloaded.
 ------ ----------------------------------------------------------------------------------------------------------

 ------ --------------------------------------------------------------------------------------------------------
  Line   tests/src/Functional/SchemaMetatagTest.php
 ------ --------------------------------------------------------------------------------------------------------
         Class Drupal\Tests\schema_web_page\Functional\SchemaWebPageTest not found and could not be autoloaded.
 ------ --------------------------------------------------------------------------------------------------------

 ------ ----------------------------------------------------------------------------------------------
  Line   tests/src/Kernel/MetatagSerializationTest.php
 ------ ----------------------------------------------------------------------------------------------
  60     Call to deprecated method setExpectedException() of class Drupal\KernelTests\KernelTestBase:
         in drupal:8.8.0 and is removed from drupal:9.0.0.
         Backward compatibility for PHPUnit 4 will no longer be supported.
 ------ ----------------------------------------------------------------------------------------------


 [ERROR] Found 10 errors

But I think the first 9 are related to missing classes, composer install doesn't work in the version I get from git

abramm’s picture

abramm
Primary language Ukrainian
Location Lutsk
commented

Hi @-enzo-,
This is been handled in #3042590: Drupal 9 Deprecated Code Report.

-enzo-’s picture

-enzo- commented

Ooops. I got this issue from https://www.drupal.org/project/issues/search?text=&projects=&assigned=&s...

Then this issue should be closed and tag as duplicated?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue summary: View changes

No, I just wasn't clear in the summary that this is a plan issue and the actual work will be done in sub issues, I'm sorry for leading you to waste your time.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue summary: View changes
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
damienmckenna’s picture

damienmckenna
Location TN, USA
commented

I'm currently considering committing the changes once 9.0.0-beta1 is released, that'll be a line in the sand that I think the community could work from.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Drupal 9 release plan for Metatag » Drupal 9 release plan for Metatag (ETA: when D9.0.0-beta1 is released)
Status: Active » Postponed

Marking this "postponed" for now.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

FYI I did commit a change that phenaproxma did to make the module compatible at the info file level (#3109835: Declare compatibility with Drupal 9), which will also make it easier to start testing patches.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

@DamienMcKenna: I'm confused #3042590: Drupal 9 Deprecated Code Report is/was ready and only requires Drupal 8.7, so why wait? The other issue as IMHO not needed and just conflicts with the one that actually makes it compatible now.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Postponed » Needs review

I think this is almost ready.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

I just released 1.13 which supports D9.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.