The RestUI dependency & tests were removed in #3123577: Remove RestUI dependency for D9 to remove a blocker allowing the module to be released as a D9-compatible version. Once RestUI is D9-compatible, add it all back again.

CommentFileSizeAuthor
#11 metatag-n3123578-11.patch4.57 KBdamienmckenna
#6 metatag-n3123578-6.patch4.01 KBdamienmckenna
#4 metatag-n3123578-4.patch4.56 KBdamienmckenna

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: #3123521: Add Schema.org Metatag dependency, tests back again »
Related issues: +#3123521: Add Schema.org Metatag dependency, tests back again
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Related issues: +#3123577: Remove RestUI dependency for D9
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n3123578-4.patch4.56 KB

This adds the changes back again.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented 
+++ b/tests/src/Functional/NodeJsonOutput.php
@@ -0,0 +1,135 @@
+
+    // Need this to make the configuration sane.
+    'restui',

it's very unclear what exactly adding restui does here and why it makes the configuration "sane". The test passes just fine for me when I remove that dependency.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Postponed » Needs review
StatusFileSize
new metatag-n3123578-6.patch4.01 KB

Ok, let's see if it isn't needed anymore

  • DamienMcKenna committed f297a17 on 8.x-1.x 
    Issue #3123578 by DamienMcKenna, Berdir: Add NodeJsonOutput test back...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Add RestUI dependency, tests back again » Add NodeJsonOutput test back again
Status: Needs review » Fixed

Whaddya know, the tests worked anyway!

  • DamienMcKenna committed 6b545f6 on 8.x-1.x 
    Issue #3123578 by DamienMcKenna: Removed restui dependency from test's...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Fixed » Needs work
Parent issue: » #3122327: Plan for Metatag 8.x-1.13

This needs a little follow-up because the D9 branch tests are failing:

1) Drupal\Tests\metatag\Functional\NodeJsonOutput::testNode
Exception: Drupal\Tests\BrowserTestBase::$defaultTheme is required. See https://www.drupal.org/node/3083055, which includes recommendations on which theme to use.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n3123578-11.patch4.57 KB

Let's see if this works.

  • DamienMcKenna committed 24362a9 on 8.x-1.x 
    Issue #3123578 by DamienMcKenna: Some follow-up on D9 test compatibility...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed. All done.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.