The Schema.org Metatag dependency & tests were removed in #3123520: Remove Schema.org Metatag dependency for D9 to remove a blocker allowing the module to be released as a D9-compatible version. Once Schema.org Metatag is D9-compatible, add it all back again.

CommentFileSizeAuthor
#4 metatag-n3123521-5.patch2.38 KBdamienmckenna
#2 metatag-n3123521-2.patch2.81 KBdamienmckenna

Issue fork metatag-3123521

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n3123521-2.patch2.81 KB

This is all of the files added back again.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented 
+++ b/metatag.info.yml
@@ -12,3 +12,4 @@ test_dependencies:
   - redirect:redirect
   - restui:restui
+  - schema_metatag:schema_web_page

note that require-dev basically makes test_dependencies redundant, it was only used by testbot and require-dev works on patches, test_dependencies only after a commit. I'd just remove that part, one thing less that will conflict and needs to be kept in sync.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Postponed » Needs review
StatusFileSize
new metatag-n3123521-5.patch2.38 KB

Rerolled.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Composer fails with this error:

  Problem 1
    - Root composer.json requires drupal/schema_metatag ^2.0 -> satisfiable by drupal/schema_metatag[2.0.0, ..., 2.x-dev].
    - drupal/schema_metatag[2.0.0, ..., 2.x-dev] require drupal/metatag ^1.0 -> satisfiable by drupal/metatag[dev-1.x, 1.0.0-beta1, ..., 1.x-dev (alias of dev-1.x)] from composer repo (https://packages.drupal.org/8) but drupal/metatag[dev-8.x-1.x] from vcs repo (git /var/lib/drupalci/vcsRepoDir) has higher repository priority. The packages from the higher priority repository do not match your constraint and are therefore not installable. That repository is canonical so the lower priority repo's packages are not installable. See https://getcomposer.org/repoprio for details and assistance.

But why?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Needs work
berdir’s picture

berdir
Primary language German
Location Switzerland
commented

> drupal/metatag[dev-8.x-1.x]

Apparently your own dev version is different when added from the branch than what the schema_metatag module wants. You kind of have a cross-dependency here, depending on a module that requires a specific version of metatag agin.

This could be a bug in the CI logic that re-adds branches like this so that composer.json changes work.

You could try a merge request instead, but that might break any future patch that changes composer.json. or maybe a branch-alias: https://getcomposer.org/doc/articles/aliases.md#branch-alias. So you'd alias dev-8.x-1.x to 1.x-dev.

JeroenT made their first commit to this issue’s fork.

JeroenT opened merge request !49