Drupal 8 has a bunch of the legacy include files.
As Drupal 9 planned to be released in 2020, it would be great to deprecate content of the legacy files as much as possible before release.

This is the issue for tracking the deprecation status of the legacy include files:

Kernel includes

Install includes

Rest of the files

Comments

voleger created an issue. See original summary.

voleger’s picture

Issue summary: View changes
claudiu.cristea’s picture

voleger’s picture

Issue summary: View changes
voleger’s picture

mondrake’s picture

mile23’s picture

Adding the batch service, but there's no issue to deprecate the functional way.

+1 on this issue. :-)

voleger’s picture

voleger’s picture

Issue summary: View changes
voleger’s picture

voleger’s picture

claudiu.cristea’s picture

claudiu.cristea’s picture

Removed by mistake.

claudiu.cristea’s picture

Issue summary: View changes
voleger’s picture

Issue summary: View changes

Revert some changes

voleger’s picture

claudiu.cristea’s picture

Title: [kill includes] Deprecation status of the legacy include files » [META] Deprecate the legacy include files
Issue summary: View changes

Renamed to be clear that it's a META issue. Removed a duplicate issue from IS.

voleger’s picture

claudiu.cristea’s picture

claudiu.cristea’s picture

andypost’s picture

Issue summary: View changes
voleger’s picture

mile23’s picture

voleger’s picture

voleger’s picture

Should we somehow mark the files that are ready to be removed before Drupal 9?

andypost’s picture

jcnventura’s picture

Issue summary: View changes
voleger’s picture

Issue summary: View changes
voleger’s picture

Issue summary: View changes

Created issue for update.inc

voleger’s picture

andypost’s picture

voleger’s picture

voleger’s picture

Issue summary: View changes

-1 include file

voleger’s picture

voleger’s picture

Issue summary: View changes

Moved common.inc related issues into own meta #3015538: [META] Deprecate contents of common.inc

voleger’s picture

andypost’s picture

alexpott’s picture

mile23’s picture

I guess install.core.inc is just to terrifying to contemplate.

voleger’s picture

voleger’s picture

Issue summary: View changes
voleger’s picture

#3021450: Add @trigger_error to deprecated functions in file.inc and replace their usages
Looks like we should recheck the existing deprecated functions. Some of them not properly replaced from the core.
That possibly can block removal of some legacy code from the core in 9.x version.

voleger’s picture

voleger’s picture

voleger’s picture

voleger’s picture

claudiu.cristea’s picture

claudiu.cristea’s picture

claudiu.cristea’s picture

claudiu.cristea’s picture

kim.pepper’s picture

Issue summary: View changes
volkswagenchick’s picture

Issue tags: +midcamp2019
volkswagenchick’s picture

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

voleger’s picture

berdir’s picture

FYI, for people looking for interesting parts in .inc files to deprecate, comment out the include files in DrupalKernel and watch Drupal explode.

For bootstrap.inc, that's currently #3038513: Move drupal_generate_test_ua() into the test system. If you apply that patch, it's warnings about the error/exception handler (so we need to replace those functions likely all of errors.inc) and then it fatals on drupal_installation_attempted(), another nasty one.

If you comment out common.inc, we actually get pretty far, it dies on drupal_pre_render_links and possibly some other render-related callbacks. Didn't find an issue for that yet either.

andypost’s picture

@Berdir I guess #2999962: Unify Database/Log::findCaller and Utility/Error::getLastCaller is what you're looking for
Also per file issues mostly all filed

voleger’s picture

This one also related to the error handler deprecation replacements #3000229: Add DrupalErrorHandler wrapping Symfony ErrorHandler component

voleger’s picture

Issue summary: View changes
feuerwagen’s picture

Issue summary: View changes
phenaproxima’s picture

berdir’s picture

Issue summary: View changes
voleger’s picture

voleger’s picture

Issue summary: View changes

entity.inc - deprecated

voleger’s picture

Issue summary: View changes
berdir’s picture

Issue summary: View changes

I worked a bit on bootstrap.inc related deprecation issues, and updated the issue summary with them, basically in the order in which they are first called. when combining the user agent + errors + drupal_installation_attempted() + user timezone patches, it is starting to bootstrap and load modules, with a lot of notices and warnings, e.g. due to REQUEST_TIME. Then dying on drupal_static() in node_access_view_all_nodes(), but that does mean I get as far as route access checking.

voleger’s picture

Issue tags: +dckyiv2019
voleger’s picture

kim.pepper’s picture

voleger’s picture

Issue summary: View changes

Remove duplication
Set #1577902: [META] Remove all usages of drupal_static() & drupal_static_reset() as meta in the scope of bootstrap.inc

kim.pepper’s picture

andypost’s picture

volkswagenchick’s picture

Issue tags: +dcco2019

Adding this issue to the DrupalCamp Colorado contribution day queue. Aug4, 2019

andypost’s picture

Issue summary: View changes

ordered file.inc

andypost’s picture

Issue summary: View changes
voleger’s picture

Update the current status of the issues in IS

andypost’s picture

Issue summary: View changes

reordered issues to move commited down

voleger’s picture

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

andypost’s picture

voleger’s picture

Title: [META] Deprecate the legacy include files » [META] Deprecate the legacy include files in Drupal 8
Related issues: +#3090988: Remove deprecated in Drupal 8 include files, +#3087546: Remove deprecated entity manager

Make a title more specific.

Also referencing the issues where the deprecated files will be removed.
#3090988: Remove deprecated in Drupal 8 include files
#3087546: Remove deprecated entity manager

voleger’s picture

Title: [META] Deprecate the legacy include files in Drupal 8 » [META] Deprecate the legacy include files before Drupal 9
Issue summary: View changes

pager.inc is also deprecated now.

Also database.inc, tablesort.inc, entity.inc, unicode.inc and pager.inc already removed in the drupal:9.0.x.

Since no new deprecations allowed in the Drupal 8 we have to close this meta.
For new deprecations, before Drupal 10, I had created a new meta #3097045: [META] Provide modern replacements for and deprecate the legacy include files.

voleger’s picture

Category: Task » Plan
Status: Active » Fixed
andypost’s picture

Great, now needs to reassign all child issues to new one

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.