Deprecate date_iso8601()

Thinking out loud here, but if the callable issue is limited to the migrations, can we add this as a helper class there instead of Component? Can the format_date migrate plugin be used?

Good compromise

+++ b/core/includes/common.inc
@@ -331,16 +331,20 @@ function format_date($timestamp, $type = 'medium', $format = '', $timezone = NUL
- * @param $date
+ * @param string $timestamp
...
-function date_iso8601($date) {
...
+function date_iso8601($timestamp) {

any reason to change signature?

Came across this and just noting that #2998666: Warnings after D7 upgrade caused by rdf migration has been committed which implements the most of the rdf changes in the patch in #8.

Re-roll of #8, after #2998666: Warnings after D7 upgrade caused by rdf migration.

No interdiff because it's way, way larger than the new patch.

Ah well, that function is not actually testing date_iso8601(), but the callback mechanism. There's a timezone difference between using date_iso8601(), which seems to be using UTC+10, and CommonDataConverter::dateIso8601Value() which uses UTC.

Changing ISO date to also use UTC fixes the test, keeping it virtually the same as before.

I read on d.o somewhere that the timezone for tests is Sydney/Australia which explains the UTC+10, but I can't find that page again.

Installed the patch and checked why the change to UTC. The change to UTC is necessary because CommonDataConverter assumes a format of UTC. I don't quite get why that is but then converting a time to UTC shouldn't be a problem. As stated in the issue where that was committed

updated the tests to use format_date, and Drupal\rdf\CommonDataConverter() to use \Drupal::service('date.formatter'), and both to force the timestamp to UTC (which shouldn't matter for this purpose, since the TZ offset it part of the output and will be interpreted by anything using it). Not sure if the CommonDataConverter() part would really be considered in scope, but we have a service for formatting timestamps, so we should use it instead of the low level function.

Committed e1c3458 and pushed to 8.7.x. Thanks!

publish change record