[META] Deprecate contents of menu.inc

Makes sense, also menu_local_tabs is tricky - looks better to deprecate it in favour of inline code or render element

btw Other deprecated functions needs work for proper deprecation (provide link & throw error)

Yeah, menu_local_tabs() is not used in core it seems and LocalTasksBlock calls it directly. I don't think this function is needed anymore, I'd just deprecate it in favor of using the block or using the theme function directly.

Filed #3021788: Move template_preprocess_menu_local_task() and template_preprocess_menu_local_action() to the core/includes/theme.inc

fixed links in IS

It makes sense to file new issue to review menu entity usage

Btw already deprecated functions needs tests which could be based on test class added in #3021718: Properly deprecate menu_local_tabs(), menu_secondary_local_tasks(), menu_primary_local_tasks()

Done #3021718: Properly deprecate menu_local_tabs(), menu_secondary_local_tasks(), menu_primary_local_tasks()

I think it's just preprocess functions and one helper now? Moving preprocess to theme.inc might be possible in 9.x, without BC because the location of functions isn't part of BC.

Last 2 child issues left, done #3021788: Move template_preprocess_menu_local_task() and template_preprocess_menu_local_action() to the core/includes/theme.inc

Can the 2 remaining issue: #3021804: Remove optional dependency on menu_ui module in \Drupal\views\Plugin\views\wizard\WizardPluginBase and #1882552: Deprecate menu_list_system_menus() and menu_ui_get_menus(), be done independent of each other or is one blocking the other. If so, which one should go first?

@daffie I still think this 2 issues are separate, one affects views and only after it's fixed we can deprecate system menus

Both have own scope and I'd like if someone has idea how to join them

last 2 issues could go separate but will affect each other so better to get #3021804: Remove optional dependency on menu_ui module in \Drupal\views\Plugin\views\wizard\WizardPluginBase in first

Moreover there's another one blocked on it #3028612: Deprecate menu_ui_get_menus() and replace all of its usages (added to related)

updates IS a bit

There's one more issue to work on #3028612: Deprecate menu_ui_get_menus() and replace all of its usages

Yay! It's done