Fix integration with content moderation in multi-lingual scenarios

Hi @andreyjan, I've been testing this today. Thanks for the patch.

This works well for when you want to edit a translation of a published node.

Where it does not work is if you are using revisions, such as with content moderation.
Here's a scenario that doesn't work:

1. add a new node with an IEF field, publish it
2. translate and publish it
3. create a new draft in the original language, add a new value to the IEF field, do not publish
4. create a new draft translation.

Actual result:
You do not see the newly added value in the IEF field

Expected result:
You should see the newly added value in the IEF field, so that you can translate it.

I think the revision issue I mention above is a core issue, see https://www.drupal.org/project/drupal/issues/3007233

Hi @nicrodgers, Does the patch in #3 result in a net improvement to the module functionality, or does it introduce a new problem that wasn't there before? I am using the patch and would love to see it committed while we wait for the core issue with revisions to be resolved.

I think the patch in #3 is still worth moving forwards with, I mentioned the revision scenario in #4/#5 mainly as a heads-up for anyone who comes here looking for/expecting a solution for that. That's a core issue anyway.

I think the best way to move this issue forwards to get it ready for merging is to create some tests that demonstrate the problem (and the fix).

Does this issue queue refer to the parent form entity reference field (and therefore its IEF) being hidden when the field is not translatable or something on the embedded IEF? I am looking for the former.

Note that currently (and with the patch in #8 above), my host entity form is translatable and has a non-translatable, multivalue entity reference field which utilized IEF to create/edit. Should be irrelevant whether the referenced IEF entity type is translatable. When I add or edit a translation to my parent entity:

Expected: The embedded IEF for this non-translatable entity reference field should not show either values, Add, or Edit.

Instead: Two observations: 1. I do not see existing values from the Original Translation but can Add a new reference with IEF. 2. And when I do, the unseen Original Translation references get clobbered, and now all translations point to the one(s) added in the translation.

Based on the description of this issue, these sound related, but if I am talking about something else, please clarify in this issue's description. As for my particular issue, I've filed my separate concern as #3108400: Inline Entity Form: Hide widget when host entity form is not original language, and host reference field is not translatable and uploaded a patch that works for my case. I hope it helps, and I hope it can be improved and approved in its simplicity.

Thank you for your efforts @andreyjan.

Re-rolled patch in #8 against current dev version.

#11 is in
tnx

The patch #8 creates /src/Tests/ContentModerationTranslationTest.php. ContentModerationTranslationTest extends InlineEntityFormTestBase which is not defined in this namespace.

This breaks automatic tests on the 2.0.x branch:

PHP Fatal error: Uncaught Error: Class "Drupal\inline_entity_form\Tests\InlineEntityFormTestBase" not found in /var/www/html/modules/contrib/inline_entity_form/src/Tests/ContentModerationTranslationTest.php:12

See this result for example: https://www.drupal.org/pift-ci-job/2666453

The test in ContentModerationTranslationTest.php and InlineEntityFormTestBase require some refactoring, as InlineEntityFormTestBase extends WebDriverTestBase.

ContentModerationTranslationTest.php requires a use Drupal\Tests\inline_entity_form\FunctionalJavascript\InlineEntityFormTestBase; and the deprecated calls to drupalPostAjaxForm(..) need to replaced with drupalPostForm.

See https://www.drupal.org/docs/automated-testing/converting-simpletests-to-... .

https://www.drupal.org/pift-ci-job/2668244

> Drupal\Core\Composer\Composer::upgradePHPUnit
PHP Fatal error:  Declaration of Drupal\inline_entity_form\Tests\ContentModerationTranslationTest::setUp() must be compatible with Drupal\Tests\inline_entity_form\FunctionalJavascript\InlineEntityFormTestBase::setUp(): void in /var/www/html/modules/contrib/inline_entity_form/src/Tests/ContentModerationTranslationTest.php on line 30

setUp() must be defined as protected function setUp(): void {

I also see some other errors when I open ContentModerationTranslationTest.php in Vscode:

Undefined method 'drupalPostAjaxForm'
Undefined method 'drupalPostAjaxForm'
Undefined method 'assertTrue'

Thank you @shivam_tiwari. Did not run a test but code looks good to me now.

@podarok, could you please merge and run a test?

merged
checking

run https://www.drupal.org/pift-ci-job/2668358

Bulk reopen.

For me some fields where not hidden when they should've been hidden. Updated the patch from #11 to fix that.

At first, thanks for the patch, works great so far :) One thing still not working is that if the field references a media element containing an image file upload, in the translation record I can't delete the referenced item but only edit it.

Not sure if this only applies to referenced media entities but also for other ones.

Does anyone else have this behavior?