Convert drupal.org to example.com in tests

Fix for duplicate addresses found in the previous patch.

Why are tests changing in this issue? Some of those are “http” for a reason.

@cilefen

Tried to figure out the links which were intentionally http.

Re-submitting the patch with interdiff.

I think it's good to keep the http protocol here, as it's a protocol test:

--- a/core/modules/link/tests/src/Unit/Plugin/Validation/Constraint/LinkExternalProtocolsConstraintValidatorTest.php
+++ b/core/modules/link/tests/src/Unit/Plugin/Validation/Constraint/LinkExternalProtocolsConstraintValidatorTest.php
@@ -48,7 +48,6 @@ public function providerValidate() {
     $data = [];
 
     // Test allowed protocols.
-    $data[] = ['http://www.drupal.org', TRUE];
     $data[] = ['https://www.drupal.org', TRUE];
     $data[] = ['magnet:?xt=urn:sha1:YNCKHTQCWBTRNJIV4WNAE52SJUQCZO5C', TRUE];

Lets see patch passes all tests or not, changes addressed mentioned in comment #10 & attached interdiff also.

triggering bots.

Sorry, my bad was added interdiff as a patch. hope this patch will pass the tests.

I am not at all sure what bug this issue intends to fix. I am putting it on hold until the issue summary is updated with an explanation of what is broken in the test code that appears in patches posted so far.

It looks like all the remaining links to http://www.drupal.org are only in test code, which users do not see or click on. We do need to test http://, in URL generation since the web is far from 100% https.

The protocols of each test should stay the same. It might be best to use example.org for tests, instead of drupal.org, to make it clear that the domain is not relevant.

There are two links in system.install that look like they need updating:

147:        'description' => t('The minimum version of Apache needed to run Drupal without mod_rewrite enabled is 2.2.16. See the <a href=":link">enabling clean URLs</a> page for more information on mod_rewrite.', [':link' => 'http://drupal.org/node/15365']),
156:        'description' => t('Your server is capable of using clean URLs, but it is not enabled. Using clean URLs gives an improved user experience and is recommended. <a href=":link">Enable clean URLs</a>', [':link' => 'http://drupal.org/node/15365']),

These seem to redirect to the D7 handbook, so assuming there is a D8 equivalent this probably needs updating too.

Re #22. There is an issue to fix those the links in system module, #3002983: Convert http links to https at system module. Therefor changing this issue to change the drupal.org links in test to example.com as suggested in #21.

Divided this into several steps as follows:
$ grep -r http://drupal.org core | egrep Test.*.php | awk -F: '{print $1}' | sort -u | nl
1 core/modules/migrate/tests/src/Kernel/process/DownloadTest.php - Do not change, downloads https://www.drupal.org/favicon.ico
2 core/modules/migrate/tests/src/Kernel/process/FileCopyTest.php - Do not change, uses https://www.drupal.org/favicon.ico
3 core/modules/migrate/tests/src/Unit/process/MenuLinkParentTest.php - Changed
4 core/modules/views/tests/src/Functional/Plugin/DisplayTest.php - Changed
5 core/tests/Drupal/FunctionalTests/Libraries/JqueryUiLibraryAssetsTest.php - Do not change, in comment.
6 core/tests/Drupal/KernelTests/Core/Config/ConfigSchemaDeprecationTest.php - Do not change, part of deprecation message
7 core/tests/Drupal/Tests/Component/Utility/UrlHelperTest.php - Changed
$ grep -r https://drupal.org core | egrep Test.*.php | awk -F: '{print $1}' | sort -u | nl
1 core/modules/jsonapi/tests/src/Functional/JsonApiFunctionalTestBase.php - Changed
2 core/tests/Drupal/KernelTests/Core/Http/LinkRelationsTest.php - Fails if changed.
3 core/tests/Drupal/KernelTests/Core/Updater/UpdaterTest.php - Do not change, in comment.

grep -r http://www.drupal.org core | egrep Test.*.php | awk -F: '{print $1}' | sort -u | nl
1 core/modules/link/tests/src/Functional/Views/LinkViewsTokensTest.php - Changed
2 core/modules/link/tests/src/Unit/Plugin/Validation/Constraint/LinkExternalProtocolsConstraintValidatorTest.php - Changed
3 core/modules/media/tests/src/FunctionalJavascript/CKEditorIntegrationTest.php - TODO
4 core/modules/migrate_drupal/tests/src/Traits/CreateTestContentEntitiesTrait.php - Changed
5 core/modules/views/tests/src/Functional/Handler/FieldWebTest.php - Changed
6 core/modules/views/tests/src/Unit/Plugin/field/FieldPluginBaseTest.php - Changed
7 core/tests/Drupal/Tests/Core/Validation/Plugin/Validation/Constraint/PrimitiveTypeConstraintValidatorTest.php - Changed

This patch has the above changes.

Stll to do:
Any file listed above that is marked TODO. Changing https://www.drupal.org in tests, if any in an actual test. Most of these will be legitimate use in deprecation or comments.

Patch #28 applied cleanly on 9.2.x.

Since this is about tests, moving to phpunit.

Patch #28 applied successfully in durpal-9.3.x-dev
Thanks for the patch

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Re-roll patch #28 for Drupal 10.1.x

Addressed #37 fixed patch applied failed. #28 comments Found few new files address that accordingly.

grep -r http://drupal.org core | egrep Test\*.php | awk -F: '{print $1}' | sort -u | nl

• core/modules/link/tests/src/Functional/LinkFieldUITest.php : changed
• core/tests/Drupal/Tests/Component/Plugin/PluginHelperLegacyTest.php : not change, part of deprecation message

grep -r https://drupal.org core | egrep Test\*.php | awk -F: '{print $1}' | sort -u | nl

• core/modules/announcements_feed/tests/src/Unit/AnnounceFetcherUnitTest.php : not change, test validate url sample
• core/modules/ckeditor5/tests/src/FunctionalJavascript/MediaTest.php : changed
• core/modules/link/tests/src/FunctionalJavascript/LinkFieldFormStatesTest.php : changed
• core/modules/update/tests/src/Unit/ProjectReleaseTest.php : changed
• core/tests/Drupal/FunctionalTests/HttpKernel/CorsIntegrationTest.php : not change, test validate url sample
• core/tests/Drupal/Tests/Core/Logger/LogMessageParserTest.php : changed

grep -r http://www.drupal.org core | egrep Test\*.php | awk -F: '{print $1}' | sort -u | nl

• core/modules/media/tests/src/FunctionalJavascript/CKEditorIntegrationTest.php - D10 does not exist.
• core/tests/Drupal/Tests/Core/Ajax/AjaxCommandsTest.php : not change, part of deprecation message

Applied patch and ran greps from #38 and every file not updated seems to be documented in #38 and #28.

Think this is good to go.

Committed/pushed to 11.x and cherry-picked to 10.1.x, thanks!

I did wonder briefly about the update module tests which are faking Drupal.org data, but it's still example data and it's easier not to have exceptions.