Problem/Motivation

The protocol given in the user-facing links at system.install should be https instead of http.

Steps to reproduce

Proposed resolution

Change http to https and drupal.org to www.drupal.org

Remaining tasks

Patch
Review
Create a followup, unless there already is one, to add a coding standard to ensure all links to drupal.org are https. See #8.
Commit

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#16 3002983-10.patch1.67 KBquietone
#10 3002983-10.patch1.67 KBsubson
#6 drupalorg-convert-http-to-https-3002983-drupal8.patch1.59 KBsahal_va
#2 drupalorg-convert-http-to-https-3002983-drupal7.patch1.59 KBsahal_va
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sahal_va created an issue. See original summary.

sahal_va’s picture

sahal_va CreditAttribution: sahal_va commented
FileSize
drupalorg-convert-http-to-https-3002983-drupal7.patch1.59 KB

Created the patch for the above issue. Please review and mention if any more changes are to be made. Thank you.

sahal_va’s picture

sahal_va CreditAttribution: sahal_va commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: drupalorg-convert-http-to-https-3002983-drupal7.patch, failed testing. View results

sahal_va’s picture

sahal_va CreditAttribution: sahal_va commented
Version: 7.x-dev » 8.7.x-dev
Status: Needs work » Needs review
sahal_va’s picture

sahal_va CreditAttribution: sahal_va commented
FileSize
drupalorg-convert-http-to-https-3002983-drupal8.patch1.59 KB

Created the patch for the above issue.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/modules/system/system.install
@@ -144,7 +144,7 @@ function system_requirements($phase) {
-        'description' => t('The minimum version of Apache needed to run Drupal without mod_rewrite enabled is 2.2.16. See the <a href=":link">enabling clean URLs</a> page for more information on mod_rewrite.', [':link' => 'http://drupal.org/node/15365']),
+        'description' => t('The minimum version of Apache needed to run Drupal without mod_rewrite enabled is 2.2.16. See the <a href=":link">enabling clean URLs</a> page for more information on mod_rewrite.', [':link' => 'https://drupal.org/node/15365']),

@@ -153,7 +153,7 @@ function system_requirements($phase) {
-        'description' => t('Your server is capable of using clean URLs, but it is not enabled. Using clean URLs gives an improved user experience and is recommended. <a href=":link">Enable clean URLs</a>', [':link' => 'http://drupal.org/node/15365']),
+        'description' => t('Your server is capable of using clean URLs, but it is not enabled. Using clean URLs gives an improved user experience and is recommended. <a href=":link">Enable clean URLs</a>', [':link' => 'https://drupal.org/node/15365']),

These should be https://www.drupal.org/node/... - the www. will avoid an unnecessary redirect for users and as we're updating the links here makes sense.

I reviewed the codebase for other http:://drupal.org links - there are some in the drupal7 db dump for migration testing so we should leave them alone and some in the migrate tests which I think should also be left alone. There's one in a code comment // @todo Move to storage http://drupal.org/node/1988712 that could be updated but I'd prefer to open a follow-up to add some form of coding standard to ensure all links to drupal.org are https.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

subson’s picture

subson CreditAttribution: subson as a volunteer commented
Status: Needs work » Needs review
FileSize
3002983-10.patch1.67 KB

re-rolling the patch with https://www.drupal.org links

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Issue summary: View changes
Related issues: +#2830239: Several URLs point to Drupal 7 documentation pages instead of Drupal 8

That link was updated in #2830239: Several URLs point to Drupal 7 documentation pages instead of Drupal 8 but the http did not get changed to https as is listed in the proposed resolution of that issue. As far as I can tell, it was a simple oversight.

And testing with 9.2.x

quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
Status: Needs review » Reviewed & tested by the community

The patch in #10 looks good. The scheme is now https and the www. has been added. The remaining occurrences are in tests or the migration test fixture for Drupal 7.

$ grep -r http://drupal.org core | awk -F: '{print $1}' 
core/misc/modernizr-additional-tests.es6.js
core/tests/Drupal/FunctionalTests/Libraries/JqueryUiLibraryAssetsTest.php
core/tests/Drupal/KernelTests/Core/Config/ConfigSchemaDeprecationTest.php
core/tests/Drupal/Tests/Component/Utility/UrlHelperTest.php
core/modules/config/tests/config_schema_deprecated_test/config/schema/config_schema_deprecated_test.schema.yml
core/modules/views/tests/src/Functional/Plugin/DisplayTest.php
core/modules/views/tests/src/Functional/Plugin/DisplayTest.php
core/modules/migrate_drupal/tests/fixtures/drupal7.php
core/modules/migrate_drupal/tests/fixtures/drupal7.php
core/modules/migrate_drupal/tests/fixtures/drupal7.php
core/modules/migrate_drupal/tests/fixtures/drupal7.php
core/modules/migrate/tests/src/Kernel/process/FileCopyTest.php
core/modules/migrate/tests/src/Kernel/process/DownloadTest.php
core/modules/migrate/tests/src/Unit/process/MenuLinkParentTest.php
quietone’s picture

quietone CreditAttribution: quietone as a volunteer commented
FileSize
3002983-10.patch1.67 KB

Re-uploading the patch so it tests with 9.2.x.

  • catch committed 22f7f46 on 9.2.x 
    Issue #3002983 by sahal_va, quietone, subson, alexpott: Convert http...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

Committed 22f7f46 and pushed to 9.2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.