[D7] No Sender

Just some (semi-)automated tests:

Git errors:

• Git default branch is not set, see the documentation on setting a default branch.

Review of the 7.x-1.x branch (commit 80599bd):

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  
  FILE: ./nosender.module
  --------------------------------------------------------------------------
  FOUND 2 ERRORS AFFECTING 2 LINES
  --------------------------------------------------------------------------
   1 | ERROR | [x] The PHP open tag must be followed by exactly one blank
     |       |     line
   5 | ERROR | [x] Doc comment short description must be on the first line
  --------------------------------------------------------------------------
  PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
  --------------------------------------------------------------------------
  
  Time: 117ms; Memory: 4Mb
  

• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

Yes, the PAReview.sh service is currently down. I'm working on a refurbished solution for it and was using your application for testing the script. - Feel free to open an issue in the PAReview.sh issue queue for your installation problems.

Altered git clone command to be used by non-maintainers.

And this is the result of the current check. The module documentation needs some fixes.

Review of the 7.x-1.x branch (commit aca8d45):

• Your README.txt does not follow the module documentation recommendations (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
  • The INTRODUCTION section is missing.
  • The REQUIREMENTS section is missing.
  • The INSTALLATION section is missing.
  • The CONFIGURATION section is missing.
• The nosender.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script.

Ok. Let's say the interpretation on whether there is a need for hook_help() or not is kind of fuzzy (and obviously also dependent on the final reviewer). The review suggestion to adding it comes up a lot of times. - Personally, I'd say it doesn't hurt adding it and definitely should be considered best practice for any matured module. (Probably we really have to ask within the best practices group to finally make sure.)

However, with the README we have an explicit requirement for Security Advisory Coverage in https://www.drupal.org/node/1587704, Section 5.3:

Please make sure you have a README-file that follows the guidelines for in-project documentation and is based upon the README Template.

I don't know what was first, the project page template or the README documentation that suggests using the content of the project pages. But Security Advisory Coverage want's you to use the README template, as it's the most recent agreed on schema (even it differs from the project page template).

Reviewed and did not find any further issues. (It's a small module anyway.)

Welcome to the club. ;) - No honestly, the final reviews take a long while to being processed. The Git admins seem not to being too active with final reviews or just too busy with other tasks. A final review includes checking the entire code base for obvious flaws, probably installing it on a test environment, and finally agreeing that the developer met all QA requirements. Above semi-automated checks and manual community reviews are just the first stage to not letting them have to start with low-quality code.

Sometimes there are batch accepts to clean the queue. Otherwise we just need to be patient till one of the admins has enough spare time to spend on the final review.

PS.: After a decent enough waiting time (a month+), you may gradually increase the priority of your issue. It might help in RTBC status. And meanwhile feel free to review other module applications for RTBC suitability.

Hi,
Its better to have maintainer email id and name in README.

Module looks good for me

RTBC+

@mforbes

Yes, it is optional, But if you put your email id or profile link, so users can directly contact to you.

The module is working perfectly. Nice job

Thank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.