----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 381 | WARNING | Doc comment indicates hook_form_alter() but function
     |         | signature is "THEMENAME_form_alter" instead of
     |         | "THEMENAME.info_form_alter". Did you mean
     |         | hook_form_FORM_ID_alter()?
----------------------------------------------------------------------
CommentFileSizeAuthor
#4 filename-issue-theme-extension-2935388-4.patch1.01 KBjncruces
#2 filename-issue-theme-extension-2935388-2.patch879 bytesmiteshmap

Comments

miteshmap created an issue. See original summary.

miteshmap’s picture

miteshmap
Primary language Gujarati
commented
Status: Active » Needs review
StatusFileSize
new filename-issue-theme-extension-2935388-2.patch879 bytes
qzmenko’s picture

qzmenko
Primary language Russian
Location Novosibirsk
commented
Status: Needs review » Reviewed & tested by the community

Same issue for me. I think it's normal situation what hook_form_alter may be used in theme.
Patch fixed problem.

jncruces’s picture

jncruces
Primary language Spanish
Location Sevilla
commented
StatusFileSize
new filename-issue-theme-extension-2935388-4.patch1.01 KB

I have this problem too but this patch only add the "theme" extension but I get the warning in a "profile".

My patch based on #2 adds the profile extension to the validation.

Greetings.

jncruces’s picture

jncruces
Primary language Spanish
Location Sevilla
commented
Status: Reviewed & tested by the community » Needs review
dorficus’s picture

dorficus commented
Status: Needs review » Reviewed & tested by the community

Tested the patch in #4 and I was able to pass linting. Good job, everyone!

hugovk’s picture

hugovk commented

RTBC number 2:

Reproduced with latest Drupal 8.6.7 and Coder 8.3.1.

Confirmed patch #4 fixes it.

Any chance of a merge and release?

Thank you!

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Version: 8.x-2.x-dev » 8.x-3.x-dev
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests

I think this makes sense. Can you add test cases and file a pull request against https://github.com/pfrenssen/coder where the automated test cases are run? Thanks!

tmanhollan’s picture

tmanhollan commented
Related issues: +#3066096: Project names calculated incorrectly for themes

See the related issue, https://www.drupal.org/project/coder/issues/3066096. It has an open PR with tests and it resolves this issue as well, similarly to #4, but also addresses the .info.yml file.

pfrenssen’s picture

pfrenssen
Location Sofia
commented
Status: Needs work » Closed (duplicate)

This has been fixed as part of #3066096: Project names calculated incorrectly for themes.