phpcs throwing warning for hook_form_alter in *.theme file. [#2935388]

----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 381 | WARNING | Doc comment indicates hook_form_alter() but function
     |         | signature is "THEMENAME_form_alter" instead of
     |         | "THEMENAME.info_form_alter". Did you mean
     |         | hook_form_FORM_ID_alter()?
----------------------------------------------------------------------

Comment	File	Size	Author
#4	filename-issue-theme-extension-2935388-4.patch	1.01 KB	jncruces
#2	filename-issue-theme-extension-2935388-2.patch	879 bytes	miteshmap

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

9 January 2018 at 14:18

miteshmap created an issue. See original summary.

Comment #2

miteshmap

Gujarati

CreditAttribution: miteshmap as a volunteer commented 3 February 2018 at 07:11

Status:

Active

» Needs review

File	Size
filename-issue-theme-extension-2935388-2.patch	879 bytes

Comment #3

qzmenko

Russian

Novosibirsk

CreditAttribution: qzmenko as a volunteer and at DrupalJedi commented 16 April 2018 at 17:37

Status:

Needs review

» Reviewed & tested by the community

Same issue for me. I think it's normal situation what hook_form_alter may be used in theme.
Patch fixed problem.

Comment #4

jncruces

Spanish

Sevilla

CreditAttribution: jncruces at SDOS commented 10 May 2018 at 14:58

File	Size
filename-issue-theme-extension-2935388-4.patch	1.01 KB

I have this problem too but this patch only add the "theme" extension but I get the warning in a "profile".

My patch based on #2 adds the profile extension to the validation.

Greetings.

Comment #5

jncruces

Spanish

Sevilla

CreditAttribution: jncruces at SDOS commented 10 May 2018 at 14:59

Status:

Reviewed & tested by the community

» Needs review

Comment #6

dorficus CreditAttribution: dorficus commented 15 May 2018 at 17:01

Status:

Needs review

» Reviewed & tested by the community

Tested the patch in #4 and I was able to pass linting. Good job, everyone!

Comment #7

hugovk CreditAttribution: hugovk at Digia for Yle - Finnish Broadcasting Company commented 23 January 2019 at 13:33

RTBC number 2:

Reproduced with latest Drupal 8.6.7 and Coder 8.3.1.

Confirmed patch #4 fixes it.

Any chance of a merge and release?

Thank you!

Comment #8

klausi

he/him||they/them

German

🇦🇹 Vienna

CreditAttribution: klausi at jobiqo - job board technology commented 30 March 2019 at 10:57

Version:	8.x-2.x-dev	» 8.x-3.x-dev
Status:	Reviewed & tested by the community	» Needs work
Issue tags:		+Needs tests

I think this makes sense. Can you add test cases and file a pull request against https://github.com/pfrenssen/coder where the automated test cases are run? Thanks!

Comment #9

tmanhollan CreditAttribution: tmanhollan commented 27 July 2019 at 03:12

See the related issue, https://www.drupal.org/project/coder/issues/3066096. It has an open PR with tests and it resolves this issue as well, similarly to #4, but also addresses the .info.yml file.