[D8] Siteimprove

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2866393

Project 2: https://www.drupal.org/node/2866392

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgprojectsiteimprovegit

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi cbccharlie,

I have found that you have generated a new token in install file using your servie 'siteimprove.utils'. And in readme.txt I have found:
Who can use this plugin?
The plugin requires a Siteimprove subscription to be used.
Signup for a [FreeTrial](https://siteimprove.com/account/create “Free trial”)
to test it out.

when I goto /admin/config/system/siteimprove page I found you have already generated token. I think this token must be generated after the subscription or there needs to be a check before generating a new token weather the user has an account with siteimprove.

Again this is a thought or suggestion, let me have your opinion.

Thanks :)

Can see redundant code im these functions siteimprove_form_node_form_alter() and siteimprove_form_taxonomy_term_form_alter()

and in siteimprove_entity_insert() and siteimprove_entity_update().

Those codes can be moved into a reusable function and call it from hook_form_HOOK_form_alter() alters

Hello guys, what is the purpose of this issue?

Looks like Siteimprove is already covered by the security advisory policy. It has stable releases and it's great!

I think we may mark this issue as "Fixed", how do you think?