[D7] URL patterns special chars

Please, see automated review of your project as its showing some errors.

https://pareview.sh/node/1558

Also, you should review git clone url in issue descripcion.

Hi fjgarlin,

The git repository link you have provided is the one under which you have the rights to download or edit as it is password protected. Thus kindly provide the public git link so that your project can be used.

I think this is the proper link: git clone --branch 7.x-1.x https://git.drupal.org/project/url_patterns_special_chars.git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi @fjgarlin!

here, my review:

General (manual review)

The main functionality of the module doesn't seem to work properly. Scenario tested:

Decoded URL: node/3?hello=1
OK - See "Decoded url query parameters.png"

Encoded URL: node/3%3Fhello%3D1
FAIL (not found) - See "Encoded url query parameters.png"

The problem is found on the line 17 of the main module file, as the second part of the condition returns FALSE:

if (strpos($url, '?') !== FALSE and empty($query)) {

var_dump($query) returns:

array (size=1)
  'destination' => string 'node/3?hola=1' (length=13)

Automated Review

Passed. It just recommends to write a SimpleTest/PHPUnit test.

Manual Review, following template

Individual user account
Yes: Follows

No duplication
Yes: Follows- I haven't been able to find a similar project.

Master Branch
Yes: Follows the guidelines for master branch.

Licensing
Yes: Follows the licensing requirements.

3rd party assets/code
Yes: Follows.

README.txt/README.md
No: Does not follow.. Please, replace the section "URL patterns special chars" by "Introduction" as required in guidelines for in-project documentation

Code long/complex enough for review
No: Does not follow. The module only presents one main file, with one function and fewer than 30 lines. Though, I don't think this should be a blocker.

Secure code
Yes: Meets the security requirements.

Coding style & Drupal API usage
No found issues.

Hi @fjgarlin,

thanks for the changes, that was the only application blocker.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/project/projectapplications/issues/2924157

Project 2: https://www.drupal.org/project/projectapplications/issues/2867664

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

Thank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.