Problem/Motivation

The Create a CSS class is difficult to translate properly. I changed it to Add CSS class as this is what the function really does - it adds additonal classes to the view wrappers/td's and so on.

Proposed resolution

Changed the string to Add CSS class.

Remaining tasks

RTBC the patch.

User interface changes

String change.

API changes

None

Data model changes

None

CommentFileSizeAuthor
#22 after_patch.png102.32 KBMunavijayalakshmi
#22 before_patch.png121.34 KBMunavijayalakshmi
#21 2864115-21.patch1.48 KBsmustgrave
#21 interdiff-2-21.txt2.18 KBsmustgrave
#8 2864115-8.png59.54 KBamit.drupal
#2 Issue-2864115-by-hass-Optimize-translatable-string.patch1.48 KBhass

Comments

hass created an issue. See original summary.

hass’s picture

hass commented
Status: Active » Needs review
Issue tags: +Needs backport to D7
StatusFileSize
new Issue-2864115-by-hass-Optimize-translatable-string.patch1.48 KB
hass’s picture

hass commented
Issue tags: -Needs backport to D7

Created an issue in views and linked it.

dawehner’s picture

dawehner
Primary language German
commented
Issue tags: +Needs usability review

This seems certainly an improvement!
Just adding the necessary tag for now.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Optimize translatable string » Simplify wording of "add css class" label in Views

Made the title more clear.

I've marked #2864117 as postponed until this one is decided upon.

hass’s picture

hass commented

@dawehner: Can we get this in now, please?

hass’s picture

hass commented
Title: Simplify wording of "add css class" label in Views » Simplify wording of "create a css class" label in Views
amit.drupal’s picture

amit.drupal commented
StatusFileSize
new 2864115-8.png59.54 KB

Wording of "create a css class" label found in 3 times in Views.

Patch #2 is working fine for me.
I think no any other improvement needed .

yoroy’s picture

yoroy commented
Issue tags: -Needs usability review +Usability

Should be fine! Maybe "usability" tag is enough here, seems like a straight forward enough change :)

yoroy’s picture

yoroy commented

I was looking in the style settings for configuring a field to see this in action but couldn't find it. Where does this setting live?

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Category: Bug report » Task
Issue tags: +Bug Smash Initiative

Triaged as daily issue for Bug Smash, reassign to Task category

mstrelan’s picture

mstrelan commented

FWIW it would be more correct to call it a HTML class.

smustgrave’s picture

smustgrave commented
StatusFileSize
new interdiff-2-21.txt2.18 KB
new 2864115-21.patch1.48 KB

Updated text based on #20.

Munavijayalakshmi’s picture

Munavijayalakshmi commented
Version: 9.4.x-dev » 9.5.x-dev
Assigned: Unassigned » Munavijayalakshmi
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new before_patch.png121.34 KB
new after_patch.png102.32 KB

Patch #21 was applied successfully and cleanly in 9.5.x.

Munavijayalakshmi’s picture

Munavijayalakshmi commented
Assigned: Munavijayalakshmi » Unassigned

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 21: 2864115-21.patch, failed testing. View results

smustgrave’s picture

smustgrave commented
Status: Needs work » Reviewed & tested by the community

Random failure putting back to RTBC

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 9d8aaef0c1 to 10.1.x and 37e205cc8c to 10.0.x and 15040b42e2 to 9.5.x. Thanks!

  • alexpott committed 9d8aaef on 10.1.x 
    Issue #2864115 by smustgrave, hass, amit.drupal, mstrelan: Simplify...

  • alexpott committed 37e205c on 10.0.x 
    Issue #2864115 by smustgrave, hass, amit.drupal, mstrelan: Simplify...

  • alexpott committed 15040b4 on 9.5.x 
    Issue #2864115 by smustgrave, hass, amit.drupal, mstrelan: Simplify...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.