[D7] Webform Email Triggers

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxJPHuxley2853952git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Please do not assign ticket yourself. See the workflow https://www.drupal.org/node/532400

Hi jphuxley,

Please check below manual review:

1. Line no 208 | WARNING | Unused variable $token_name.
2. Add hook_help in your module file.

@ishwar: those are nice tips for improvements, but probably not application blockers. I think you forgot to change the status - anything else that you found or should this be set to RTBC?

Please make sure you're using check_plain() or filter_xss() as on lines 43 & 52 of the webform_email_triggers.module file there are 2 possible security issues relating to variable sanitation.

I'm starting a manual review on this module.

Module is clear and secure, there are no issues by PHPCS, PAReview.sh only reports the obvious missing tests, but as we know a lot of other Security Team covered contribs have the same issue, so i don't feel it as a blocker :)

Review of the 7.x-1.x branch (commit 2165799):

• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

Also i've operated a manual review with functional tests, nothing really serious is found, except the missing token module dependency. I've made all my tests on a clean drupal7 installation, when this contrib wanted to be enabled, it asked webform, that asked ctools and views, that is perfectly fine, all of them got enabled, but when i wanted to use the contrib as it's written in its README.txt, i got the following warning: "User warning: The following module is missing from the file system: token. For information about how to fix this, see the documentation page. in _drupal_trigger_error_with_delayed_logging() (line 1143 of /ec/dev/server/fpfis/webroot/sources/tatabal/drupal7/includes/bootstrap.inc)." It should be fixed before application can turn to RTBC, but nothing else is discovered.

Bests,
Balazs.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi @JPHuxley,
i've checked the module's new version (from this commit: 8e63ba5e) again carefully and it works as it's expected - there is no issues with the code itself, it's well organised, nicely documented (header and inline ones too!), so as a result of this application i'm giving RTBC and also putting back the review bonus tag as it got removed even you've made them before :)
Nice work overall!
Bests,
Balazs.

Assigning Credits.