[D7] Field Ds Formatter Class

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxa651622852575git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Its manual review please check.

1- Blank readme file
2- Blank install file
3- Define as like
/**
* @file
* Adds a custom field class to the field's classes_array
* according to the field formatter settings.
*/

/**
* Implements hook_preprocess_field().
*/

4- Add hook_help().
5- Use proper formatting

Steps:
1) The description is not very clear , follow istruction : https://www.drupal.org/node/2190239
2) Edit file README.txt, follow istruction : https://www.drupal.org/docs/develop/documenting-your-project/readme-temp...
important : the max lenght of row is 80 character

There is an open issue on Field Formatter Class module to deal with this exact issue (https://www.drupal.org/node/1616426). I think it would be better to contribute to that project rather than creating an entirely new project.

Automated Review

No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

No: Causes module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

No: Does not follow the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

No: Does not follow the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

1. (*) You are requiring field_formatter_class and field as dependencies, but not display suite. You are using ds_get_field_settings so you will need to add this otherwise it may cause errors.
2. You have an entirely empty install file. This should be removed.
3. (*) Your readme file is empty. Please populate it using the README Template

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

I second all the problems noted by JPHuxley.

Clearly, if there is a small gap in either Display Suite or Field Formatter Class - a gap so small it can be fixed with two VERY short and un-original hook functions ...
then the best way to proceed is by submitting a patch to the parent module.

Making a new stand-alone project just to apply such a small repair is unhelpful for maintainers because improvements do not make it back into the original project, and unhelpful for users, as they would have to download and upgrade yet another module.

Please re-submit this as a patch.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.