[D7] Pay with Pay.jp

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxaniki472656004git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hello aniki47,

My findings for your module as follows:

pay_with_pay_jp.module

Line 57 and Line 66: The value for the 'access callback' must always be a string which is the the name of the function - never a function call. It may also be assigned the value TRUE or FALSE if the callback is always (or never) accessible. See https://www.drupal.org/node/109157

'access callback' => array('user_access'),
to
'access callback' => 'user_access',

Thank you,

Automated Review

A couple of minor coding standards issues: https://pareview.sh/node/1547

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

1. Declaring an empty variable $output on line 40 is fairly redundant.
2. (+) As @ashwinsh mentioned above, 'access callback' in hook_menu should be a string.
3. Does the library do validation of any kind? Because you're not really doing any on the pay_with_pay_jp_form, which means that users could enter silly data (like letters for CVC field) and it would still pass. Granted it would probably be declined due to invalid card details, but it would be nice to inform the user about mistakes.
4. There are a couple of strings not passed through the t() function on lines 14 and 36 of the pay_with_pay_jp_settings_form function.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Overall the code looks fine, I think after you have solved the access callback issue it should be ready for RTBC.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.