Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
18 Jan 2017 at 07:39 UTC
Updated:
26 Apr 2020 at 15:49 UTC
Jump to comment: Most recent
Comments
Comment #2
joverComment #3
PA robot commentedWe are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #4
joverComment #5
wouters_f commentedThe code is good, coding standards seem ok, valid php.
composer.json is missing , that could be useful (but is not required?).
Node references could be useful though (yes thats a feature request).
Afaik this could be a valid project.
Comment #6
joverComment #7
joverComment #8
joverComment #9
joverComment #10
joverI added a composer.json file to the project.
Comment #11
joverReviewed by tested by wouters_f.
Comment #12
joverReviewed and tested by wouters_f.
Comment #13
visabhishek commentedPlease do not mark own ticket as RTBC. See the workflow https://www.drupal.org/node/532400
@wouters_f : Please assign this ticket RTBC after your review or are there application blockers left and this should be "needs work"?
Comment #14
wouters_f commentedWe added this to our migration for 5000 articles.
There is a problem with linked images (in html) that split only to html and an image (without a link).
We are looking to solve this problem together.
The documented changes work properly.
Comment #15
joverThe "problem" wouters_f describes can easily be solved by implementing a new plugin which searches for < a >-tags around < i m g />-tags.
As this module serves as an API module, this specific use case does not necessarily has to be part of the module.
Comment #16
klausimanual review:
Otherwsie looks good to me.
Thanks for your contribution, Jochen!
I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.
Comment #22
avpadernoI am crediting the users who partecipated in this issue and in the duplicating one.