[D8] RiotJS

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

I did a review on your module.

Manual Review

Individual user account

[Yes: Follows] the guidelines for individual user accounts.

No duplication

[Yes: Does not cause] module duplication and/or fragmentation.

Master Branch

[No: Does not follow] the guidelines for master branch.
Currently the module only has 1 branch which follows the correct naming convention: "8.x-1.x"
So this means there's currently no alpha, beta or release candidate I suppose?
Anyway, the master branch should be deleted.

Licensing

[Yes: Follows] the licensing requirements.

3rd party assets/code

[Yes: Follows] the guidelines for 3rd party assets/code.

README.txt/README.md

[Yes: Follows] the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

[No: Does not follow] the guidelines for project length and complexity.

Secure code

[Yes: Meets the security requirements.]

Coding style & Drupal API usage

PAreview.sh
PAreview.sh gives some errors, see https://pareview.sh/node/842
Please make sure you have set a default branch for your module (more information about Setting a default branch).
composer.json
Maybe it's a good idea to include a composer.json file in the project so you can set the library as a dependency for the project.
And even more useful would be to add a section to the README on how to add RiotJS to someones project using Composer.
See the FlexSlider module for an example on how to add the Composer installation instructions (http://cgit.drupalcode.org/flexslider/tree/README.md?h=8.x-2.x).

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Manual review

Personal opinion:

You can use github.com to host your module instead of drupal.org, because this module isn't helpful at all.

It just provides a library definition (!) that you should download firstly before use this module.
I understand if you'll be created something like angularjs module (but I personally don't like modules that integrates some frontend frameworks with Drupal backend via modules) but you didn't.
It looks like doing for doing.
BTW: Every additional module will impact on Drupal performance.

@vlad.dancer: thank you for your review, but short modules are perfectly fine. Anything else that you found or should this be RTBC instead?

...

Thank you for your contribution!

I updated your account so you can opt into security advisory coverage now.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thank you, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks go the dedicated reviewer(s) as well.