I noticed that after update, alignment seems to have been removed from some of our images.
For instance on our production site, images of people are left aligned
http://ri2.sierraclub.org//content/about-0
On the dev site, the people images are no longer left aligned. (see attached)
When I login to the dev site, and look at the page -- the alignment is still there in the WYSIWYG
But if I click on image properties -- the alignment is not there.
Attaching versions of what it looks like on the Dev site on the page, and what it looks like in the WYSIWYG. Somehow the styles are preserved in the WYSIWYG code, but stripped out for the published page.
Legacy rendering is being used on this site.
I see the problem on other dev sites and their pages as well. It is not exclusive to this page.
Comment | File | Size | Author |
---|---|---|---|
#10 | test_left_and_right.png | 478.33 KB | joseph.olstad |
#10 | filter_settings.png | 23.87 KB | joseph.olstad |
wysiwyg-alignment.png | 170.49 KB | adriancotter | |
dev-alignment.png | 31.14 KB | adriancotter |
Comments
Comment #2
joseph.olstadHmm, might want to double check the html filter settings before and after the upgrade.
What version of media are you using in both of those scenarios?
have you tried the 7.x-2.x dev ?
Comment #3
joseph.olstadalso, are you using media_ckeditor ?
if so, which version (dev or release, if release, which release) ?
also, if you are using the wysiwyg module, which version are you using? I recommend the dev version of wysiwyg as the release version from 2012 has reported issues.
Comment #4
adriancotter CreditAttribution: adriancotter commentedWhat version of media are you using in both of those scenarios?
have you tried the 7.x-2.x dev ?
also, are you using media_ckeditor ?
I recommend the dev version of wysiwyg as the release version from 2012 has reported issues.
Comment #5
joseph.olstad@adriancotter
wysiwyg is a seperate project , not sure if you're using it or not.
when I mentioned wysiwyg please do not confuse this with media_wysiwyg .
media_wysiwyg is a sub module of media
wysiwyg is a seperate project on its own.
Comment #6
joseph.olstad@adriancotter , Thanks for your feedback. Can you please reply to comment #5? basically just need to know if you're using the wysiwyg module, if you are, which version and if not version , which dev?.
Comment #7
adriancotter CreditAttribution: adriancotter commentedWysiwyg that we are using is 2.2
It would be the same on dev and prod
Also -- just tried to edit an alignment in the Dev side, and the alignment is not pushed through to the front end.
Comment #8
joseph.olstadFYI: There are known compatibility issues in wysiwyg 2.2 that are resolved by upgrading to 7.x-2.x dev of wysiwyg (2.2 dates back to 2012 , released more than 4 years ago)
Might help to try 7.x-2.x dev of wysiwyg when using the latest media 7.x-2.0-beta14 .
Comment #9
adriancotter CreditAttribution: adriancotter commentedI updated to the latest dev version of WYSIWYG module on a local dev site
to Version: 7.x-2.2+86-dev
and it has made no difference... alignment still does not save.
You had said earlier: "might want to double check the html filter settings before and after the upgrade"
Could you be more specific about what to look at here? These ones? /admin/config/content/formats/rich_text_editor_format
however, I do have another site, which does not seem to have been affected. I haven't yet tracked down what the difference might be (the only thing so far is that one does also have IMCE on the site).
Comment #10
joseph.olstadI've created a test environment on a D7 vanilla , fresh install
installed
media 7.x-2.0-beta14
media_ckeditor 7.x-2.0-alpha4
ckeditor 7.x-1.17
here's my filter settings:
And left and right alignment testing:
Comment #11
joseph.olstadI cannot reproduce this problem. Please provide steps for reproducing the issue and more details.
Here is what the source html markup looks like (in the wysiwyg ckeditor source):
there are options for formatting how ckeditor generates this stuff too, double check the global ckeditor settings and all your ckeditor profile settings including compare your filter settings and order of processing.
Comment #12
joseph.olstadwhich gets rendered to this:
that's just the first image right aligned
Comment #13
adriancotter CreditAttribution: adriancotter commentedOkay, I think I know the issue -- I'd not fine tuned the file type display (manage file display of images) on a couple of sites... so on the updated site, before I fine tuned, this is how the HTML is looking:
Updated (but poorly defined file types)
Here's the rendered HTML looking in the WYSIWYG:
And here's the rendered HTML on the page:
Before the Update (with same poorly defined file types)
it was getting rendered properly as below:
One of the updates affected how the rendering is happening, and was putting everything into styles in the span around the IMG which seems a little weird.
But I have a way forward now, and can deal with that fairly easily.
Thanks for help in troubleshooting, Joseph.
Comment #14
adriancotter CreditAttribution: adriancotter commentedActually, now that I am looking at the production sites, it does not look like a function of the update at all, but a problem of mine -- not having fixed things on various dev versions of sites
So mea culpa, apologies for the waste of time (including too much of my own).
Comment #15
joseph.olstadFYI there I did see a patch in likely media_ckeditor dealing with improved alignment, follow-up soon, might helpful
Comment #16
Chris Matthews CreditAttribution: Chris Matthews as a volunteer commentedRecent versions of media have resolved most of peoples concerns and is compatible with entity translation, multilingual and various advanced configurations. Due to the high volume of inactive and most often irrelevant issues we are Closing this as (outdated). If for whatever reason this issue is important to you AND you still have issues after checking the media recipe documentation, then let us know and we will review your concerns.
Otherwise, see the recipe documentation for how to configure media and for troubleshooting tips OR refer to the media_dev distribution if you want to see a working media setup.
As mentioned, feel free to make some noise in this issue if you still feel it is important to you or someone else.
Thanks,
Media team