Several URLs point to Drupal 7 documentation pages instead of Drupal 8

This is ok for me! The patch applies and also the urls are right.

We will close #2830260: The update modules handbook help link points to the D7 page and have one issue (this one) to fix all the bad handbook links.

@cilefen patch updated with #2830260: The update modules handbook help link points to the D7 .

@cebasqueira there is one more that points to wrong url

core/lib/Drupal/Core/FileTransfer/Form/FileTransferAuthorizeForm.php

I'm not sure if this one should also be changed.

Patch updated!

For me it is ok now

This needs a title and summary update to reflect the current scope.

@cilefen I've update the summary and title, is this ok now?

thank you

@cilefen I've update the summary and title, is this ok now?

thank you

So as the patch works fine, I'm put as RTBC

patch worked for me as well.

We can only fix this in 8.3.0 because we shouldn't be changing translatable strings in patch releases. For example:

+++ b/core/lib/Drupal/Core/Installer/Form/SiteSettingsForm.php
@@ -188,7 +188,7 @@ protected function getDatabaseErrors(array $database, $settings_file) {
-        '#template' => '{% trans %}Resolve all issues below to continue the installation. For help configuring your database server, see the <a href="https://www.drupal.org/getting-started/install">installation handbook</a>, or contact your hosting provider.{% endtrans%}{{ errors }}',
+        '#template' => '{% trans %}Resolve all issues below to continue the installation. For help configuring your database server, see the <a href="https://www.drupal.org/docs/8/install">installation handbook</a>, or contact your hosting provider.{% endtrans%}{{ errors }}',

This will break all translations. We've started to put links in urls so people can internationalise the links and point to translated help. So this is correct rather the other links where we use a placeholder. Fixing such text is out-of-scope here though - please file a follow up it'd be good to get that done before 8.3.0 to minimise string change though :)

After applying the patch - looks like we should fix these here too - to be consistent everywhere:

grep -R "https://www.drupal.org/getting-started" ./core/
./core//INSTALL.txt:   https://www.drupal.org/getting-started/clean-urls to troubleshoot.

grep -R "http.://www.drupal.org/documentation/install" ./core/
./core//CHANGELOG.txt:    * See https://www.drupal.org/documentation/install/download#git
./core//INSTALL.txt:settings, consult https://www.drupal.org/documentation/install/multi-site

https://www.drupal.org/getting-started/clean-urls => https://www.drupal.org/docs/8/clean-urls-in-drupal-8
https://www.drupal.org/documentation/install/download#git => this is about composer... I guess https://www.drupal.org/docs/8/install/before-installation will take you to the right places... but maybe we need a nice URL for https://www.drupal.org/node/2404989
https://www.drupal.org/documentation/install/multi-site => https://www.drupal.org/docs/8/multisite-drupal

See #12 as the issue changes.

I ran into one of these links when I tried installing Drupal with .htaccess missing. The warning message in the installer directed me to http://drupal.org/node/15365, the unaliased (and HTTP, insecure) URL for https://www.drupal.org/docs/7/configuring-clean-urls/enable-clean-urls. The link https://www.drupal.org/getting-started/clean-urls (Comment #25 above) redirects to the same page.

In addition to the searches in #25,

$ grep -R "node/15365" core
core/modules/system/system.install:        'description' => t('The minimum version of Apache needed to run Drupal without mod_rewrite enabled is 2.2.16. See the <a href=":link">enabling clean URLs</a> page for more information on mod_rewrite.', [':link' => 'http://drupal.org/node/15365']),
core/modules/system/system.install:        'description' => t('Your server is capable of using clean URLs, but it is not enabled. Using clean URLs gives an improved user experience and is recommended. <a href=":link">Enable clean URLs</a>', [':link' => 'http://drupal.org/node/15365']),

I will update the issue summary.

Now that I have updated the summary, I think we can call this a Novice task, so I am adding that tag. Let's try to get this done!

As noted in #22, we cannot update translatable strings in a patch release. At this point, that means the earliest we can do this will be in Drupal 8.7.0.

Attached patch updates URLs mentioned in issue description.

@th_tushar: Thanks for working on this! Since the issue is marked "Novice", and you are a Technical Lead at your company, with 16 people listing you as a mentor on d.o, you could have coached someone else to work on this.

Somehow, your patch was mis-named: it ends in "-36.patch" but is attached to Comment #34. We do not have to fix it, but I want to mention it to avoid confusion.

Please also attach an interdiff, comparing your patch to the previous one. See https://www.drupal.org/documentation/git/interdiff if you need instructions.

I see that you noticed another link that needs to be updated: https://www.drupal.org/documentation/multilingual in INSTALL.txt. Good catch, but please note what the issue summary says about expanding scope. For documentation purposes, please add that link, the one it redirects to, and the unaliased path to the table in the issue description, and add corresponding grep searches (with the results on an unpatched version of 8.7.x).

Updated issue description (table and grep statement with results) as proposed in #35.

Wanted to create interdiff but patch "mistake_in_the_url_of-2830239-10.patch" is not applicable to current branch of 8.7.x.

$ git apply mistake_in_the_url_of-2830239-10.patch
error: patch failed: core/lib/Drupal/Core/FileTransfer/Form/FileTransferAuthorizeForm.php:175
error: core/lib/Drupal/Core/FileTransfer/Form/FileTransferAuthorizeForm.php: patch does not apply
error: core/modules/system/src/Tests/Installer/InstallerTranslationTest.php: No such file or directory
error: patch failed: core/modules/update/update.manager.inc:99
error: core/modules/update/update.manager.inc: patch does not apply

Also online tools to create interdiff did not work.

I would propose to test the current patch without an interdiff.

Found another comment with mention of Drupal 7 docs:

• core/modules/system/system.install -> https://www.drupal.org/docs/7/system-requirements/php#csprng -> https://www.drupal.org/docs/8/system-requirements/php-requirements

I've updated the issue summary and will add the lines to the patch.

Added new patch and interdiff for link change mentioned in comment #38.

Additionally, another mention of Drupal 7 docs was found but this one is correct as it specifically mentions Drupal 7:

$ grep -irl "docs/7/" core
core/themes/seven/README.txt

To read more about the Seven theme's origins (in Drupal 7) please see:
https://www.drupal.org/docs/7/core/themes/seven

This should stay unchanged.

I noticed a related issue: #2855175: [META] Many documentation / handbook URLs redirect to D7 content. Curiously, it looks as though there is no overlap between the links found there and the ones found in this issue. Maybe I have to read it more closely.

@spitzialist, good point about the link for the history of the Seven theme. I added a note to the issue summary to check for this.

To review the patch, I did the following:

• Run the grep commands from the issue summary, and check that the result is similar to what it shows in the summary. (I updated the summary where it was missing a couple of matches.)
• Apply the patch.
• Run the grep commands again. Check that nothing is found, except as noted above.
• Open each of the links from the patch in a web browser to make sure that we are not introducing any broken links.

It all looks good to me, so I am marking the issue RTBC. I am also removing the Novice tag, since the novice tasks have already been done.

+++ b/core/lib/Drupal/Core/Installer/Form/SiteSettingsForm.php
@@ -190,7 +190,7 @@ protected function getDatabaseErrors(array $database, $settings_file) {
+        '#template' => '{% trans %}Resolve all issues below to continue the installation. For help configuring your database server, see the <a href="https://www.drupal.org/docs/8/install">installation handbook</a>, or contact your hosting provider.{% endtrans%}{{ errors }}',

Since we're changing the string here, should we consider making it use <a href=":link" so that the next time the URL is updated, the translation won't need to?

@catch: I think that is the same change that @alexpott discussed in Comment #22:

This will break all translations. We've started to put links in urls so people can internationalise the links and point to translated help. So this is correct rather the other links where we use a placeholder. Fixing such text is out-of-scope here though ...

Based on that, I added this when I updated the issue summary:

This issue is just about updating the links. Some of them are explicit strings, like ..., and others are arguments to the t() function, like ... . Being more consistent is out of scope for this issue, and may be a mistake. See Comment #22 below.

Did I over-generalize?

I have not re-reviewed, but I think I have answered the question in #41, so I will move this issue back to RTBC.

@benjifisher thanks that makes sense - however the patch also needs a re-roll.

This looks like a pretty easy reroll, so I will add the Novice label and update the issue summary.

The conflict comes from #2856362: Drupal install fail on Percona XtraDB Cluster 5.7 (pxc_strict_mode enforced).

Added a rerolled patch.

Adding a new patch.

@imalabya:

Since you are an experienced contributor, with several people who list you as a mentor, maybe next time you come across a Novice issue you can help someone less experienced to fix it.

Thanks for the updated patch. The only differences between your patch in #47 and the patch in #39 are

• One context line, which was updated as part of #2856362: Drupal install fail on Percona XtraDB Cluster 5.7 (pxc_strict_mode enforced).
• Some git "index" lines.

Based on my previous review, and the comparison I made when I added #45, I can move this issue back to RTBC.

Committed b5ff72a and pushed to 8.7.x. Thanks!

Thanks to all who helped on this issue! If you want to work on something similar, but more ambitious, have a look at #2855175: [META] Many documentation / handbook URLs redirect to D7 content.

The proposed resolution states that http://drupal.org/node/15365 is to be changed to https://www.drupal.org/docs/8/clean-urls-in-drupal-8 but that did not happen. The link was changed but not the scheme.

There is an existing issue that identified the scheme, #3002983: Convert http links to https at system module